-
Notifications
You must be signed in to change notification settings - Fork 3k
[Tools] Add simple build profiles to toolchains #2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3d3c90
to
aaac6cb
Compare
cc @screamerbg |
ff3cfce
to
303d983
Compare
Are test automatically ran or do they need to be added to travis.yaml or is it there already? |
I already added the tests to Travis and they ran successfully. |
Lots of CI failures. Wonder if we can get this re-ran? |
Simplest way to retrigger a run on everything would be to rebase and push up the change |
a61d20d
to
a643778
Compare
Amended last commit to change the hash. |
a643778
to
fe222d0
Compare
fe222d0
to
f2ab1a6
Compare
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 994 Build failed! |
4e7cd73
to
50766bd
Compare
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 999 Build failed! |
50766bd
to
73e811a
Compare
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: null Examples Build failed! |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: null Examples Build failed! |
This is a policy decision and it should /really/ be in the config system ATM it's here for backward compatibility
0bb9129
to
7348b01
Compare
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1014 All builds and test passed! |
@theotherjimmy A note - is -o debug-info completely not supported -> breaking change within this PR? Based on what I have seen, I would say it is. I would expect to at least print a warning and pinpoint a user to new profiles (backward compatibility woudl be better for certain period of time maybe?). I was already asked 2x about this and had to explain them how to use new profiles and where to find a documentation. |
Description
Allow for json profiles in the build system
Status
IN DEVELOPMENT
Migrations
Yes,
-o
is replaced by things likembed compile -t gcc_arm -m k64f --profile mbed-os/profiles/debug.json
Todos
-o
optionSteps to test or reproduce
It's a feature not a bug report, so just do the migration thing.