Skip to content

[Tools] Add simple build profiles to toolchains #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2016

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Sep 23, 2016

Description

Allow for json profiles in the build system

Status

IN DEVELOPMENT

Migrations

Yes, -o is replaced by things like mbed compile -t gcc_arm -m k64f --profile mbed-os/profiles/debug.json

Todos

  • Provide a profile to replace each -o option
  • Tests
  • Documentation

Steps to test or reproduce

It's a feature not a bug report, so just do the migration thing.

@theotherjimmy
Copy link
Contributor Author

cc @screamerbg

@sg-
Copy link
Contributor

sg- commented Sep 28, 2016

Are test automatically ran or do they need to be added to travis.yaml or is it there already?

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Sep 28, 2016

I already added the tests to Travis and they ran successfully.

@sg-
Copy link
Contributor

sg- commented Sep 28, 2016

Lots of CI failures. Wonder if we can get this re-ran?

@bridadan
Copy link
Contributor

Simplest way to retrigger a run on everything would be to rebase and push up the change

@theotherjimmy
Copy link
Contributor Author

Amended last commit to change the hash.

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 994

Build failed!

@theotherjimmy theotherjimmy force-pushed the toolchain-profiles branch 2 times, most recently from 4e7cd73 to 50766bd Compare September 29, 2016 14:01
@theotherjimmy
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 999

Build failed!

@theotherjimmy
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: null

Examples Build failed!

@theotherjimmy
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: null

Examples Build failed!

This is a policy decision and it should /really/ be in the config system
ATM it's here for backward compatibility
@theotherjimmy
Copy link
Contributor Author

/morph test

@screamerbg screamerbg changed the title Add simple build profiles to toolchains [Tools] Add simple build profiles to toolchains Sep 30, 2016
@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1014

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2016

@theotherjimmy A note - is -o debug-info completely not supported -> breaking change within this PR? Based on what I have seen, I would say it is.

I would expect to at least print a warning and pinpoint a user to new profiles (backward compatibility woudl be better for certain period of time maybe?). I was already asked 2x about this and had to explain them how to use new profiles and where to find a documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants