Skip to content

[Exporters] Resolving Python errors and uVision build issues #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2016

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Oct 3, 2016

Description

This PR is in response to issue #2892, with commits from both myself and @sarahmarshy.

When build profiles came in (#2802), the exporter build test script was missed. There were also some exporter script issues left over from the reorganization (#2878). This PR fixes those issues.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Todos

@@ -83,11 +83,14 @@ def generate(self):
+ self.flags['c_flags']
+ self.flags['cxx_flags']))
# not compatible with c99 flag set in the template
project_data['misc']['c_flags'].remove("--c99")
try:project_data['misc']['c_flags'].remove("--c99")
except ValueError: pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how many times that we do this, we should have a utility function that does it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it.

@bridadan
Copy link
Contributor Author

bridadan commented Oct 3, 2016

/morph export-build

Copy link
Contributor

@sarahmarshy sarahmarshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending build tests, I approve. Should we run release 2 tests too?

@mbed-bot
Copy link

mbed-bot commented Oct 3, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

@bridadan
Copy link
Contributor Author

bridadan commented Oct 3, 2016

The above run tested the mbed 5 tests, this run will do mbed 2 tests (editing config behind the scenes, sorry!)

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Oct 3, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

@bridadan
Copy link
Contributor Author

bridadan commented Oct 3, 2016

mbed 5 tests looked a lot better, uVision is all passing again. IAR has a known issue with the Callback class at the moment (out of scope of this PR as it is a device code failure, not a tool issue).

mbed 2 tests are in bad shape. The export succeeded but the build failed for IAR and uVision. They'll need some more love. Also most likely outside of the scope of this PR.

As the PR stands, I think it's ok to merge seeing how nothing is working on master at the moment 😄

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants