Update K66F to SDK 2.2 #4982

mmahadevan108 · 2017-08-28T14:18:49Z

Some of these updates in the driver is needed for DSPI HAL driver and Flash HAL driver.

Status

**READY

Tests
Passed all mbed tests

mmahadevan108 · 2017-08-28T14:19:17Z

cc @0xc0170 @maclobdell @deepikabhavnani

studavekar · 2017-09-02T06:12:22Z

/morph test

studavekar · 2017-09-02T07:04:39Z

Build failure

00:02:08.729 [DEBUG] Output: "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU_CESR_VLD_MASK" is undefined
00:02:09.275 Traceback (most recent call last):
00:02:09.275   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/make.py", line 296, in <module>
00:02:09.275     stats_depth=options.stats_depth)
00:02:09.275   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/build_api.py", line 539, in build_project
00:02:09.528     objects = toolchain.compile_sources(resources, resources.inc_dirs)
00:02:09.528   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/toolchains/__init__.py", line 922, in compile_sources
00:02:09.756     return self.compile_queue(queue, objects)
00:02:09.756   File "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/mbed-os/tools/toolchains/__init__.py", line 985, in compile_queue
00:02:09.756     raise ToolException(err)
00:02:09.756 ToolException: 
00:02:09.756       MPU->CESR &= ~MPU_CESR_VLD_MASK;
00:02:09.756       ^
00:02:09.756 "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU" is undefined
00:02:09.756 
00:02:09.756       MPU->CESR &= ~MPU_CESR_VLD_MASK;
00:02:09.756                     ^
00:02:09.756 "/home/jenkins/mbed_jenkins_iar_03_b12/workspace/bm_wrap/1262/examples/nanostack-border-router/drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c",42  Error[Pe020]: identifier "MPU_CESR_VLD_MASK" is undefined
00:02:09.756

mbed-bot · 2017-09-02T07:14:32Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1165

Example Build failed!

0xc0170 · 2017-09-04T08:57:25Z

@mmahadevan108 CAn you please check CI results? There are example build errors:

02:05:15 "./drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c", line 42: Error:  #20: identifier "MPU" is undefined
02:05:15 "./drivers/TARGET_MCUXpresso_MCUS/sal-nanostack-driver-k64f-eth/source/TARGET_K66F/hardware_init.c", line 42: Error:  #20: identifier "MPU_CESR_VLD_MASK" is undefined

mmahadevan108 · 2017-09-04T12:48:35Z

@0xc0170 Could you help apply the attached patch to the sal-nanostack-driver-k64f-eth repository
0001-Update-needed-for-SDK-2.2-update.zip

0xc0170 · 2017-09-04T13:58:46Z

@0xc0170 Could you help apply the attached patch to the sal-nanostack-driver-k64f-eth repository
0001-Update-needed-for-SDK-2.2-update.zip

@SeppoTakalo Can you please help, how to update the nanostack dependency ?

SeppoTakalo · 2017-09-06T09:38:47Z

Please send a PR https://github.com/ARMmbed/sal-nanostack-driver-k64f-eth

mmahadevan108 · 2017-09-06T14:44:22Z

PR for this is PelionIoT/sal-nanostack-driver-k64f-eth#19

mmahadevan108 · 2017-09-12T13:33:27Z

@0xc0170 Can this update be integrated into the code-base.

mmahadevan108 · 2017-09-18T18:11:31Z

Anything else needed for this PR?

0xc0170 · 2017-09-19T12:00:07Z

Anything else needed for this PR?

Resolve the conflict please. Is there a way to resolve this cyclic dependency? the other PR for the driver eth is blocking this one and it's blocked because of this one (they depend on each other).
Can this change be made backward-compatible for now?

0xc0170 · 2017-09-19T12:02:02Z

I left the comment in the eth driver PR, to make this backward compatible and enable this PR to be integrated. @mmahadevan108 Please review

0xc0170 · 2017-09-20T11:53:07Z

Can you please resolve the conflict? The driver update was merged, we should be able to run the CI job

mmahadevan108 · 2017-09-20T14:19:40Z

Merge conflicts have been resolved.

theotherjimmy · 2017-09-21T14:16:01Z

/morph test

mbed-bot · 2017-09-22T05:04:56Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1357

Build failed!

0xc0170 · 2017-09-24T06:07:25Z

@mmahadevan108 Please see the failure, you are touching file for LPC54114 in this patch (is it intentional) ? As it removes some functions that are used, thus the error.

Signed-off-by: Mahadevan Mahesh <[email protected]>

mmahadevan108 · 2017-09-24T13:17:09Z

@0xc0170 Thank you for catching this. This was an error on my part, I have updated the patch.

0xc0170 · 2017-09-24T17:50:18Z

/morph test

mbed-bot · 2017-09-24T18:44:12Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1379

Example Build failed!

mmahadevan108 · 2017-09-25T12:38:38Z

@0xc0170 Is the failure still related to the below?
[Error] hardware_init.c@42,0: #20: identifier "MPU" is undefined
[Error] hardware_init.c@42,0: #20: identifier "MPU_CESR_VLD_MASK" is undefined

Can you confirm the build system is picking up the latest changes for sal-nanostack-driver-k64f-eth?

0xc0170 · 2017-09-25T13:43:46Z

@mmahadevan108 We need to also update the lib configuration files (to update the driver), here https://github.com/ARMmbed/nanostack-border-router/tree/master/drivers. Can you please send a patch to update to the latest (so the fix gets in). Thus failure is legit

mmahadevan108 · 2017-09-25T14:05:14Z

Below is the PR to update the K64F library.
PelionIoT/nanostack-border-router#61

mmahadevan108 · 2017-09-25T15:06:13Z

@0xc0170 . The PR to update the K64F library has been integrated. Can we restart the build.

0xc0170 · 2017-09-26T14:00:00Z

/morph test

mbed-bot · 2017-09-26T17:35:33Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1394

All builds and test passed!

maclobdell mentioned this pull request Aug 29, 2017

add flash iap and bootloader support to K66F #4989

Merged

theotherjimmy added the needs: review label Aug 29, 2017

0xc0170 approved these changes Aug 31, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Aug 31, 2017

0xc0170 added needs: work and removed needs: CI labels Sep 4, 2017

0xc0170 added needs: CI and removed needs: work labels Sep 20, 2017

0xc0170 added needs: work and removed needs: CI labels Sep 20, 2017

mmahadevan108 force-pushed the Update_K66_SDK22 branch from e3a39c6 to 42e94f1 Compare September 20, 2017 14:18

0xc0170 added needs: CI and removed needs: work labels Sep 20, 2017

0xc0170 added needs: work and removed needs: CI labels Sep 24, 2017

mmahadevan108 added 2 commits September 24, 2017 08:14

K66F: Update to SDK 2.2

593fb3a

Signed-off-by: Mahadevan Mahesh <[email protected]>

K66F: Use DSPI SDK driver API's in spi block read

d9a8c63

Signed-off-by: Mahadevan Mahesh <[email protected]>

mmahadevan108 force-pushed the Update_K66_SDK22 branch from 42e94f1 to d9a8c63 Compare September 24, 2017 13:16

0xc0170 added needs: CI and removed needs: work labels Sep 26, 2017

0xc0170 added ready for merge and removed needs: CI labels Sep 27, 2017

theotherjimmy merged commit 760fc33 into ARMmbed:master Sep 27, 2017

theotherjimmy added release-version: 5.6.2 and removed ready for merge labels Sep 27, 2017

mmahadevan108 deleted the Update_K66_SDK22 branch September 30, 2017 12:02

Update K66F to SDK 2.2 #4982

Update K66F to SDK 2.2 #4982

Uh oh!

Conversation

mmahadevan108 commented Aug 28, 2017

Status

Uh oh!

mmahadevan108 commented Aug 28, 2017

Uh oh!

studavekar commented Sep 2, 2017

Uh oh!

studavekar commented Sep 2, 2017

Uh oh!

mbed-bot commented Sep 2, 2017

Result: FAILURE

Output

Uh oh!

0xc0170 commented Sep 4, 2017

Uh oh!

mmahadevan108 commented Sep 4, 2017

Uh oh!

0xc0170 commented Sep 4, 2017

Uh oh!

SeppoTakalo commented Sep 6, 2017

Uh oh!

mmahadevan108 commented Sep 6, 2017

Uh oh!

mmahadevan108 commented Sep 12, 2017

Uh oh!

mmahadevan108 commented Sep 18, 2017

Uh oh!

0xc0170 commented Sep 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Sep 19, 2017

Uh oh!

0xc0170 commented Sep 20, 2017

Uh oh!

mmahadevan108 commented Sep 20, 2017

Uh oh!

theotherjimmy commented Sep 21, 2017

Uh oh!

mbed-bot commented Sep 22, 2017

Result: FAILURE

Output

Uh oh!

0xc0170 commented Sep 24, 2017

Uh oh!

mmahadevan108 commented Sep 24, 2017

Uh oh!

0xc0170 commented Sep 24, 2017

Uh oh!

mbed-bot commented Sep 24, 2017

Result: FAILURE

Output

Uh oh!

mmahadevan108 commented Sep 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Sep 25, 2017

Uh oh!

mmahadevan108 commented Sep 25, 2017

Uh oh!

mmahadevan108 commented Sep 25, 2017

Uh oh!

0xc0170 commented Sep 26, 2017

Uh oh!

mbed-bot commented Sep 26, 2017

Result: SUCCESS

Output

Uh oh!

Uh oh!

0xc0170 commented Sep 19, 2017 •

edited

Loading

mmahadevan108 commented Sep 25, 2017 •

edited

Loading