-
Notifications
You must be signed in to change notification settings - Fork 3k
add flash iap and bootloader support to K66F #4989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flash iap and bootloader support to K66F #4989
Conversation
Please note, that this will fail to build until PR 4982 is merged. |
|
||
if (!isdefinedsymbol(MBED_APP_SIZE)) { | ||
define symbol MBED_APP_SIZE = 0x100000; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 0x200000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! I just pushed another commit to fix it. Thanks!
targets/targets.json
Outdated
@@ -645,7 +645,7 @@ | |||
"macros": ["CPU_MK66FN2M0VMD18", "FSL_RTOS_MBED"], | |||
"inherits": ["Target"], | |||
"detect_code": ["0311"], | |||
"device_has": ["ANALOGIN", "ANALOGOUT", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_FC", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES", "TRNG"], | |||
"device_has": ["ANALOGIN", "ANALOGOUT", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_FC", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES", "TRNG", "FLASH"], | |||
"features": ["LWIP"], | |||
"release_versions": ["2", "5"], | |||
"device_name": "MK66FN2M0xxx18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add "bootloader_supported": true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is there.
"features": ["LWIP"], | ||
"release_versions": ["2", "5"], | ||
"device_name": "MK66FN2M0xxx18" | ||
"device_name": "MK66FN2M0xxx18", | ||
"bootloader_supported": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bootloader is enabled here: "bootloader_supported": true
@maclobdell. Could you please rebase, PR 4982 has been merged. |
Please rebase and let us know, we will trigger CI tests |
@maclobdell bump |
Just rebased and pushed. I checked that everything compiles with iar, armcc, and gcc compilers. |
@mmahadevan108 @0xc0170 Does this need a re-review ? |
Looks good to me. |
/morph build |
Build : FAILUREBuild number : 196 |
Build : SUCCESSBuild number : 198 Triggering tests/morph test |
Test : SUCCESSBuild number : 97 |
Build : SUCCESSBuild number : 207 Triggering tests/morph test |
Build : SUCCESSBuild number : 210 Triggering tests/morph test |
Test : SUCCESSBuild number : 103 |
Build : SUCCESSBuild number : 216 Triggering tests/morph test |
Test : SUCCESSBuild number : 106 |
/morph uvisor-test |
Description
Updates the linker files and configuration to enable flash in-application-programming and bootloader support on K66F. This requires updates to the flash drivers for K66F, which are in a separate PR.
Status
Hold until #4982 is merged.
Migrations
NO
Related PRs
#4982
Todos
N/A
Deploy notes
N/A
Steps to test or reproduce
This was tested with https://github.com/ARMmbed/mbed-os-example-bootloader and was successful.
cc @mmahadevan108