-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix for Crash dump formatting issues and adding more info to crash dump #6257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Crash dump formatting issues and adding more info to crash dump #6257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Based on the commit msg: A fix commit should contain info how it fixes it and why (might be obvious when they are split). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above
bf71386
to
72f45b8
Compare
@0xc0170 - I have split the commits into 2 commits - One to fix the formatting and other to add more info to crash dump. |
@kegilbert and @studavekar - Can you please re-review this PR? |
LGTM 👍 |
/morph build |
Build : SUCCESSBuild number : 1382 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1036 |
Test : SUCCESSBuild number : 1165 |
@0xc0170 Why did you not just merge it? |
Functionality came into 5.8 so fix should also do so |
As @adbridge mentioned, please take in this for 5.8 as its very much localized and should not impact any other area. |
This fixes some formatting issues in crash dump and also adds more info like return stack info, privilege level and mode to the crash dump.