Skip to content

Conversation

SenRamakri
Copy link
Contributor

This fixes some formatting issues in crash dump and also adds more info like return stack info, privilege level and mode to the crash dump.

kegilbert
kegilbert previously approved these changes Mar 5, 2018
Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2018

Based on the commit msg: Fix line feed issues and add mode info to crash dump - these should be separate commits ? One fixing , another adding mode info.

A fix commit should contain info how it fixes it and why (might be obvious when they are split).

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above

@SenRamakri
Copy link
Contributor Author

SenRamakri commented Mar 5, 2018

@0xc0170 - I have split the commits into 2 commits - One to fix the formatting and other to add more info to crash dump.

@SenRamakri
Copy link
Contributor Author

@kegilbert and @studavekar - Can you please re-review this PR?

@studavekar
Copy link
Contributor

LGTM 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

Build : SUCCESS

Build number : 1382
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6257/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2018

@theotherjimmy
Copy link
Contributor

@0xc0170 Why did you not just merge it?

@theotherjimmy theotherjimmy merged commit f67fe4a into ARMmbed:master Mar 8, 2018
@adbridge
Copy link
Contributor

Functionality came into 5.8 so fix should also do so

@SenRamakri
Copy link
Contributor Author

As @adbridge mentioned, please take in this for 5.8 as its very much localized and should not impact any other area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants