Fix issue in fault handler

[netanelgonen]

Description

Incase used \r or \n inside the prints of the fault handler
fault_print_str function would only \r.
The fix is adding \n if needed

Pull request type

• Fix

[geky]

Should this just be

if(fmtstr[i] == '\r') {
     serial_putc(&stdio_uart, '\r');
     serial_putc(&stdio_uart, '\n');

and let '\r' fall through to the else statement?

[netanelgonen]

@geky actually no, this will cause double newline in case of the user will print something like
"hello work double newline \r\n"

[netanelgonen]

and of course if use only \n you will not have any carriage return

[geky]

Oh hmm, won't this turn "\r\n" into "\r\n\r\n" in that case?

I mistyped, meant:

if(fmtstr[i] == '\n') {

In this case "\r\n" would turn into "\r\r\n", but I think the extra "\r" doesn't hurt anything?

[netanelgonen]

No, the current implementation will do '\r\r\n'

[geky]

oh I see, gotcha

That would be the same as this right? But with more conditionals?

if(fmtstr[i] == '\n') {
     serial_putc(&stdio_uart, '\r');
     serial_putc(&stdio_uart, '\n');

[netanelgonen]

not quite as you are discarding any \r char sent to print...
i think the outcome may be the same but in some edge cases it will cause a different issue

[geky]

Hmm, wouldn't the '\r' still go through the else statement and get printed out?

if(fmtstr[i] == '\n') {
     serial_putc(&stdio_uart, '\r');
     serial_putc(&stdio_uart, '\n');
} else {
     if(fmtstr[i]=='%') {
         hex_to_str(values[vidx++],hex_str);
         for(idx=7; idx>=0; idx--) {
             serial_putc(&stdio_uart, hex_str[idx]);
         }
     } else {
         serial_putc(&stdio_uart, fmtstr[i]);
     }
}

[geky]

I think we're bikeshedding, but this is good change.

Don't let my comments block the pr

[SenRamakri]

This is already taken care of in - #6257

[0xc0170]

This is already taken care of in - #6257

👍