-
Notifications
You must be signed in to change notification settings - Fork 3k
Add back examples updated for mbed-os-5.10 #8246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While feature changes were being added to mbed-os a number of examples were removed from this list due to incompatibility issues. This PR adds those examples back in: Filesystem, Blockdevice, Mesh-minimal, Bootloader. This PR also adds in the new NFC example.
@adbridge Two things:
|
@ARMmbed/mbed-os-maintainers ^^^ |
@cmonr In terms of 1. That is what is specified by the example owners so we shouldn't change that unless they say so. In terms of 2. I will ask Vincent to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the revert of the removal earlier - LGTM
As @cmonr stated, we should review this for 5.11. @OPpuolitaival If not yet in, we should review example testing
tools/test/examples/examples.json
Outdated
"name": "mbed-os-example-nfc", | ||
"github": "https://github.com/ARMmbed/mbed-os-example-nfc", | ||
"mbed": [ | ||
"https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-nfc-EEPROM/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That example is restricted to NUCLEO_F401RE
and the DISCO_L475VG_IOT01A
at the current minute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That example is restricted to NUCLEO_F401RE and the DISCO_L475VG_IOT01A at the current minute.
Not certain if this one commit just adds back what used to be there or adds something new. Should be clarified and fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 This PR is doing both. NFC is a new example that was introduced with 5.10.
tools/test/examples/examples.json
Outdated
], | ||
"test-repo-source": "mbed", | ||
"features" : [], | ||
"targets" : [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That really looks that it does not work for all devices as configured now
@pan- @donatieng Mind taking another look? I've restricted the NFC example to the two specified targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for NFC.
/morph build |
Build : FAILUREBuild number : 3169 |
Going to retry. Not sure why the examples failed to build. |
Build : FAILUREBuild number : 3171 |
The issue is subtle, but it looks like the build-prep step is failing to clone the nfc examples. |
This apparently breaks the examples.py script.
/morph build |
For reference, it appears that having the trailing slash was causing the following error:
However, the script continues without failing. |
Build : FAILUREBuild number : 3172 |
Looks like legit build failures
|
Pinging @ARMmbed/mbed-os-storage (and @geky) for the filesystem example. @ARMmbed/mbed-os-maintainers Who do we ping for mbed-os-example-tls-tls-client? |
Can you review the failures above @k-stachowiak @Patater
I suspect most of the storage team is OoO today, @geky can you help in case we do not receive a response here (I contacted them privately as well) |
@0xc0170 In mbed-os-example-tls we need this merged: ARMmbed/mbed-os-example-tls#198 It is pending minor changes from @SeppoTakalo. Please let me know if we may do something to support him. |
Fingers crossed this does the trick. Otherwise, I'm going to keep those two storage examples disabled and bring this in without them to get 5.10.1 generated tonight. /morph build (I say fingers crossed because even after changing targets, the build still failed locally, similar to this failure: #8246 (comment)) |
K64F": { Similar to this all storage components should be present in K82F else will get build failures |
Build : FAILUREBuild number : 3185 |
Well darn. Looks like the block device example still needs some work. Going to progress this without it for now. /morph build |
Build : SUCCESSBuild number : 3186 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2780 |
Test : SUCCESSBuild number : 2988 |
/morph export-build |
Exporter Build : FAILUREBuild number : 2781 |
This PR is not passing export due to failures finding printf on the following boards (failure occurs on all toolchains but only occurs on two boards ).
also CCing @cmonr in case this runs into your shift. |
Last thing blocking 5.10.1 release. Example will need to be fixed before it can be brought in.
/morph build |
Build : SUCCESSBuild number : 3187 Triggering tests/morph test |
Test : FAILUREBuild number : 2989 |
/morph test |
Exporter Build : SUCCESSBuild number : 2782 |
Test : SUCCESSBuild number : 2991 |
Suggested here: #8246 (comment)
Suggested here: #8246 (comment)
Suggested here: #8246 (comment)
Description
While feature changes were being added to mbed-os a number of
examples were removed from this list due to incompatibility issues.
This PR adds those examples back in:
Filesystem,
Blockdevice,
Mesh-minimal,
Bootloader.
This PR also adds in the new NFC example.
Pull request type