Add back examples updated for mbed-os-5.10 #8246

adbridge · 2018-09-25T14:29:36Z

Description

While feature changes were being added to mbed-os a number of
examples were removed from this list due to incompatibility issues.
This PR adds those examples back in:
Filesystem,
Blockdevice,
Mesh-minimal,
Bootloader.

This PR also adds in the new NFC example.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

While feature changes were being added to mbed-os a number of examples were removed from this list due to incompatibility issues. This PR adds those examples back in: Filesystem, Blockdevice, Mesh-minimal, Bootloader. This PR also adds in the new NFC example.

cmonr · 2018-09-25T14:53:38Z

@adbridge Two things:

A lot of the examples are only built against the K64F, leading to longer build times for just that target. Do we want to consider targeting something different so that the risk of having K64F builds timing out remains low?
If a target is not specified, the example is built against all available targets (in reference to this: https://github.com/ARMmbed/mbed-os/pull/8246/files#diff-93b92c61c9977ce2503bf0c37f41a92dR303). Is that what we want for the NFC example?

cmonr · 2018-09-25T14:53:55Z

@ARMmbed/mbed-os-maintainers ^^^

adbridge · 2018-09-25T14:58:07Z

@cmonr In terms of 1. That is what is specified by the example owners so we shouldn't change that unless they say so. In terms of 2. I will ask Vincent to review.
@pan- @donatieng Can you please comment on the compilation for the NFC example.

0xc0170

This is the revert of the removal earlier - LGTM

As @cmonr stated, we should review this for 5.11. @OPpuolitaival If not yet in, we should review example testing

pan- · 2018-09-26T08:17:33Z

tools/test/examples/examples.json

+        "name": "mbed-os-example-nfc",
+        "github": "https://github.com/ARMmbed/mbed-os-example-nfc",
+        "mbed": [
+            "https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-nfc-EEPROM/",


That example is restricted to NUCLEO_F401RE and the DISCO_L475VG_IOT01A at the current minute.

That example is restricted to NUCLEO_F401RE and the DISCO_L475VG_IOT01A at the current minute.

Not certain if this one commit just adds back what used to be there or adds something new. Should be clarified and fixed

@0xc0170 This PR is doing both. NFC is a new example that was introduced with 5.10.

OPpuolitaival · 2018-09-26T09:14:02Z

tools/test/examples/examples.json

+        ],
+        "test-repo-source": "mbed",
+        "features" : [],
+        "targets" : [],


That really looks that it does not work for all devices as configured now

cmonr · 2018-09-26T15:19:46Z

@pan- @donatieng Mind taking another look? I've restricted the NFC example to the two specified targets.

pan-

Approved for NFC.

cmonr · 2018-09-26T16:27:05Z

/morph build

mbed-ci · 2018-09-26T17:26:46Z

Build : FAILURE

Build number : 3169
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

cmonr · 2018-09-26T18:02:54Z

Going to retry. Not sure why the examples failed to build.
/morph build

mbed-ci · 2018-09-26T18:54:54Z

Build : FAILURE

Build number : 3171
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

cmonr · 2018-09-26T18:58:35Z

The issue is subtle, but it looks like the build-prep step is failing to clone the nfc examples.

This apparently breaks the examples.py script.

cmonr · 2018-09-26T19:07:56Z

/morph build

cmonr · 2018-09-26T19:10:34Z

For reference, it appears that having the trailing slash was causing the following error:

18:08:57 '' example directory doesn't exist. Skipping...
18:08:57 '' example directory doesn't exist. Skipping...

However, the script continues without failing.

mbed-ci · 2018-09-26T20:02:20Z

Build : FAILURE

Build number : 3172
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

studavekar · 2018-09-26T20:12:25Z

Build : FAILURE

Build number : 3172
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

Looks like legit build failures

atmel-rf' is not unique

ConfigException: Library name 'atmel-rf' is not unique (defined in '/builds/ws/mbed-os-build-matrix/3172/K64F_GCC_ARM/sources/examples/mbed-os-example-tls-tls-client/easy-connect/atmel-rf-driver/mbed_lib.json' and '/builds/ws/mbed-os-build-matrix/3172/K64F_GCC_ARM/sources/examples/mbed-os-example-tls-tls-client/mbed-os/components/802.15.4_RF/atmel-rf-driver/mbed_lib.json')

Output: ./main.cpp:41:1: error: 'SPIFBlockDevice' does not name a type

[DEBUG] Output: ./main.cpp:41:1: error: 'SPIFBlockDevice' does not name a type
[DEBUG] Output:  SPIFBlockDevice bd(
[DEBUG] Output:  ^~~~~~~~~~~~~~~
[DEBUG] Output: ./main.cpp: In function 'void erase()':
[DEBUG] Output: ./main.cpp:56:15: error: 'bd' was not declared in this scope
[DEBUG] Output:      int err = bd.init();
[DEBUG] Output:                ^~
[DEBUG] Output: ./main.cpp: In function 'int main()':
[DEBUG] Output: ./main.cpp:91:25: error: 'bd' was not declared in this scope
[DEBUG] Output:      int err = fs.mount(&bd);
[DEBUG] Output:                          ^~

cmonr · 2018-09-27T00:32:23Z

Pinging @ARMmbed/mbed-os-storage (and @geky) for the filesystem example.

@ARMmbed/mbed-os-maintainers Who do we ping for mbed-os-example-tls-tls-client?

0xc0170 · 2018-09-27T07:42:36Z

@ARMmbed/mbed-os-maintainers Who do we ping for mbed-os-example-tls-tls-client?

Can you review the failures above @k-stachowiak @Patater

Pinging @ARMmbed/mbed-os-storage (and @geky) for the filesystem example.

I suspect most of the storage team is OoO today, @geky can you help in case we do not receive a response here (I contacted them privately as well)

k-stachowiak · 2018-09-27T07:54:28Z

@0xc0170 In mbed-os-example-tls we need this merged: ARMmbed/mbed-os-example-tls#198 It is pending minor changes from @SeppoTakalo. Please let me know if we may do something to support him.

cmonr · 2018-09-27T23:09:01Z

Fingers crossed this does the trick. Otherwise, I'm going to keep those two storage examples disabled and bring this in without them to get 5.10.1 generated tonight.

/morph build

(I say fingers crossed because even after changing targets, the build still failed locally, similar to this failure: #8246 (comment))

deepikabhavnani · 2018-09-27T23:28:09Z

K64F": {
"supported_form_factors": ["ARDUINO"],
"components": ["SD"],

Similar to this all storage components should be present in K82F else will get build failures

mbed-ci · 2018-09-28T00:03:47Z

Build : FAILURE

Build number : 3185
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

cmonr · 2018-09-28T04:39:43Z

Well darn. Looks like the block device example still needs some work.

Going to progress this without it for now.

/morph build

mbed-ci · 2018-09-28T05:35:25Z

Build : SUCCESS

Build number : 3186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-28T07:45:29Z

Exporter Build : FAILURE

Build number : 2780
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8246/

mbed-ci · 2018-09-28T08:42:03Z

Test : SUCCESS

Build number : 2988
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8246/2988

NirSonnenschein · 2018-09-28T10:24:48Z

/morph export-build

mbed-ci · 2018-09-28T12:33:10Z

Exporter Build : FAILURE

Build number : 2781
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8246/

NirSonnenschein · 2018-09-28T12:53:15Z

This PR is not passing export due to failures finding printf on the following boards (failure occurs on all toolchains but only occurs on two boards ).

mbed-os-example-nfc-EEPROM DISCO_L475VG_IOT01A on DISCO_L475VG_IOT01A
mbed-os-example-nfc-EEPROM NUCLEO_F401RE on NUCLEO_F401RE
@donatieng and @pan- @adbridge has asked that you please take a look. Note: this is the LAST remaining PR for 5.10.1 which is supposed to be built later today.

also CCing @cmonr in case this runs into your shift.

Last thing blocking 5.10.1 release. Example will need to be fixed before it can be brought in.

cmonr · 2018-09-28T16:03:10Z

/morph build

mbed-ci · 2018-09-28T17:08:38Z

Build : SUCCESS

Build number : 3187
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8246/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-28T19:13:10Z

Test : FAILURE

Build number : 2989
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8246/2989

cmonr · 2018-09-28T19:16:08Z

/morph test

mbed-ci · 2018-09-28T19:18:20Z

Exporter Build : SUCCESS

Build number : 2782
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8246/

mbed-ci · 2018-09-28T23:18:23Z

Test : SUCCESS

Build number : 2991
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8246/2991

Suggested here: #8246 (comment)

adbridge added needs: review release-version: 5.10.1 labels Sep 25, 2018

0xc0170 approved these changes Sep 26, 2018

View reviewed changes

pan- requested changes Sep 26, 2018

View reviewed changes

OPpuolitaival suggested changes Sep 26, 2018

View reviewed changes

Restricted nfc example to two targets

2c870e7

pan- approved these changes Sep 26, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Sep 26, 2018

Removed trailing slashes in NFC examples URL

d522880

This apparently breaks the examples.py script.

cmonr mentioned this pull request Sep 26, 2018

Enabled the removal of a trailing slash #8261

Merged

cmonr added needs: work and removed needs: CI labels Sep 27, 2018

cmonr added needs: CI and removed needs: work labels Sep 27, 2018

Remove block device example in the short term

e3343a6

Removed mbed-os-example-nfc-EEPROM from examples.json

786f10b

Last thing blocking 5.10.1 release. Example will need to be fixed before it can be brought in.

cmonr merged commit 255f28e into ARMmbed:master Sep 28, 2018

cmonr removed the needs: CI label Sep 28, 2018

0xc0170 pushed a commit that referenced this pull request Oct 1, 2018

Replace storage example targets from K64F to K82F

09e6395

Suggested here: #8246 (comment)

yossi2le mentioned this pull request Oct 4, 2018

Add blockdevice example back to CI #8323

Merged

adbridge pushed a commit that referenced this pull request Oct 8, 2018

Replace storage example targets from K64F to K82F

f06880a

Suggested here: #8246 (comment)

adbridge pushed a commit that referenced this pull request Oct 8, 2018

Replace storage example targets from K64F to K82F

16b1063

Suggested here: #8246 (comment)

cmonr mentioned this pull request Nov 22, 2018

Moving some examples testing from K64F to K66F #8835

Merged

Add back examples updated for mbed-os-5.10 #8246

Add back examples updated for mbed-os-5.10 #8246

Uh oh!

Conversation

adbridge commented Sep 25, 2018

Description

Pull request type

Uh oh!

cmonr commented Sep 25, 2018

Uh oh!

cmonr commented Sep 25, 2018

Uh oh!

adbridge commented Sep 25, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

pan- Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Sep 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

pan- left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

mbed-ci commented Sep 26, 2018

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

mbed-ci commented Sep 26, 2018

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

cmonr commented Sep 26, 2018

Uh oh!

mbed-ci commented Sep 26, 2018

Uh oh!

studavekar commented Sep 26, 2018

Uh oh!

cmonr commented Sep 27, 2018

Uh oh!

0xc0170 commented Sep 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k-stachowiak commented Sep 27, 2018

Uh oh!

cmonr commented Sep 27, 2018

Uh oh!

deepikabhavnani commented Sep 27, 2018

Uh oh!

mbed-ci commented Sep 28, 2018

Uh oh!

cmonr commented Sep 28, 2018

Uh oh!

mbed-ci commented Sep 28, 2018

Triggering tests

Uh oh!

mbed-ci commented Sep 28, 2018

Uh oh!

mbed-ci commented Sep 28, 2018

Uh oh!

NirSonnenschein commented Sep 28, 2018

Uh oh!

mbed-ci commented Sep 28, 2018

Uh oh!

NirSonnenschein commented Sep 28, 2018

Uh oh!

pan- Sep 26, 2018 •

edited

Loading

0xc0170 Sep 26, 2018 •

edited

Loading

0xc0170 commented Sep 27, 2018 •

edited

Loading