-
Notifications
You must be signed in to change notification settings - Fork 3k
Enabled the removal of a trailing slash #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failure looks like is at https://github.com/ARMmbed/mbed-os/blob/master/tools/test/examples/examples_lib.py#L355
yeah but root cause maybe its not able to deploy |
Hmmm, will take another look at this tomorrow. There might have been two bugs: 1) URLs with a trailing slash would be skipped, and 2) if the name was empty, it fails to change directories when deploying. |
@ARMmbed/mbed-os-tools Please review (or update the PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, though I admit I don't have the full background of this change.
@studavekar Happy with the fix or not? |
I restarted Travis, but might again not to report back status 😫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change fixes the problem, may be can make similar changes as other places in code where it's used.
/morph build |
Build : SUCCESSBuild number : 3311 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2945 |
Test : SUCCESSBuild number : 3118 |
Description
Discovered when debugging #8246. Using
basename
with a URL that has a trailing slash leads to an empty string.Pull request type