Skip to content

Enabled the removal of a trailing slash #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Sep 26, 2018

Description

Discovered when debugging #8246. Using basename with a URL that has a trailing slash leads to an empty string.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from bridadan, studavekar and a team September 26, 2018 19:23
@studavekar
Copy link
Contributor

studavekar commented Sep 26, 2018

Failure looks like is at https://github.com/ARMmbed/mbed-os/blob/master/tools/test/examples/examples_lib.py#L355

File "/builds/ws/mbed-os-build-matrix/3171/DELTA_DFBM_NQ620_IAR/sources/mbed-os/tools/test/examples/examples_lib.py", line 355, in compile_repos

yeah but root cause maybe its not able to deploy

@cmonr
Copy link
Contributor Author

cmonr commented Sep 27, 2018

Hmmm, will take another look at this tomorrow. There might have been two bugs: 1) URLs with a trailing slash would be skipped, and 2) if the name was empty, it fails to change directories when deploying.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

@ARMmbed/mbed-os-tools Please review (or update the PR)

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, though I admit I don't have the full background of this change.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

@studavekar Happy with the fix or not?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

I restarted Travis, but might again not to report back status 😫

Copy link
Contributor

@studavekar studavekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change fixes the problem, may be can make similar changes as other places in code where it's used.

@cmonr
Copy link
Contributor Author

cmonr commented Oct 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Build : SUCCESS

Build number : 3311
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8261/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

@cmonr cmonr merged commit 161ca2b into ARMmbed:master Oct 10, 2018
@cmonr cmonr removed the needs: CI label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants