Skip to content

Remove IAR supported from targets failing IAR 8.32 build #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

Remove IAR supported from targets failing IAR 8.32 build #9524

merged 1 commit into from
Feb 6, 2019

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Jan 28, 2019 •
edited
Loading

Description

Few targets have libraries compatible to IAR 7.x, which fail with IAR 8.x, IAR support for them is removed till updated library is added.

List of targets affected:

  1. UBLOX_EVK_ODIN_W2
  2. MTB_UBLOX_ODIN_W2
  3. MBED_CONNECT_ODIN
  4. MTB_MXCHIP_EMW3166
  5. MTB_ADV_WISE_1530
  6. MTB_USI_WM_BN_BM_22
  7. REALTEK_RTL8195AM

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepikabhavnani deepikabhavnani mentioned this pull request Jan 28, 2019
Closed
21 tasks
cmonr
cmonr approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

CI started

@deepikabhavnani
Copy link
Author

Failure in CI as all three toolchains needed


folowing toolchains to be included in the mbed OS 5.0 official release: ARM, GCC_ARM, IAR
Currently it is only configured to support the following toolchains: ARM, GCC_ARM, uARM

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

CI restarted.

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@deepikabhavnani
Copy link
Author

Feature branch has linker file updates as well which is not compatible to IAR 7.x, hence the failure.
CI will be green only when IAR 8.x is used to test all PR;s for feature-iar8 branch

CC @timurh01

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

CI restarted since Jenkins Node has been updated

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019 •
edited
Loading

Ready for retest.

My bad. Stale GitHub page caching. Test run #3 still pending.

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_exporter

@deepikabhavnani
Copy link
Author

@timurh01 @0xc0170 - Exporters should also be configured to use IAR 8.x version

==========STDOUT==========

 IAR Command Line Build Utility V7.5.6.4719
 Copyright 2002-2017 IAR Systems AB.

Building configuration: mbed-os-example-blinky - mbed-os-example-blinky

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

...huh. Shouldn't the jenkins-ci/build-IAR either 1) have passed, or 2) failed and been in the comment list?

@vmedcy vmedcy mentioned this pull request Jan 31, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 1, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR8

@alekla01
Copy link
Contributor

alekla01 commented Feb 1, 2019

Restarted CI

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Feb 2, 2019

Restarting CI
Checking to see what else is needed, if anything

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2019

Test run: FAILED

Summary: 2 of 6 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test

Remove IAR supported from targets failing IAR 8.32 build
f28b6e1 
Few targets have libraries compatible to IAR 7.x, which fail with
IAR 8.x, IAR support for them is removed till updated library is
added.

CI failure seen if IAR is not added as supported target, trying with
release_version as empty string

List of targets affected:

1. UBLOX_EVK_ODIN_W2
2. MTB_UBLOX_ODIN_W2
3. MBED_CONNECT_ODIN
4. MTB_MXCHIP_EMW3166
5. MTB_ADV_WISE_1530
6. MTB_USI_WM_BN_BM_22
7. REALTEK_RTL8195AM
@deepikabhavnani
Copy link
Author

CI started after removing Realtek from IAR8 list

@deepikabhavnani
Copy link
Author

@0xc0170 - I don't see any fail artifacts

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2019

Test run: FAILED

Summary: 2 of 6 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter

@alekla01
Copy link
Contributor

alekla01 commented Feb 5, 2019 •
edited
Loading

restarted exporter (& greentea with Realtek skipped).

@deepikabhavnani
Copy link
Author

All pass... Hurray

@ARMmbed/mbed-os-maintainers - Ready to merge?

@NirSonnenschein NirSonnenschein merged commit 1809d93 into ARMmbed:feature-iar8 Feb 6, 2019
@deepikabhavnani deepikabhavnani deleted the disable_failing branch February 6, 2019 13:57
@deepikabhavnani deepikabhavnani mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepikabhavnani @cmonr @mbed-ci @alekla01 @0xc0170 @NirSonnenschein