Skip to content

Disable psco6 iar8 till libraries are available #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

Disable psco6 iar8 till libraries are available #9697

merged 1 commit into from
Feb 13, 2019

Conversation

deepikabhavnani
Copy link

Description

Target_PSOC6 - Remove IAR supported from targets failing IAR 8.32 build

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 13, 2019
Merged
@ciarmcom ciarmcom requested a review from a team February 13, 2019 04:00
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if omiting IAR and emptying the release versions list will work in CI

@deepikabhavnani
Copy link
Author

It has worked earlier #9524

@deepikabhavnani
Copy link
Author

Can we start CI on this?

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

Can we start CI on this?

Dang it! Meant to do that when I Ok'd the PR...

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 8d3946f into ARMmbed:feature-iar8 Feb 13, 2019
@cmonr cmonr removed the needs: CI label Feb 13, 2019
@deepikabhavnani deepikabhavnani deleted the disable_psco6_iar branch February 13, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepikabhavnani @ciarmcom @cmonr @mbed-ci