Add define to skip greentea sync

[orenc17]

Description

Add a define to allow debuging greentea tests that do not require input from host without host-tests

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

Release Notes

[ciarmcom]

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[cmonr]

Hmm. @orenc17 Would you mind sharing how you'd expect this to be used?

Does this new macro also need a Docs PR and Release Notes blurb?

[orenc17]

Hmm. @orenc17 Would you mind sharing how you'd expect this to be used?

Does this new macro also need a Docs PR and Release Notes blurb?

@cmonr let's call it an easter egg

[0xc0170]

I also do not understand this change. What use case is there and why greentea would include "no greentea" macro?

[0xc0170]

@ARMmbed/mbed-os-core Can you review, please

[NirSonnenschein]

This is the general idea: tests are usually run using greentea and this is very convenient , except when debugging them. if a test is complied for greentea it will wait for a green tea command before starting making debugging it a pain. for these scenarios it is useful to build the same test using exactly the same config but leave out the greentea setup call, which will yield a very similar binary, but one that doesn't wait on startup and is easy to debug.

[cmonr]

Hmm, considering that the use of this macro isn't new (https://github.com/ARMmbed/mbed-os/search?q=NO_GREENTEA&unscoped_q=NO_GREENTEA), I think it's fine to bring in.

It's also curious that the ARM_MUSCA_A1 PR is also using it: https://github.com/ARMmbed/mbed-os/pull/9221/files#diff-088d539546fc854c07455c735a069539R441

https://github.com/ARMmbed/mbed-os-5-docs/search?q=NO_GREENTEA&unscoped_q=NO_GREENTEA

Considering that this is already in use in the repo, this needs docs (CC @AnotherButler)

[orenc17]

@cmonr good catch

[cmonr]

CI started whilst wainting on final reviews

[mbed-ci]

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-ARM

[cmonr]

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

[0xc0170]

Hmm, considering that the use of this macro isn't new (https://github.com/ARMmbed/mbed-os/search?q=NO_GREENTEA&unscoped_q=NO_GREENTEA), I think it's fine to bring in.

Only some small subset, used in psa/spm files . Anyway, looks fine to me and also used something similar previously.

One last question before restarting CI: why not added as config as well with some help text. We got already config file there - if this macro is not documented (I would assume this would go only in the sources, not known to anyone).

[0xc0170]

    "config": {
        "skip_host_sync": {
            "help": "No greentea host involved, helps debugging tests with no host interaction",
            "value": 0
        },

Not sure if we shall rename but this is what I understood from this PR and how it was used (thus used skip in the name).
@orenc17 Please review

[orenc17]

@0xc0170 the idea of putting this define in an mbed_lib.json crossed my mind, but the thing is for a user to actually change this, the user will need to compile his test with an mbed_app.json
and from previous discussions this idea is frowned upon A LOT...

so i would like to stick with the very simple and stupid -DNO_GREENTEA

[0xc0170]

Valid point. Will need to be documented (otherwise this is hidden feature :) )

@ARMmbed/mbed-os-core please review

[alekla01]

old build-ARM hook set green, so does not potentially cause issues when/if rebuilding without commits in between.

[deepikabhavnani]

Thanks for this addition 👍

[cmonr]

CI restarted.

Afaik, restarting a single build job won't propigate successfully, so restarting from scratch

[mbed-ci]

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts