-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove #ifndef NO_GREENTEA from tests #9914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@orenc17, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ARMmbed/mbed-os-maintainers review is done, can we get this merged? |
Hey @orenc17, I got a question here, if wen have |
@jamesbeyond This PR REMOVES all the excess defines from the tests |
Sorry, I was mistaken this PR as adding them. one thing to mention, maybe that Macro should be called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sure, but at the moment, this is marked for 5.12.1. Until RC1 is generated, and the 5.12 branch made, we can't merge 5.12.1 PRs. This could come into 5.12.1, but that would require an ACK from @ChiefBureaucraticOfficer |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
@orenc17 quick question - is this still up to date (been few days on hold due to 5.12rcs). If yes, can go in |
I'll rebase and verify |
@0xc0170 rebased and removed another usage of ready for CI |
No more changes are expected there. This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately. |
Description
Remove #ifndef NO_GREENTEA from PSA tests as #9835 was merged
wait for #9823
Pull request type
Reviewers
@ARMmbed/mbed-os-psa @ARMmbed/mbed-os-maintainers
Release Notes