Skip to content

Skip test on Cortex M33 devices #9916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Skip test on Cortex M33 devices #9916

merged 1 commit into from
Mar 4, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 3, 2019

Description

On platforms using coretx m33 accessing the secure memory will cause SecureFault instead of Hardfault.
SecureFault is implemented in the secure image and cannot be changed in runtime.
For those reasons we need to skip the test for M33 boards

This PR is required for #9908 & #9910

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa @ARMmbed/mbed-os-maintainers

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Mar 3, 2019

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

On platforms using coretx m33 accessing the secure memory will cause SecureFault instead of Hardfault.
SecureFault is implemented in the secure image and cannot be changed in runtime.
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 3, 2019

I updated the commit msg, starting CI now

@0xc0170 0xc0170 requested a review from a user March 3, 2019 18:44
@0xc0170 0xc0170 mentioned this pull request Mar 3, 2019
@mbed-ci
Copy link

mbed-ci commented Mar 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

@0xc0170 , CI has passed

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

Is this fine in 5.12.1 - @orenc17 ?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

Need to be in 5.12, confirmed by PSA team.

@0xc0170 0xc0170 removed the request for review from a team March 4, 2019 09:51
@0xc0170 0xc0170 merged commit 9f6156a into ARMmbed:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants