Skip to content

Conversation

Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Apr 21, 2023

Issue describing the changes in this PR

Resolves #944

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino Francisco-Gamino force-pushed the Francisco-Gamino/update-MDs-legion branch from 05e3b8a to 178fe04 Compare April 22, 2023 04:40
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit dd662bc into dev Apr 24, 2023
@AnatoliB
Copy link
Contributor

@Francisco-Gamino I think this needs to be backported to 7.2

Francisco-Gamino added a commit that referenced this pull request Apr 26, 2023
* Error out if the user tries to install modules via Managed Dependencies on Legion

* Moved logic to help figure out if we are running in Azure to a helper class

* Add test case to validate that we do not throw on Legion when requirements.psd1 has no entries

* Add Managed Dependencies is not supported on Legion test case
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/update-MDs-legion branch April 26, 2023 03:22
Francisco-Gamino added a commit that referenced this pull request Apr 28, 2023
* Error out if the user tries to install modules via Managed Dependencies on Legion

* Moved logic to help figure out if we are running in Azure to a helper class

* Add test case to validate that we do not throw on Legion when requirements.psd1 has no entries

* Add Managed Dependencies is not supported on Legion test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed Dependencies is not supported on Legion
2 participants