-
Notifications
You must be signed in to change notification settings - Fork 54
Managed Dependencies is not supported on Legion #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatoliB
reviewed
Apr 21, 2023
AnatoliB
reviewed
Apr 21, 2023
…pendencyManagement
05e3b8a
to
178fe04
Compare
AnatoliB
reviewed
Apr 22, 2023
AnatoliB
reviewed
Apr 22, 2023
AnatoliB
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Francisco-Gamino I think this needs to be backported to 7.2 |
Francisco-Gamino
added a commit
that referenced
this pull request
Apr 26, 2023
* Error out if the user tries to install modules via Managed Dependencies on Legion * Moved logic to help figure out if we are running in Azure to a helper class * Add test case to validate that we do not throw on Legion when requirements.psd1 has no entries * Add Managed Dependencies is not supported on Legion test case
7 tasks
Francisco-Gamino
added a commit
that referenced
this pull request
Apr 28, 2023
* Error out if the user tries to install modules via Managed Dependencies on Legion * Moved logic to help figure out if we are running in Azure to a helper class * Add test case to validate that we do not throw on Legion when requirements.psd1 has no entries * Add Managed Dependencies is not supported on Legion test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #944
Pull request checklist
release_notes.md
Additional information
Additional PR information