-
Notifications
You must be signed in to change notification settings - Fork 54
Managed Dependencies is not supported on Legion #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2392ebe
Error out when a user tries to use Managed Dependencies on Legion
Francisco-Gamino 0ecfa68
Add Managed Dependencies is not supported on Legion test case
Francisco-Gamino 7a6af18
Update error message
Francisco-Gamino 9c6ca8b
Moved logic to help figure out if we are running in Azure to a helper…
Francisco-Gamino a1635af
Error out if we are running on Legion when initializing the Dependenc…
Francisco-Gamino 178fe04
Moved Managed Dependencies is not supported on Legion test case to De…
Francisco-Gamino 933f1c5
Update DependencyManager initialization logic
Francisco-Gamino 96cd46f
Add test case to validate that we do not throw on Legion when require…
Francisco-Gamino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Text; | ||
using System.Threading.Tasks; | ||
|
||
namespace Microsoft.Azure.Functions.PowerShellWorker.DependencyManagement | ||
{ | ||
/// <summary> | ||
/// Hold information about the environment. | ||
/// </summary> | ||
internal static class WorkerEnvironment | ||
{ | ||
// Environment variables to help figure out if we are running in Azure. | ||
private const string AzureWebsiteInstanceId = "WEBSITE_INSTANCE_ID"; | ||
private const string ContainerName = "CONTAINER_NAME"; | ||
private const string LegionServiceHost = "LEGION_SERVICE_HOST"; | ||
|
||
public static bool IsAppService() | ||
{ | ||
return !string.IsNullOrEmpty(Environment.GetEnvironmentVariable(AzureWebsiteInstanceId)); | ||
} | ||
|
||
public static bool IsLinuxConsumption() | ||
{ | ||
return !IsAppService() && !string.IsNullOrEmpty(Environment.GetEnvironmentVariable(ContainerName)); | ||
} | ||
|
||
public static bool IsLinuxConsumptionOnLegion() | ||
{ | ||
return !IsAppService() && | ||
!string.IsNullOrEmpty(Environment.GetEnvironmentVariable(ContainerName)) && | ||
!string.IsNullOrEmpty(Environment.GetEnvironmentVariable(LegionServiceHost)); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.