Resolve SSRF in HealhCheck #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2025 14:15
sezal98
requested review from
Aniruddh25,
RubenCerna2079,
aaronburtle,
neeraj-sharma2592,
ravishetye and
sourabh1007
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR resolves a potential SSRF vulnerability in the HealthCheck service by validating outbound URIs before creating an HttpClient.
- Added inbound checks in ConfigureApiRoute to validate the URI using a new helper function.
- Introduced the IsValidOutboundUri method to ensure the URI is absolute, employs HTTP/HTTPS schemes, and has a non-empty hostname.
Comments suppressed due to low confidence (1)
src/Service/HealthCheck/HttpUtilities.cs:105
- [nitpick] Consider extracting the error message 'Blocked outbound request due to invalid or unsafe URI.' into a reusable constant to avoid duplication and ensure consistency.
LogTrace("Blocked outbound request due to invalid or unsafe URI.");
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Apr 23, 2025
Aniruddh25
reviewed
Apr 23, 2025
added 3 commits
April 28, 2025 17:29
… dev/sezalchug/ssrfUtilities
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Apr 28, 2025
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
Apr 29, 2025
RubenCerna2079
pushed a commit
that referenced
this pull request
May 16, 2025
## Why make this change? Internal Issue Resolved ## What is this change? Created a check before creating the HttpClient where the URI would be validated Conditions 1. It ensures the URI is absolute. 2. It checks for valid HTTP/HTTPS schemes. 3. Disallow empty hostnames Working as expected Code QL resolution would be checked after merging and running the pipelines --------- Co-authored-by: sezalchug <[email protected]> Co-authored-by: aaronburtle <[email protected]>
2 tasks
RubenCerna2079
pushed a commit
that referenced
this pull request
May 29, 2025
## Why make this change? Internal Issue Resolved ## What is this change? Created a check before creating the HttpClient where the URI would be validated Conditions 1. It ensures the URI is absolute. 2. It checks for valid HTTP/HTTPS schemes. 3. Disallow empty hostnames Working as expected Code QL resolution would be checked after merging and running the pipelines --------- Co-authored-by: sezalchug <[email protected]> Co-authored-by: aaronburtle <[email protected]>
aaronburtle
added a commit
that referenced
this pull request
May 29, 2025
## Why make this change? This change is made in order to add all of the commits for milestone 1.5 into its respective branch. ## What is this change? This change cherry-picks all of the commits that were added after the first release candidate. Cherry-picked commits: - #2648 #2657 #2617 #2659 #2655 #2633 #2667 #2673 #2650 #2695 #2702 #2688 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) --------- Co-authored-by: Sezal Chug <[email protected]> Co-authored-by: sezalchug <[email protected]> Co-authored-by: Tommaso Stocchi <[email protected]> Co-authored-by: Aaron Powell <[email protected]> Co-authored-by: aaronburtle <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]> Co-authored-by: Jerry Nixon <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Michael Staib <[email protected]> Co-authored-by: souvikghosh04 <[email protected]> Co-authored-by: Souvik Ghosh <[email protected]>
RubenCerna2079
pushed a commit
that referenced
this pull request
May 29, 2025
Internal Issue Resolved Created a check before creating the HttpClient where the URI would be validated Conditions 1. It ensures the URI is absolute. 2. It checks for valid HTTP/HTTPS schemes. 3. Disallow empty hostnames Working as expected Code QL resolution would be checked after merging and running the pipelines --------- Co-authored-by: sezalchug <[email protected]> Co-authored-by: aaronburtle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Internal Issue Resolved
What is this change?
Created a check before creating the HttpClient where the URI would be validated
Conditions
Working as expected
Code QL resolution would be checked after merging and running the pipelines