-
Notifications
You must be signed in to change notification settings - Fork 281
Upgrade Microsoft.Data.SqlClient to New Version #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Microsoft.Data.SqlClient package version to address bug #2690 by bumping it from 5.2.0 to 5.2.3.
- Bump Microsoft.Data.SqlClient version in central package props.
Comments suppressed due to low confidence (1)
src/Directory.Packages.props:36
- The note above this line indicates that the license URL in
scripts/notice-generation.ps1
should be updated when bumping Microsoft.Data.SqlClient. Please ensure that script is updated to reference the new 5.2.3 version.
<PackageVersion Include="Microsoft.Data.SqlClient" Version="5.2.3" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs fix to notice-generation
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the quick fix!
## Why make this change? This change solves the bug #2690 ## What is this change? We update the `Microsoft.Data.SqlClient` package from version 5.2.0 to version 5.2.3 in the `Directory.Packages.props` file. As the bug is a known error from the current version we are using. ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) --------- Co-authored-by: Ruben Cerna <[email protected]>
## Why make this change? This change solves the bug #2690 ## What is this change? We update the `Microsoft.Data.SqlClient` package from version 5.2.0 to version 5.2.3 in the `Directory.Packages.props` file. As the bug is a known error from the current version we are using. ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) --------- Co-authored-by: Ruben Cerna <[email protected]>
## Why make this change? This change is made in order to add all of the commits for milestone 1.5 into its respective branch. ## What is this change? This change cherry-picks all of the commits that were added after the first release candidate. Cherry-picked commits: - #2648 #2657 #2617 #2659 #2655 #2633 #2667 #2673 #2650 #2695 #2702 #2688 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s) --------- Co-authored-by: Sezal Chug <[email protected]> Co-authored-by: sezalchug <[email protected]> Co-authored-by: Tommaso Stocchi <[email protected]> Co-authored-by: Aaron Powell <[email protected]> Co-authored-by: aaronburtle <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]> Co-authored-by: Jerry Nixon <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Michael Staib <[email protected]> Co-authored-by: souvikghosh04 <[email protected]> Co-authored-by: Souvik Ghosh <[email protected]>
## Why make this change? Need to update license agreement to old version in script. SqlClient.SNI does not have a new version the same way the SqlClient package does with 5.2.3. ## What is this change? This changes the name of the license agreement from 5.2.3 to 5.2.0. Related to PR #2702 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s)
## Why make this change? Need to update license agreement to old version in script. SqlClient.SNI does not have a new version the same way the SqlClient package does with 5.2.3. ## What is this change? This changes the name of the license agreement from 5.2.3 to 5.2.0. Related to PR #2702 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s)
…2.3 to 5.2.0 (#2706) ## Why make this change? Need to update license agreement to old version in script. SqlClient.SNI does not have a new version the same way the SqlClient package does with 5.2.3. ## What is this change? This changes the name of the license agreement from 5.2.3 to 5.2.0. Related to PR #2702 Cherry-picked PR: - #2705 ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests ## Sample Request(s)
Why make this change?
This change solves the bug #2690
What is this change?
We update the
Microsoft.Data.SqlClient
package from version 5.2.0 to version 5.2.3 in theDirectory.Packages.props
file. As the bug is a known error from the current version we are usingHow was this tested?
Sample Request(s)