Skip to content

Conversation

RubenCerna2079
Copy link
Contributor

Why make this change?

This change solves the bug #2690

What is this change?

We update the Microsoft.Data.SqlClient package from version 5.2.0 to version 5.2.3 in the Directory.Packages.props file. As the bug is a known error from the current version we are using

How was this tested?

  • Integration Tests
  • Unit Tests

Sample Request(s)

@RubenCerna2079
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft.Data.SqlClient package version to address bug #2690 by bumping it from 5.2.0 to 5.2.3.

  • Bump Microsoft.Data.SqlClient version in central package props.
Comments suppressed due to low confidence (1)

src/Directory.Packages.props:36

  • The note above this line indicates that the license URL in scripts/notice-generation.ps1 should be updated when bumping Microsoft.Data.SqlClient. Please ensure that script is updated to reference the new 5.2.3 version.
<PackageVersion Include="Microsoft.Data.SqlClient" Version="5.2.3" />

@RubenCerna2079 RubenCerna2079 linked an issue May 28, 2025 that may be closed by this pull request
1 task
@RubenCerna2079 RubenCerna2079 moved this from Todo to Review In Progress in Data API builder May 28, 2025
Copy link
Contributor

@aaronburtle aaronburtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix to notice-generation

@RubenCerna2079
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the quick fix!

@RubenCerna2079 RubenCerna2079 merged commit a5f4f8e into main May 29, 2025
11 checks passed
@RubenCerna2079 RubenCerna2079 deleted the dev/rubencerna/update_package_version branch May 29, 2025 01:55
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Data API builder May 29, 2025
RubenCerna2079 added a commit that referenced this pull request May 29, 2025
## Why make this change?

This change solves the bug #2690

## What is this change?

We update the `Microsoft.Data.SqlClient` package from version 5.2.0 to
version 5.2.3 in the `Directory.Packages.props` file. As the bug is a
known error from the current version we are using.

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)

---------

Co-authored-by: Ruben Cerna <[email protected]>
RubenCerna2079 added a commit that referenced this pull request May 29, 2025
## Why make this change?

This change solves the bug #2690

## What is this change?

We update the `Microsoft.Data.SqlClient` package from version 5.2.0 to
version 5.2.3 in the `Directory.Packages.props` file. As the bug is a
known error from the current version we are using.

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)

---------

Co-authored-by: Ruben Cerna <[email protected]>
aaronburtle added a commit that referenced this pull request May 29, 2025
## Why make this change?

This change is made in order to add all of the commits for milestone 1.5
into its respective branch.

## What is this change?

This change cherry-picks all of the commits that were added after the
first release candidate.
Cherry-picked commits:
 - #2648 
#2657
#2617 
#2659 
#2655 
#2633 
#2667 
#2673 
#2650 
#2695 
#2702 
#2688

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)

---------

Co-authored-by: Sezal Chug <[email protected]>
Co-authored-by: sezalchug <[email protected]>
Co-authored-by: Tommaso Stocchi <[email protected]>
Co-authored-by: Aaron Powell <[email protected]>
Co-authored-by: aaronburtle <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Jerry Nixon <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Michael Staib <[email protected]>
Co-authored-by: souvikghosh04 <[email protected]>
Co-authored-by: Souvik Ghosh <[email protected]>
RubenCerna2079 added a commit that referenced this pull request May 30, 2025
## Why make this change?

Need to update license agreement to old version in script. SqlClient.SNI
does not have a new version the same way the SqlClient package does with
5.2.3.

## What is this change?

This changes the name of the license agreement from 5.2.3 to 5.2.0.
Related to PR #2702

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)
RubenCerna2079 added a commit that referenced this pull request May 30, 2025
## Why make this change?

Need to update license agreement to old version in script. SqlClient.SNI
does not have a new version the same way the SqlClient package does with
5.2.3.

## What is this change?

This changes the name of the license agreement from 5.2.3 to 5.2.0.
Related to PR #2702

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)
RubenCerna2079 added a commit that referenced this pull request May 31, 2025
…2.3 to 5.2.0 (#2706)

## Why make this change?

Need to update license agreement to old version in script. SqlClient.SNI
does not have a new version the same way the SqlClient package does with
5.2.3.

## What is this change?

This changes the name of the license agreement from 5.2.3 to 5.2.0.
Related to PR #2702

Cherry-picked PR:
- #2705

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: DAB fails to connect to Azure SQL server

3 participants