-
Notifications
You must be signed in to change notification settings - Fork 51
Add base-path option to the codechin cli arguments #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de0bf6d
to
32bb133
Compare
32bb133
to
3c283f5
Compare
chain = "mainnet" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this change, the code in the line https://github.com/CodeChain-io/codechain/pull/1499/files/3c283f526dfb43ca1261fa5a77f090e2626b41c7#diff-22a0b3dcef5d27fab89655ebdb330967R257 could be a cause of panic.
Do I need to remove this change and use unwrap_or
for the line mentioned above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it panic when you remove an empty line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I'm sorry I misunderstood that you mentioned about the +base_path = "."
change.
Hi @majecty @foriequal0, I have a question about the behavior of a relative path. |
I'm not familiar with the setting two paths in CLI. |
3c283f5
to
eebaf41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to merge it for now and implement a sandbox correctly in the future.
Let's merge it.
Now It's possible to specify
base-path
on which the keys and db directory will be created when running codechain. But there already are optionsdb-path
andkeys-path
.The rule relating to
db-path
,keys-path
andbase-path
is like following:db-path
andkeys-path
have higher priority thanbase-path
so ifboth
db-path
andkeys-path
are set,base-path
becomes meaningless.it closes #236