Skip to content

Add an explanation for managing data persistent #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HoOngEe
Copy link
Contributor

@HoOngEe HoOngEe commented Apr 29, 2019

This should be merged after the #1499 is merged
It closes #720

@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 2b5717a to a552e36 Compare April 29, 2019 06:23
@sgkim126 sgkim126 added the cli label Apr 29, 2019
@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from a552e36 to 434b002 Compare April 29, 2019 11:31
@kseo kseo requested a review from ScarletBlue April 29, 2019 12:16
README.md Outdated
@@ -53,6 +53,23 @@ docker run -it codechain-io/codechain:branch_or_tag_name

This should result in CodeChain running.

#### Making local database and keys persistent

CodeChain depends on the local database and keys commonly stored under the directories `keys` and `db`. A Docker container is independent of host environment and other Docker images. Therefore, in case of running a new Docker container with an image with a new CodeChain version or even with the same image, the database and keys are not persistent. To solve the problem, one can take advantage of Docker's volume option. With the command below,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeChain depends on the local database and keys commonly stored under the directories keys and db. A Docker container is independent of host environment and other Docker images. Therefore, when running a new Docker container with an image with a new CodeChain version or even with the same image, the database and keys are not persistent. To solve the problem, one can take advantage of the Docker's volume option. With the command below,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 434b002 to df369ab Compare May 9, 2019 08:57
ScarletBlue
ScarletBlue previously approved these changes May 14, 2019
@sgkim126
Copy link
Contributor

@HoOngEe Please resolve the conflicts

@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 9368ce8 to 145ef09 Compare May 22, 2019 01:30
@HoOngEe
Copy link
Contributor Author

HoOngEe commented May 22, 2019

I resolved the conflicts

@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 145ef09 to 53362f7 Compare May 22, 2019 02:08
@sgkim126 sgkim126 self-requested a review May 23, 2019 02:58
Copy link
Contributor

@sgkim126 sgkim126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HoOngEe Please check the commits again.
You should remove the first commit, but you left the commit and reverted the change of the first commit in the second commit.

@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 53362f7 to 00e675c Compare May 23, 2019 09:19
@HoOngEe
Copy link
Contributor Author

HoOngEe commented May 23, 2019

@sgkim126 I applied your suggestion and now the commit looks clear.

Added an explanation in the `Setup > Using Docker` section.
@HoOngEe HoOngEe force-pushed the feature/made-docker-image-data-persistent branch from 810c3db to d513a29 Compare May 23, 2019 09:22
@sgkim126 sgkim126 merged commit 05ebd22 into CodeChain-io:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Dockerfile configuration is not for persistance
3 participants