Skip to content

Implement ChangeParams #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2019
Merged

Implement ChangeParams #1535

merged 2 commits into from
May 27, 2019

Conversation

sgkim126
Copy link
Contributor

It closes #1506

@sgkim126 sgkim126 requested review from foriequal0 and majecty May 15, 2019 09:44
@sgkim126 sgkim126 added the do-not-merge Do not merge (for mergify.io) label May 15, 2019
@sgkim126 sgkim126 changed the title [WIP] Implement ChangeParams Implement ChangeParams May 15, 2019
@sgkim126
Copy link
Contributor Author

@majecty @foriequal0 Would you review the current code first?
I'll remove the do-not-merge tag after adding tests

majecty
majecty reviewed May 16, 2019
View reviewed changes
majecty
majecty requested changes May 16, 2019
View reviewed changes
foriequal0
foriequal0 requested changes May 16, 2019
View reviewed changes
@sgkim126 sgkim126 mentioned this pull request May 16, 2019
Merged
@sgkim126
Copy link
Contributor Author

I'm working on this issue.
The importer uses CommonParams to verify the transaction size limit or the transaction fee before importing because the CommonParams were immutable.
But this should be postponed after the transactions in the parent block executed because one of them can be ChangeParams.

@sgkim126 sgkim126 changed the title Implement ChangeParams [WIP] Implement ChangeParams May 20, 2019
@sgkim126
Copy link
Contributor Author

It depends on #1546. I'll remove the WIP tag after merging #1546.

@sgkim126 sgkim126 changed the title [WIP] Implement ChangeParams Implement ChangeParams May 22, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented May 22, 2019 •
edited
Loading

@majecty @foriequal0 I added tests.
This PR depends on #1552 and #1554 I'll remove do-not-merge after merging the PR.

@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label May 24, 2019
@sgkim126 sgkim126 requested review from foriequal0 and majecty May 24, 2019 06:22
@sgkim126
Copy link
Contributor Author

@majecty @foriequal0 Please review it again. All dependencies has been merged.

@sgkim126 sgkim126 mentioned this pull request May 24, 2019
Merged
foriequal0
foriequal0 requested changes May 24, 2019
View reviewed changes
majecty
majecty approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgkim126 sgkim126 requested a review from foriequal0 May 27, 2019 06:49
@mergify mergify bot merged commit 5baa576 into CodeChain-io:master May 27, 2019
@sgkim126 sgkim126 deleted the params branch May 28, 2019 01:18
@sgkim126 sgkim126 mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majecty majecty majecty approved these changes

@foriequal0 foriequal0 foriequal0 approved these changes

Assignees
No one assigned
Labels
transaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a transaction to change the parameters
3 participants
@sgkim126 @majecty @foriequal0