Skip to content

Change the stakeholders in solo e2e tests scheme #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019
Merged

Change the stakeholders in solo e2e tests scheme #1554

merged 1 commit into from
May 23, 2019

Conversation

sgkim126
Copy link
Contributor

Currently, the stake rates of Alice:Bob:Carol is 7:2:1.
This rate makes hard to test the real case because Alice has more than
2/3 and others cannot reach half.

This commit changes the rate to Alice:Bob:Carol:Dave to 4:3:2:1.

@sgkim126 sgkim126 added the test label May 22, 2019
@sgkim126 sgkim126 requested a review from foriequal0 May 22, 2019 07:38
Currently, the stake rates of faucet:Alice:Bob is 7:2:1.
This rate makes hard to test the real case because the faucet account
has more than 2/3 and others cannot reach half.

This commit changes the rate to Alice:Bob:Carol:Dave to 4:3:2:1.
@sgkim126 sgkim126 mentioned this pull request May 22, 2019
Copy link
Contributor

@foriequal0 foriequal0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why don't you change Tendermint scheme too?

@mergify mergify bot merged commit a20944f into CodeChain-io:master May 23, 2019
@sgkim126 sgkim126 deleted the const branch May 23, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants