Extract the crypto module to a new repository #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgkim126
changed the title
|
@sgkim126 |
|
@majecty I think registering the library in crates.io will merely increase the management cost with little benefit. Others except for CodeChain will rarely use the library since we customized it for CodeChain. |
|
I agree with @sgkim126. |
majecty
approved these changes
Oct 4, 2019
foriequal0
pushed a commit
to foriequal0/codechain
that referenced
this pull request
Nov 8, 2019
Extract the crypto module to a new repository
foriequal0
pushed a commit
that referenced
this pull request
Nov 11, 2019
Extract the crypto module to a new repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is moved to https://github.com/CodeChain-io/rust-codechain-crypto.
This PR closes #1500.