Bump the version to 2.2.0 #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoteCollector is changed to return Result<bool, DoubleVote>. Rust compiler will force you to check whether there was a double vote.
Extract the crypto module to a new repository
If generating a block takes too much time, the view could be changed before the miner module requests the signature. If the Tendermint module receives a signature request of an old view, it should ignore the message. Before this commit, the Tendermint module was crashing when it gets a signature request from an old view.
… time The Tendermint module was changing its step to 'Propose' when the "engine timeout empty proposal" timer is fired. If the timer is called in the wrong time the step should not be changed. This commit makes the step change when it is needed.
It is hard to know whether submit_proposal_block changes step or not. Since submit_proposal_block has only two lines of code, it doesn't remove code duplication. To clarify step transition, inline the submit_proposal_block function.
url 1.7.0 which CodeChain used, has a lifetime bug.
…t block When a new block is imported in Tendermint consensus, CodeChain checks the conditions below to judge whether it is safe to change the best block: First, whether the score is higher than before. Second, whether the height of a new block is higher than the finalized block's height. This commit fixes the code that is calculating the finalized block's height erroneously.
Immune users are immune from getting banned.
Before this commit, only the child of the best block and the child of the best proposal block could be a new best proposal block. A block that is a grandchild of the best block but not the child of the best proposal block should be able to become a best proposal block. After this commit, CodeChain checks whether a new block is the best block's child or grandchild.
And simplify travis.yml
…1.17) Update following packages: bytes v0.4.7 -> v0.4.12 parking_lot_core v0.6.1 -> v0.6.2 toml v0.5.1 -> v0.5.3 tokio v0.1.7 -> v0.1.17 Commands were: ``` cargo update --package bytes cargo update --package parking_lot_core:0.6.1 cargo update --package toml:0.5.1 cargo update --package tokio:0.1.7 --precise 0.1.17 ``` Errors were: 1. bytes: jsonrpc requires ^0.4.8, and bytes were pinned to v0.4.7 for sendgrid v0.8.1. 2. parking_lot_core: Amanieu/parking_lot#181 3. toml: `forward_to_deserialize_any_helper` was replaced by forward_to_deserialize_any 4. tokio: `Builder::core_threads` was introduced in 0.1.10
The fix (paritytech/jsonrpc#504) has been merged to `master`. It'll take times to relase, so use the merged master directly.
When the data structure of data that is saved in the KVDB is changed, CodeChain should migrate the data. To identify the stored data structure, we need to keep a version number. This commit adds code to save and load a version number. To make the DB easier to manage, this code saves versions in the same column with the same prefix.
…lock Tendermint worker's last_confirmed_view is used for two purposes. One is the previous height's finalized view, and the other one is the current height's finalized view. This commit is part of splitting the last_confirmed_view variable.
Tendermint worker's last_confirmed_view is used for two purposes. One is the previous height's finalized view, and the other one is the current height's finalized view. This commit is part of splitting the last_confirmed_view variable.
author_view: view when the block was created. finalized_view: view when the block was finalized.
This patch * prefers to use cmp * makes code return early * removes redundant cloning * removes redundant lifetime annotation * changes some other miscellaneous changes to follow clippy update.
And rename some variables that was misnamed as tx_hash.
JSONRPC server 14.0.3 does not close HTTP server on connection error.
You can see the changelog here: https://github.com/CodeChain-io/codechain/releases
sgkim126
approved these changes
Nov 8, 2019
remagpie
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: