Update file descriptor limits for macOS #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* common/fdlimit: cap on MacOS file limits, fixes #18994 * common/fdlimit: fix Maximum-check to respect OPEN_MAX * common/fdlimit: return error if OPEN_MAX is exceeded in Raise() * common/fdlimit: goimports * common/fdlimit: check value after setting fdlimit * common/fdlimit: make comment a bit more descriptive * cmd/utils: make fdlimit happy path a bit cleaner
…t64 (#19141) cast limit.Cur (int64) to uint64, fix test and compilation error
for working with Go 1.12
jbhurat
reviewed
Nov 25, 2019
|
@jbhurat I agree, although I would prefer to make that a follow up PR to keep the scopes small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-picked from:
ethereum/go-ethereum#19035
ethereum/go-ethereum#19068
ethereum/go-ethereum#19141
ethereum/go-ethereum#19166 (only relevant files)
This introduces proper file handle limits for
darwinbased OSes (macOS/OSX), and a few other test fixes.This fixes the main complaint when building with newer versions of Golang, as Quorum currently only supports up to version 1.11.x.
As far as I can tell, there are no other blockers for 1.12, although someone feel free to correct me :)
Fixes #889