Upgrade to Go 1.12 #19166
Merged
Upgrade to Go 1.12 #19166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelMarks
changed the title
SamuelMarks
force-pushed
the
go-1.12
branch
2 times, most recently
from
5a45b54 to
77bf127
Compare
|
I've worked around one upstream bug: golang/go#30399 Still fails with another upstream issue: golang/go#30401 |
|
FWIW, a cleaner way to work around the vet issue in 1.12 is to add something like: |
|
@mvdan Yeah, but since the issue is only in some relatively tiny test code, might as well just replace that formatting string. It's not something essential or live either way. |
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 11, 2024
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 3, 2024
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 19, 2024
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://golang.org/doc/go1.12