Tablespace Implementation #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
commented
Feb 14, 2023
benjaminjb
commented
Feb 14, 2023
benjaminjb
force-pushed
the
tablespace-initial
branch
from
66556c4 to
7957ba8
Compare
config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
Show resolved
Hide resolved
benjaminjb
force-pushed
the
tablespace-initial
branch
3 times, most recently
from
30e7a63 to
fb0876e
Compare
| @@ -1086,11 +1087,14 @@ func (r *Reconciler) reconcileInstance( | |||
| if err == nil { | |||
| postgresWALVolume, err = r.reconcilePostgresWALVolume(ctx, cluster, spec, instance, observed, clusterVolumes) | |||
| } | |||
| if err == nil { | |||
| tablespaceVolumes, err = r.reconcileTablespaceVolumes(ctx, cluster, spec, instance, clusterVolumes) | |||
| } | |||
| if err == nil { | |||
| postgres.InstancePod( | |||
There was a problem hiding this comment.
❓ Should this function start taking a parameter struct to bring the number of arguments down? Same question for reconcileRestoreJob in internal/controller/postgrescluster/pgbackrest.go.
There was a problem hiding this comment.
I'm not feeling that as a necessity at this moment, but would definitely consider it in the future
benjaminjb
force-pushed
the
tablespace-initial
branch
6 times, most recently
from
d283faf to
499d3c4
Compare
cbandy
reviewed
Feb 17, 2023
cbandy
reviewed
Feb 22, 2023
| @@ -561,6 +561,78 @@ func (r *Reconciler) reconcilePostgresDataVolume( | |||
| return pvc, err | |||
| } | |||
|
|
|||
| // +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=create;patch | |||
There was a problem hiding this comment.
⛏️ I prefer this syntax because it aligns with how our hack script works. There's no functional difference.
Suggested change
| // +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=create;patch | |
| // +kubebuilder:rbac:groups="",resources="persistentvolumeclaims",verbs={create,patch} |
There was a problem hiding this comment.
Worth changing these in the few places it exists?
There was a problem hiding this comment.
Actually we have a bunch of annotations that follow the first syntax, maybe it's worth a whole separate PR to bring it into line?
There was a problem hiding this comment.
Agreed. No need to touch lots of stuff in this PR.
pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
Show resolved
Hide resolved
pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
Show resolved
Hide resolved
benjaminjb
commented
Feb 22, 2023
benjaminjb
force-pushed
the
tablespace-initial
branch
3 times, most recently
from
9f9d635 to
bf4ca05
Compare
* Adds the tablespaceVolumes field to the CRD; * Adds basic tablespace functionality: mounts the volumes and preps them with correct permissions; * Adds option for restoring with tablespaces; * Adds docs/content/guides/tablespaces * Adds a basic KUTTL test for creating a cluster with tablespaces; * Updates the github test to add the feature gate Issue: [sc-17759]
benjaminjb
force-pushed
the
tablespace-initial
branch
from
bf4ca05 to
c414223
Compare
This was referenced Feb 23, 2023
andrewlecuyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Tablespaces were not implemented by the operator
What is the new behavior (if this is a feature change)?
Implements and documents a tablespaces feature, which is behind a feature flag.
Other Information:
Issue: [sc-17759]