Migrate AgentBootStrap to environment component #9072

PerfectSlayer · 2025-07-01T04:28:31Z

What Does This Do

This PR migrates the agent bootstrap check to use the new environment component.

Follow-up to Introduce environment component #9071

Motivation

The goal is to have better and safer check, especially around agent detection.

Additional Notes

This PR is the second of many stacked PRs to come.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-01T11:55:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/environment-step2
git_commit_date	1751525551	1751528534
git_commit_sha	`5353d51`	`2247e2e`
release_version	1.51.0-SNAPSHOT~5353d512d0	1.51.0-SNAPSHOT~2247e2e201

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751530379	1751530379
ci_job_id	1011509260	1011509260
ci_pipeline_id	69525494	69525494
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-86dhr0xb 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-86dhr0xb 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014308
Total [baseline] (8.604 s) : 0, 8603929
Agent [candidate] (995.654 ms) : 0, 995654
Total [candidate] (8.54 s) : 0, 8539690
section iast
Agent [baseline] (1.132 s) : 0, 1132342
Total [baseline] (9.246 s) : 0, 9246026
Agent [candidate] (1.14 s) : 0, 1140084
Total [candidate] (9.267 s) : 0, 9266640

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	iast	1.132 s	118.034 ms (11.6%)
Total	tracing	8.604 s	-
Total	iast	9.246 s	642.097 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	995.654 ms	-
Agent	iast	1.14 s	144.43 ms (14.5%)
Total	tracing	8.54 s	-
Total	iast	9.267 s	726.95 ms (8.5%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.537 ms) : 0, 702537
BytebuddyAgent [candidate] (687.83 ms) : 0, 687830
GlobalTracer [baseline] (244.769 ms) : 0, 244769
GlobalTracer [candidate] (242.085 ms) : 0, 242085
AppSec [baseline] (30.74 ms) : 0, 30740
AppSec [candidate] (30.116 ms) : 0, 30116
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (695.426 µs) : 0, 695
Remote Config [candidate] (697.116 µs) : 0, 697
Telemetry [baseline] (8.308 ms) : 0, 8308
Telemetry [candidate] (8.242 ms) : 0, 8242
section iast
BytebuddyAgent [baseline] (808.373 ms) : 0, 808373
BytebuddyAgent [candidate] (814.33 ms) : 0, 814330
GlobalTracer [baseline] (233.084 ms) : 0, 233084
GlobalTracer [candidate] (234.305 ms) : 0, 234305
IAST [baseline] (29.78 ms) : 0, 29780
IAST [candidate] (27.105 ms) : 0, 27105
AppSec [baseline] (25.984 ms) : 0, 25984
AppSec [candidate] (28.122 ms) : 0, 28122
Debugger [baseline] (5.843 ms) : 0, 5843
Debugger [candidate] (6.711 ms) : 0, 6711
Remote Config [baseline] (572.853 µs) : 0, 573
Remote Config [candidate] (582.911 µs) : 0, 583
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (8.006 ms) : 0, 8006

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (997.474 ms) : 0, 997474
Total [baseline] (10.622 s) : 0, 10622164
Agent [candidate] (998.537 ms) : 0, 998537
Total [candidate] (10.61 s) : 0, 10610228
section appsec
Agent [baseline] (1.175 s) : 0, 1174886
Total [baseline] (10.775 s) : 0, 10774879
Agent [candidate] (1.184 s) : 0, 1183585
Total [candidate] (10.833 s) : 0, 10833112
section iast
Agent [baseline] (1.151 s) : 0, 1151275
Total [baseline] (10.956 s) : 0, 10955825
Agent [candidate] (1.139 s) : 0, 1139389
Total [candidate] (10.842 s) : 0, 10842044
section profiling
Agent [baseline] (1.25 s) : 0, 1250165
Total [baseline] (10.898 s) : 0, 10897876
Agent [candidate] (1.262 s) : 0, 1262059
Total [candidate] (11.01 s) : 0, 11009619

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.474 ms	-
Agent	appsec	1.175 s	177.411 ms (17.8%)
Agent	iast	1.151 s	153.801 ms (15.4%)
Agent	profiling	1.25 s	252.691 ms (25.3%)
Total	tracing	10.622 s	-
Total	appsec	10.775 s	152.715 ms (1.4%)
Total	iast	10.956 s	333.661 ms (3.1%)
Total	profiling	10.898 s	275.712 ms (2.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	998.537 ms	-
Agent	appsec	1.184 s	185.048 ms (18.5%)
Agent	iast	1.139 s	140.852 ms (14.1%)
Agent	profiling	1.262 s	263.522 ms (26.4%)
Total	tracing	10.61 s	-
Total	appsec	10.833 s	222.884 ms (2.1%)
Total	iast	10.842 s	231.816 ms (2.2%)
Total	profiling	11.01 s	399.391 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.101 ms) : 0, 689101
BytebuddyAgent [candidate] (689.581 ms) : 0, 689581
GlobalTracer [baseline] (242.492 ms) : 0, 242492
GlobalTracer [candidate] (242.889 ms) : 0, 242889
AppSec [baseline] (30.168 ms) : 0, 30168
AppSec [candidate] (30.39 ms) : 0, 30390
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (667.202 µs) : 0, 667
Remote Config [candidate] (681.416 µs) : 0, 681
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.241 ms) : 0, 8241
section appsec
BytebuddyAgent [baseline] (710.672 ms) : 0, 710672
BytebuddyAgent [candidate] (717.603 ms) : 0, 717603
GlobalTracer [baseline] (235.967 ms) : 0, 235967
GlobalTracer [candidate] (236.55 ms) : 0, 236550
IAST [baseline] (22.053 ms) : 0, 22053
IAST [candidate] (22.184 ms) : 0, 22184
AppSec [baseline] (170.901 ms) : 0, 170901
AppSec [candidate] (171.71 ms) : 0, 171710
Debugger [baseline] (5.791 ms) : 0, 5791
Debugger [candidate] (5.794 ms) : 0, 5794
Remote Config [baseline] (610.732 µs) : 0, 611
Remote Config [candidate] (603.518 µs) : 0, 604
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (8.162 ms) : 0, 8162
section iast
BytebuddyAgent [baseline] (822.33 ms) : 0, 822330
BytebuddyAgent [candidate] (813.687 ms) : 0, 813687
GlobalTracer [baseline] (236.573 ms) : 0, 236573
GlobalTracer [candidate] (234.35 ms) : 0, 234350
IAST [baseline] (28.519 ms) : 0, 28519
IAST [candidate] (25.817 ms) : 0, 25817
AppSec [baseline] (28.19 ms) : 0, 28190
AppSec [candidate] (30.419 ms) : 0, 30419
Debugger [baseline] (5.91 ms) : 0, 5910
Debugger [candidate] (5.784 ms) : 0, 5784
Remote Config [baseline] (585.635 µs) : 0, 586
Remote Config [candidate] (560.818 µs) : 0, 561
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (7.93 ms) : 0, 7930
section profiling
BytebuddyAgent [baseline] (682.252 ms) : 0, 682252
BytebuddyAgent [candidate] (688.252 ms) : 0, 688252
GlobalTracer [baseline] (363.155 ms) : 0, 363155
GlobalTracer [candidate] (365.302 ms) : 0, 365302
AppSec [baseline] (32.392 ms) : 0, 32392
AppSec [candidate] (33.761 ms) : 0, 33761
Debugger [baseline] (10.68 ms) : 0, 10680
Debugger [candidate] (11.383 ms) : 0, 11383
Remote Config [baseline] (656.226 µs) : 0, 656
Remote Config [candidate] (679.401 µs) : 0, 679
Telemetry [baseline] (9.393 ms) : 0, 9393
Telemetry [candidate] (8.166 ms) : 0, 8166
ProfilingAgent [baseline] (102.77 ms) : 0, 102770
ProfilingAgent [candidate] (105.269 ms) : 0, 105269
Profiling [baseline] (102.795 ms) : 0, 102795
Profiling [candidate] (105.294 ms) : 0, 105294

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/environment-step2
git_commit_date	1751525551	1751528534
git_commit_sha	`5353d51`	`2247e2e`
release_version	1.51.0-SNAPSHOT~5353d512d0	1.51.0-SNAPSHOT~2247e2e201

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751530060	1751530060
ci_job_id	1011509261	1011509261
ci_pipeline_id	69525494	69525494
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-rpjnzkzj 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-rpjnzkzj 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+216.738µs; +602.037µs] or [+2.163%; +6.009%]	unstable [-72.523op/s; +37.085op/s] or [-15.647%; +8.001%]	10.428ms	445.781op/s	10.019ms	463.500op/s
scenario:load:petclinic:code_origins:high_load	better [-2.711ms; -1.864ms] or [-5.698%; -3.919%]	unstable [-2.279op/s; +12.179op/s] or [-2.317%; +12.383%]	45.287ms	103.300op/s	47.574ms	98.350op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.114 ms) : 34839, 35389
.   : milestone, 35114,
appsec (47.08 ms) : 46648, 47513
.   : milestone, 47080,
code_origins (47.574 ms) : 47164, 47985
.   : milestone, 47574,
iast (43.885 ms) : 43499, 44271
.   : milestone, 43885,
profiling (48.245 ms) : 47780, 48710
.   : milestone, 48245,
tracing (44.448 ms) : 44075, 44822
.   : milestone, 44448,
section candidate
no_agent (34.853 ms) : 34583, 35123
.   : milestone, 34853,
appsec (46.507 ms) : 46093, 46921
.   : milestone, 46507,
code_origins (45.287 ms) : 44911, 45662
.   : milestone, 45287,
iast (44.895 ms) : 44507, 45283
.   : milestone, 44895,
profiling (47.783 ms) : 47327, 48239
.   : milestone, 47783,
tracing (44.048 ms) : 43663, 44433
.   : milestone, 44048,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.114 ms [34.839 ms, 35.389 ms]	-
appsec	47.08 ms [46.648 ms, 47.513 ms]	11.967 ms (34.1%)
code_origins	47.574 ms [47.164 ms, 47.985 ms]	12.461 ms (35.5%)
iast	43.885 ms [43.499 ms, 44.271 ms]	8.771 ms (25.0%)
profiling	48.245 ms [47.78 ms, 48.71 ms]	13.131 ms (37.4%)
tracing	44.448 ms [44.075 ms, 44.822 ms]	9.335 ms (26.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	34.853 ms [34.583 ms, 35.123 ms]	-
appsec	46.507 ms [46.093 ms, 46.921 ms]	11.654 ms (33.4%)
code_origins	45.287 ms [44.911 ms, 45.662 ms]	10.434 ms (29.9%)
iast	44.895 ms [44.507 ms, 45.283 ms]	10.042 ms (28.8%)
profiling	47.783 ms [47.327 ms, 48.239 ms]	12.931 ms (37.1%)
tracing	44.048 ms [43.663 ms, 44.433 ms]	9.195 ms (26.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.387 ms) : 4337, 4438
.   : milestone, 4387,
iast (9.015 ms) : 8869, 9161
.   : milestone, 9015,
iast_FULL (14.058 ms) : 13778, 14338
.   : milestone, 14058,
iast_GLOBAL (10.019 ms) : 9844, 10194
.   : milestone, 10019,
profiling (8.818 ms) : 8671, 8965
.   : milestone, 8818,
tracing (7.727 ms) : 7609, 7845
.   : milestone, 7727,
section candidate
no_agent (4.485 ms) : 4434, 4536
.   : milestone, 4485,
iast (9.102 ms) : 8955, 9248
.   : milestone, 9102,
iast_FULL (13.915 ms) : 13642, 14189
.   : milestone, 13915,
iast_GLOBAL (10.428 ms) : 10246, 10611
.   : milestone, 10428,
profiling (8.74 ms) : 8600, 8880
.   : milestone, 8740,
tracing (7.542 ms) : 7435, 7649
.   : milestone, 7542,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.387 ms [4.337 ms, 4.438 ms]	-
iast	9.015 ms [8.869 ms, 9.161 ms]	4.628 ms (105.5%)
iast_FULL	14.058 ms [13.778 ms, 14.338 ms]	9.671 ms (220.4%)
iast_GLOBAL	10.019 ms [9.844 ms, 10.194 ms]	5.632 ms (128.4%)
profiling	8.818 ms [8.671 ms, 8.965 ms]	4.43 ms (101.0%)
tracing	7.727 ms [7.609 ms, 7.845 ms]	3.34 ms (76.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.485 ms [4.434 ms, 4.536 ms]	-
iast	9.102 ms [8.955 ms, 9.248 ms]	4.617 ms (102.9%)
iast_FULL	13.915 ms [13.642 ms, 14.189 ms]	9.43 ms (210.3%)
iast_GLOBAL	10.428 ms [10.246 ms, 10.611 ms]	5.943 ms (132.5%)
profiling	8.74 ms [8.6 ms, 8.88 ms]	4.255 ms (94.9%)
tracing	7.542 ms [7.435 ms, 7.649 ms]	3.057 ms (68.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/environment-step2
git_commit_date	1751525551	1751528534
git_commit_sha	`5353d51`	`2247e2e`
release_version	1.51.0-SNAPSHOT~5353d512d0	1.51.0-SNAPSHOT~2247e2e201

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1751530668	1751530668
ci_job_id	1011509262	1011509262
ci_pipeline_id	69525494	69525494
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-3z3muvgi 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-3z3muvgi 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.415 ms) : 2364, 2465
.   : milestone, 2415,
iast (2.198 ms) : 2136, 2261
.   : milestone, 2198,
iast_GLOBAL (2.242 ms) : 2179, 2305
.   : milestone, 2242,
profiling (2.041 ms) : 1990, 2093
.   : milestone, 2041,
tracing (2.007 ms) : 1958, 2056
.   : milestone, 2007,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.406 ms) : 2356, 2456
.   : milestone, 2406,
iast (2.195 ms) : 2132, 2257
.   : milestone, 2195,
iast_GLOBAL (2.235 ms) : 2172, 2297
.   : milestone, 2235,
profiling (2.043 ms) : 1992, 2094
.   : milestone, 2043,
tracing (2.013 ms) : 1964, 2062
.   : milestone, 2013,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.415 ms [2.364 ms, 2.465 ms]	941.962 µs (64.0%)
iast	2.198 ms [2.136 ms, 2.261 ms]	725.678 µs (49.3%)
iast_GLOBAL	2.242 ms [2.179 ms, 2.305 ms]	769.405 µs (52.2%)
profiling	2.041 ms [1.99 ms, 2.093 ms]	568.524 µs (38.6%)
tracing	2.007 ms [1.958 ms, 2.056 ms]	534.333 µs (36.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.406 ms [2.356 ms, 2.456 ms]	930.023 µs (63.0%)
iast	2.195 ms [2.132 ms, 2.257 ms]	718.796 µs (48.7%)
iast_GLOBAL	2.235 ms [2.172 ms, 2.297 ms]	758.942 µs (51.4%)
profiling	2.043 ms [1.992 ms, 2.094 ms]	567.144 µs (38.4%)
tracing	2.013 ms [1.964 ms, 2.062 ms]	537.537 µs (36.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2247e2e201, baseline=1.51.0-SNAPSHOT~5353d512d0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.346 s) : 15346000, 15346000
.   : milestone, 15346000,
appsec (14.836 s) : 14836000, 14836000
.   : milestone, 14836000,
iast (18.363 s) : 18363000, 18363000
.   : milestone, 18363000,
iast_GLOBAL (18.103 s) : 18103000, 18103000
.   : milestone, 18103000,
profiling (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
tracing (14.632 s) : 14632000, 14632000
.   : milestone, 14632000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
appsec (14.66 s) : 14660000, 14660000
.   : milestone, 14660000,
iast (18.661 s) : 18661000, 18661000
.   : milestone, 18661000,
iast_GLOBAL (17.672 s) : 17672000, 17672000
.   : milestone, 17672000,
profiling (15.144 s) : 15144000, 15144000
.   : milestone, 15144000,
tracing (14.618 s) : 14618000, 14618000
.   : milestone, 14618000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.346 s [15.346 s, 15.346 s]	-
appsec	14.836 s [14.836 s, 14.836 s]	-510.0 ms (-3.3%)
iast	18.363 s [18.363 s, 18.363 s]	3.017 s (19.7%)
iast_GLOBAL	18.103 s [18.103 s, 18.103 s]	2.757 s (18.0%)
profiling	15.105 s [15.105 s, 15.105 s]	-241.0 ms (-1.6%)
tracing	14.632 s [14.632 s, 14.632 s]	-714.0 ms (-4.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.457 s [15.457 s, 15.457 s]	-
appsec	14.66 s [14.66 s, 14.66 s]	-797.0 ms (-5.2%)
iast	18.661 s [18.661 s, 18.661 s]	3.204 s (20.7%)
iast_GLOBAL	17.672 s [17.672 s, 17.672 s]	2.215 s (14.3%)
profiling	15.144 s [15.144 s, 15.144 s]	-313.0 ms (-2.0%)
tracing	14.618 s [14.618 s, 14.618 s]	-839.0 ms (-5.4%)

components/environment/build.gradle.kts

amarziali

lgtm

amarziali · 2025-07-03T07:45:47Z

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Constants.java

   */
  public static final String[] BOOTSTRAP_PACKAGE_PREFIXES = {
    "datadog.slf4j",
+    "datadog.context",


a curiosity: are those in probability of match order? Otherwise we might tend to have them just ordered alphabetically. (It's not necessary to change)

We usually iterate over the array and use startWith() with the elements.
So order will matter yes. But is it currently the best order? I'm unsure.
@mcculls might be able to provide more context here.

maybe this can be refactored as a trie (unsure what we have today handles package names) ?

I added the tries idea to the feedback collection stored in the JIRA card 👍

PerfectSlayer added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Jul 1, 2025

PerfectSlayer force-pushed the bbujon/environment-step2 branch 2 times, most recently from abadc3a to 7f998a4 Compare July 1, 2025 11:20

smola reviewed Jul 2, 2025

View reviewed changes

components/environment/build.gradle.kts Show resolved Hide resolved

PerfectSlayer force-pushed the bbujon/environment-step2 branch from 7f998a4 to 874c7b1 Compare July 2, 2025 09:30

PerfectSlayer changed the base branch from master to bbujon/environment-step1 July 2, 2025 09:41

Base automatically changed from bbujon/environment-step1 to master July 3, 2025 05:33

PerfectSlayer marked this pull request as ready for review July 3, 2025 05:33

PerfectSlayer requested review from a team as code owners July 3, 2025 05:34

PerfectSlayer requested review from AlexeyKuznetsov-DD, amarziali, bric3 and smola and removed request for a team July 3, 2025 05:34

feat(env): Migrate AgentBootstrap to environment component

2247e2e

PerfectSlayer force-pushed the bbujon/environment-step2 branch from 874c7b1 to 2247e2e Compare July 3, 2025 07:43

amarziali approved these changes Jul 3, 2025

View reviewed changes

bric3 approved these changes Jul 3, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Jul 3, 2025

Migrate internal-api to environment component #9091

Merged

PerfectSlayer merged commit 6aa285f into master Jul 3, 2025
676 of 677 checks passed

PerfectSlayer deleted the bbujon/environment-step2 branch July 3, 2025 12:54

github-actions bot added this to the 1.51.0 milestone Jul 3, 2025

This was referenced Jul 3, 2025

Migrate agent and instrumentations to environment component #9093

Merged

Migrate smoke tests to environment component #9100

Merged

Clean up Platform and CLIHelper component #9101

Merged

PerfectSlayer mentioned this pull request Jul 17, 2025

Improve environment component null values handling #9188

Merged

This was referenced Jul 17, 2025

Improve agent to avoid loading global config on main thread #9190

Merged

Migrate Config system to environment component #9191

Merged

This was referenced Aug 1, 2025

Migrate products and instrumentations to environment component #9290

Merged

Migrate internal apis to environment component #9291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate AgentBootStrap to environment component #9072

Migrate AgentBootStrap to environment component #9072

Uh oh!

PerfectSlayer commented Jul 1, 2025 •

edited by bric3

Loading

Uh oh!

pr-commenter bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

amarziali left a comment

Uh oh!

amarziali Jul 3, 2025

Uh oh!

PerfectSlayer Jul 3, 2025

Uh oh!

bric3 Jul 3, 2025

Uh oh!

PerfectSlayer Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

Migrate AgentBootStrap to environment component #9072

Migrate AgentBootStrap to environment component #9072

Uh oh!

Conversation

PerfectSlayer commented Jul 1, 2025 • edited by bric3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

amarziali Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer commented Jul 1, 2025 •

edited by bric3

Loading

pr-commenter bot commented Jul 1, 2025 •

edited

Loading