Skip to content

Migrate agent and instrumentations to environment component #9093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Migrate agent and instrumentations to environment component #9093

merged 1 commit into from
Jul 4, 2025

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Jul 3, 2025 •
edited by atlassian bot
Loading

What Does This Do

This PR migrates the internal API to the environment components.

Follow-up to:

Motivation

Additional Notes

This PR is mainly refactoring to use the new methods from the environment component rather than the original ones in Platform.

Contributor Checklist

Jira ticket: LANGPLAT-458

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes type: refactoring comp: platform Platform components labels Jul 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1751560426 1751560808
end_time 2025-07-03T16:35:06 2025-07-03T16:41:29
git_branch master bbujon/environment-step4
git_commit_sha 33422a3 e1aa51e
start_time 2025-07-03T16:33:47 2025-07-03T16:40:09
See matching parameters
Baseline Candidate
ci_job_id 1012866930 1012866930
ci_pipeline_id 69590381 69590381
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1751559856 1751559856

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-670.355µs; -654.690µs] or [-6.287%; -6.140%]		 better
[-686.709µs; -618.723µs] or [-6.346%; -5.718%]		 better
[-668.576µs; -566.343µs] or [-6.142%; -5.203%]		 better
[-852.552µs; -547.408µs] or [-7.594%; -4.876%]		 better
[+4.652op/s; +6.874op/s] or [+5.094%; +7.528%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-14.819µs; +34.577µs] or [-5.431%; +12.672%]		 unstable
[-22.087µs; +47.044µs] or [-7.095%; +15.111%]		 unstable
[-30.420µs; +63.698µs] or [-9.370%; +19.620%]		 unstable
[-110.382µs; +105.735µs] or [-11.544%; +11.058%]		 same
scenario:basic same same same unstable
[-119.440µs; +77.516µs] or [-13.619%; +8.839%]		 same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (311.315 µs) : 290, 332
.   : milestone, 311,
basic (315.175 µs) : 306, 324
.   : milestone, 315,
loop (10.821 ms) : 10816, 10826
.   : milestone, 10821,
section candidate
noprobe (323.793 µs) : 282, 365
.   : milestone, 324,
basic (316.345 µs) : 306, 327
.   : milestone, 316,
loop (10.168 ms) : 10124, 10213
.   : milestone, 10168,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 311.315 µs [290.161 µs, 332.468 µs]
basic 315.175 µs [306.172 µs, 324.178 µs]
loop 10.821 ms [10.816 ms, 10.826 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 323.793 µs [282.34 µs, 365.246 µs]
basic 316.345 µs [305.708 µs, 326.982 µs]
loop 10.168 ms [10.124 ms, 10.213 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/environment-step4
git_commit_date 1751559115 1751559856
git_commit_sha 33422a3 e1aa51e
release_version 1.51.0-SNAPSHOT~33422a3a65 1.51.0-SNAPSHOT~e1aa51eefc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751561670 1751561670
ci_job_id 1012866923 1012866923
ci_pipeline_id 69590381 69590381
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-h3prf4i1 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-h3prf4i1 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (999.174 ms) : 0, 999174
Total [baseline] (10.6 s) : 0, 10600095
Agent [candidate] (996.057 ms) : 0, 996057
Total [candidate] (10.576 s) : 0, 10575531
section appsec
Agent [baseline] (1.184 s) : 0, 1183533
Total [baseline] (10.8 s) : 0, 10800321
Agent [candidate] (1.183 s) : 0, 1182806
Total [candidate] (10.804 s) : 0, 10804095
section iast
Agent [baseline] (1.133 s) : 0, 1133332
Total [baseline] (10.809 s) : 0, 10808838
Agent [candidate] (1.14 s) : 0, 1139682
Total [candidate] (10.816 s) : 0, 10815892
section profiling
Agent [baseline] (1.252 s) : 0, 1252320
Total [baseline] (11.016 s) : 0, 11015678
Agent [candidate] (1.246 s) : 0, 1246149
Total [candidate] (11.0 s) : 0, 10999507
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 999.174 ms -
Agent appsec 1.184 s 184.359 ms (18.5%)
Agent iast 1.133 s 134.157 ms (13.4%)
Agent profiling 1.252 s 253.145 ms (25.3%)
Total tracing 10.6 s -
Total appsec 10.8 s 200.226 ms (1.9%)
Total iast 10.809 s 208.743 ms (2.0%)
Total profiling 11.016 s 415.583 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 996.057 ms -
Agent appsec 1.183 s 186.749 ms (18.7%)
Agent iast 1.14 s 143.625 ms (14.4%)
Agent profiling 1.246 s 250.092 ms (25.1%)
Total tracing 10.576 s -
Total appsec 10.804 s 228.565 ms (2.2%)
Total iast 10.816 s 240.361 ms (2.3%)
Total profiling 11.0 s 423.976 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.654 ms) : 0, 690654
BytebuddyAgent [candidate] (687.501 ms) : 0, 687501
GlobalTracer [baseline] (242.427 ms) : 0, 242427
GlobalTracer [candidate] (241.998 ms) : 0, 241998
AppSec [baseline] (30.398 ms) : 0, 30398
AppSec [candidate] (30.256 ms) : 0, 30256
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (685.408 µs) : 0, 685
Remote Config [candidate] (681.701 µs) : 0, 682
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.259 ms) : 0, 8259
section appsec
BytebuddyAgent [baseline] (716.315 ms) : 0, 716315
BytebuddyAgent [candidate] (715.585 ms) : 0, 715585
GlobalTracer [baseline] (236.344 ms) : 0, 236344
GlobalTracer [candidate] (236.525 ms) : 0, 236525
AppSec [baseline] (171.928 ms) : 0, 171928
AppSec [candidate] (171.157 ms) : 0, 171157
Debugger [baseline] (5.796 ms) : 0, 5796
Debugger [candidate] (5.744 ms) : 0, 5744
Remote Config [baseline] (609.116 µs) : 0, 609
Remote Config [candidate] (594.892 µs) : 0, 595
Telemetry [baseline] (8.151 ms) : 0, 8151
Telemetry [candidate] (8.098 ms) : 0, 8098
IAST [baseline] (23.501 ms) : 0, 23501
IAST [candidate] (23.525 ms) : 0, 23525
section iast
BytebuddyAgent [baseline] (807.968 ms) : 0, 807968
BytebuddyAgent [candidate] (813.682 ms) : 0, 813682
GlobalTracer [baseline] (232.819 ms) : 0, 232819
GlobalTracer [candidate] (232.904 ms) : 0, 232904
AppSec [baseline] (29.637 ms) : 0, 29637
AppSec [candidate] (30.163 ms) : 0, 30163
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.835 ms) : 0, 5835
Remote Config [baseline] (586.756 µs) : 0, 587
Remote Config [candidate] (577.68 µs) : 0, 578
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (8.042 ms) : 0, 8042
IAST [baseline] (27.72 ms) : 0, 27720
IAST [candidate] (27.07 ms) : 0, 27070
section profiling
ProfilingAgent [baseline] (104.811 ms) : 0, 104811
ProfilingAgent [candidate] (102.93 ms) : 0, 102930
BytebuddyAgent [baseline] (683.027 ms) : 0, 683027
BytebuddyAgent [candidate] (679.481 ms) : 0, 679481
GlobalTracer [baseline] (362.465 ms) : 0, 362465
GlobalTracer [candidate] (361.482 ms) : 0, 361482
AppSec [baseline] (33.282 ms) : 0, 33282
AppSec [candidate] (33.811 ms) : 0, 33811
Debugger [baseline] (9.838 ms) : 0, 9838
Debugger [candidate] (9.115 ms) : 0, 9115
Remote Config [baseline] (667.336 µs) : 0, 667
Remote Config [candidate] (660.17 µs) : 0, 660
Telemetry [baseline] (8.803 ms) : 0, 8803
Telemetry [candidate] (9.476 ms) : 0, 9476
Profiling [baseline] (104.836 ms) : 0, 104836
Profiling [candidate] (102.954 ms) : 0, 102954
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (996.387 ms) : 0, 996387
Total [baseline] (8.561 s) : 0, 8561268
Agent [candidate] (995.524 ms) : 0, 995524
Total [candidate] (8.607 s) : 0, 8607241
section iast
Agent [baseline] (1.136 s) : 0, 1135979
Total [baseline] (9.265 s) : 0, 9265211
Agent [candidate] (1.133 s) : 0, 1132953
Total [candidate] (9.26 s) : 0, 9260462
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 996.387 ms -
Agent iast 1.136 s 139.592 ms (14.0%)
Total tracing 8.561 s -
Total iast 9.265 s 703.943 ms (8.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 995.524 ms -
Agent iast 1.133 s 137.429 ms (13.8%)
Total tracing 8.607 s -
Total iast 9.26 s 653.221 ms (7.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.803 ms) : 0, 688803
BytebuddyAgent [candidate] (687.173 ms) : 0, 687173
GlobalTracer [baseline] (241.575 ms) : 0, 241575
GlobalTracer [candidate] (241.729 ms) : 0, 241729
AppSec [baseline] (30.348 ms) : 0, 30348
AppSec [candidate] (30.273 ms) : 0, 30273
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (670.228 µs) : 0, 670
Remote Config [candidate] (686.374 µs) : 0, 686
Telemetry [baseline] (8.216 ms) : 0, 8216
Telemetry [candidate] (8.284 ms) : 0, 8284
section iast
BytebuddyAgent [baseline] (810.175 ms) : 0, 810175
BytebuddyAgent [candidate] (807.139 ms) : 0, 807139
GlobalTracer [baseline] (233.283 ms) : 0, 233283
GlobalTracer [candidate] (232.61 ms) : 0, 232610
AppSec [baseline] (28.632 ms) : 0, 28632
AppSec [candidate] (31.231 ms) : 0, 31231
Debugger [baseline] (5.805 ms) : 0, 5805
Debugger [candidate] (5.805 ms) : 0, 5805
Remote Config [baseline] (573.136 µs) : 0, 573
Remote Config [candidate] (590.965 µs) : 0, 591
Telemetry [baseline] (8.076 ms) : 0, 8076
Telemetry [candidate] (7.987 ms) : 0, 7987
IAST [baseline] (28.739 ms) : 0, 28739
IAST [candidate] (26.339 ms) : 0, 26339
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/environment-step4
git_commit_date 1751559115 1751559856
git_commit_sha 33422a3 e1aa51e
release_version 1.51.0-SNAPSHOT~33422a3a65 1.51.0-SNAPSHOT~e1aa51eefc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751561351 1751561351
ci_job_id 1012866924 1012866924
ci_pipeline_id 69590381 69590381
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-4dapqxtz 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-4dapqxtz 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:no_agent:high_load better
[-1.572ms; -0.944ms] or [-4.191%; -2.518%]		 unstable
[-4.691op/s; +13.266op/s] or [-3.764%; +10.643%]		 36.246ms 128.938op/s 37.505ms 124.650op/s
scenario:load:petclinic:profiling:high_load worse
[+2.927ms; +3.917ms] or [+6.191%; +8.286%]		 unstable
[-13.858op/s; +0.533op/s] or [-14.000%; +0.539%]		 50.696ms 92.325op/s 47.274ms 98.987op/s
scenario:load:petclinic:code_origins:high_load worse
[+1.423ms; +2.223ms] or [+3.260%; +5.092%]		 unstable
[-11.998op/s; +3.473op/s] or [-11.196%; +3.241%]		 45.474ms 102.900op/s 43.651ms 107.162op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.505 ms) : 37211, 37798
.   : milestone, 37505,
appsec (47.704 ms) : 47272, 48136
.   : milestone, 47704,
code_origins (43.651 ms) : 43290, 44013
.   : milestone, 43651,
iast (44.29 ms) : 43912, 44667
.   : milestone, 44290,
profiling (47.274 ms) : 46862, 47686
.   : milestone, 47274,
tracing (43.508 ms) : 43157, 43859
.   : milestone, 43508,
section candidate
no_agent (36.246 ms) : 35957, 36536
.   : milestone, 36246,
appsec (46.953 ms) : 46526, 47381
.   : milestone, 46953,
code_origins (45.474 ms) : 45093, 45855
.   : milestone, 45474,
iast (44.434 ms) : 44046, 44821
.   : milestone, 44434,
profiling (50.696 ms) : 50193, 51200
.   : milestone, 50696,
tracing (43.026 ms) : 42668, 43383
.   : milestone, 43026,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.505 ms [37.211 ms, 37.798 ms] -
appsec 47.704 ms [47.272 ms, 48.136 ms] 10.2 ms (27.2%)
code_origins 43.651 ms [43.29 ms, 44.013 ms] 6.147 ms (16.4%)
iast 44.29 ms [43.912 ms, 44.667 ms] 6.785 ms (18.1%)
profiling 47.274 ms [46.862 ms, 47.686 ms] 9.77 ms (26.0%)
tracing 43.508 ms [43.157 ms, 43.859 ms] 6.004 ms (16.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.246 ms [35.957 ms, 36.536 ms] -
appsec 46.953 ms [46.526 ms, 47.381 ms] 10.707 ms (29.5%)
code_origins 45.474 ms [45.093 ms, 45.855 ms] 9.227 ms (25.5%)
iast 44.434 ms [44.046 ms, 44.821 ms] 8.188 ms (22.6%)
profiling 50.696 ms [50.193 ms, 51.2 ms] 14.45 ms (39.9%)
tracing 43.026 ms [42.668 ms, 43.383 ms] 6.779 ms (18.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.372 ms) : 4320, 4424
.   : milestone, 4372,
iast (9.214 ms) : 9058, 9370
.   : milestone, 9214,
iast_FULL (14.178 ms) : 13899, 14457
.   : milestone, 14178,
iast_GLOBAL (10.426 ms) : 10241, 10611
.   : milestone, 10426,
profiling (8.987 ms) : 8826, 9149
.   : milestone, 8987,
tracing (7.435 ms) : 7328, 7542
.   : milestone, 7435,
section candidate
no_agent (4.247 ms) : 4196, 4297
.   : milestone, 4247,
iast (9.378 ms) : 9228, 9528
.   : milestone, 9378,
iast_FULL (14.103 ms) : 13819, 14388
.   : milestone, 14103,
iast_GLOBAL (10.637 ms) : 10448, 10826
.   : milestone, 10637,
profiling (8.771 ms) : 8632, 8911
.   : milestone, 8771,
tracing (7.386 ms) : 7271, 7502
.   : milestone, 7386,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.372 ms [4.32 ms, 4.424 ms] -
iast 9.214 ms [9.058 ms, 9.37 ms] 4.842 ms (110.7%)
iast_FULL 14.178 ms [13.899 ms, 14.457 ms] 9.806 ms (224.3%)
iast_GLOBAL 10.426 ms [10.241 ms, 10.611 ms] 6.054 ms (138.5%)
profiling 8.987 ms [8.826 ms, 9.149 ms] 4.615 ms (105.6%)
tracing 7.435 ms [7.328 ms, 7.542 ms] 3.063 ms (70.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.247 ms [4.196 ms, 4.297 ms] -
iast 9.378 ms [9.228 ms, 9.528 ms] 5.131 ms (120.8%)
iast_FULL 14.103 ms [13.819 ms, 14.388 ms] 9.857 ms (232.1%)
iast_GLOBAL 10.637 ms [10.448 ms, 10.826 ms] 6.39 ms (150.5%)
profiling 8.771 ms [8.632 ms, 8.911 ms] 4.525 ms (106.5%)
tracing 7.386 ms [7.271 ms, 7.502 ms] 3.14 ms (73.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/environment-step4
git_commit_date 1751559115 1751559856
git_commit_sha 33422a3 e1aa51e
release_version 1.51.0-SNAPSHOT~33422a3a65 1.51.0-SNAPSHOT~e1aa51eefc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1751561847 1751561847
ci_job_id 1012866925 1012866925
ci_pipeline_id 69590381 69590381
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-jje4ul8x 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-jje4ul8x 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (2.402 ms) : 2353, 2452
.   : milestone, 2402,
iast (2.197 ms) : 2134, 2259
.   : milestone, 2197,
iast_GLOBAL (2.234 ms) : 2172, 2296
.   : milestone, 2234,
profiling (2.056 ms) : 2005, 2107
.   : milestone, 2056,
tracing (2.002 ms) : 1954, 2050
.   : milestone, 2002,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.403 ms) : 2353, 2453
.   : milestone, 2403,
iast (2.192 ms) : 2130, 2254
.   : milestone, 2192,
iast_GLOBAL (2.225 ms) : 2162, 2287
.   : milestone, 2225,
profiling (2.495 ms) : 2319, 2671
.   : milestone, 2495,
tracing (2.011 ms) : 1963, 2060
.   : milestone, 2011,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.469 ms, 1.492 ms] -
appsec 2.402 ms [2.353 ms, 2.452 ms] 921.401 µs (62.2%)
iast 2.197 ms [2.134 ms, 2.259 ms] 715.95 µs (48.3%)
iast_GLOBAL 2.234 ms [2.172 ms, 2.296 ms] 753.087 µs (50.9%)
profiling 2.056 ms [2.005 ms, 2.107 ms] 575.135 µs (38.8%)
tracing 2.002 ms [1.954 ms, 2.05 ms] 521.446 µs (35.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.403 ms [2.353 ms, 2.453 ms] 928.518 µs (63.0%)
iast 2.192 ms [2.13 ms, 2.254 ms] 717.938 µs (48.7%)
iast_GLOBAL 2.225 ms [2.162 ms, 2.287 ms] 750.14 µs (50.9%)
profiling 2.495 ms [2.319 ms, 2.671 ms] 1.021 ms (69.2%)
tracing 2.011 ms [1.963 ms, 2.06 ms] 536.86 µs (36.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.982 s) : 14982000, 14982000
.   : milestone, 14982000,
appsec (14.793 s) : 14793000, 14793000
.   : milestone, 14793000,
iast (18.488 s) : 18488000, 18488000
.   : milestone, 18488000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
.   : milestone, 17982000,
profiling (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
tracing (14.552 s) : 14552000, 14552000
.   : milestone, 14552000,
section candidate
no_agent (15.519 s) : 15519000, 15519000
.   : milestone, 15519000,
appsec (14.847 s) : 14847000, 14847000
.   : milestone, 14847000,
iast (18.527 s) : 18527000, 18527000
.   : milestone, 18527000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
.   : milestone, 18073000,
profiling (15.584 s) : 15584000, 15584000
.   : milestone, 15584000,
tracing (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.982 s [14.982 s, 14.982 s] -
appsec 14.793 s [14.793 s, 14.793 s] -189.0 ms (-1.3%)
iast 18.488 s [18.488 s, 18.488 s] 3.506 s (23.4%)
iast_GLOBAL 17.982 s [17.982 s, 17.982 s] 3.0 s (20.0%)
profiling 15.21 s [15.21 s, 15.21 s] 228.0 ms (1.5%)
tracing 14.552 s [14.552 s, 14.552 s] -430.0 ms (-2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.519 s [15.519 s, 15.519 s] -
appsec 14.847 s [14.847 s, 14.847 s] -672.0 ms (-4.3%)
iast 18.527 s [18.527 s, 18.527 s] 3.008 s (19.4%)
iast_GLOBAL 18.073 s [18.073 s, 18.073 s] 2.554 s (16.5%)
profiling 15.584 s [15.584 s, 15.584 s] 65.0 ms (0.4%)
tracing 15.09 s [15.09 s, 15.09 s] -429.0 ms (-2.8%)

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested changes Jul 3, 2025
View reviewed changes
dd-java-agent/agent-profiling/profiling-controller/build.gradle Outdated
api libs.slf4j
api project(':internal-api')
api project(':dd-java-agent:agent-profiling:profiling-utils')
implementation project(':components:environment')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that this should be implementation, not api.
Previous Platform is inside internal-api that declared as api.
Probably make sense to double check all similar places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. :components:environment is already exposed as part of the :internal-api API.
So it should not be needed here.

I checked the others two dd-java-agent/agent-profiling/profiling-controller-jfr/implementation and dd-java-agent/agent-profiling/profiling-utils that do need it though.

Base automatically changed from bbujon/environment-step3 to master July 3, 2025 16:11
@PerfectSlayer PerfectSlayer force-pushed the bbujon/environment-step4 branch from f3e2b77 to 7d59d7a Compare July 3, 2025 16:14
@PerfectSlayer PerfectSlayer marked this pull request as ready for review July 3, 2025 16:14
@PerfectSlayer PerfectSlayer requested review from a team as code owners July 3, 2025 16:14
@PerfectSlayer PerfectSlayer requested review from Mariovido, sezen-datadog, bric3 and dougqh and removed request for a team July 3, 2025 16:14
@PerfectSlayer PerfectSlayer force-pushed the bbujon/environment-step4 branch from 7d59d7a to e1aa51e Compare July 3, 2025 16:24
@PerfectSlayer PerfectSlayer merged commit dd59589 into master Jul 4, 2025
515 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/environment-step4 branch July 4, 2025 03:45
@github-actions github-actions bot added this to the 1.51.0 milestone Jul 4, 2025
This was referenced Jul 4, 2025
Merged
Merged
This was referenced Jul 17, 2025
Merged
Merged
@PerfectSlayer PerfectSlayer mentioned this pull request Jul 17, 2025
Merged
This was referenced Aug 1, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/ci-app-libraries-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@bric3 bric3 Awaiting requested review from bric3 bric3 is a code owner automatically assigned from DataDog/apm-lang-platform-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: platform Platform components tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @AlexeyKuznetsov-DD