-
Notifications
You must be signed in to change notification settings - Fork 312
Improve tag propagation between test event levels #9278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050145
Total [baseline] (8.58 s) : 0, 8579675
Agent [candidate] (1.046 s) : 0, 1045818
Total [candidate] (8.597 s) : 0, 8597200
section iast
Agent [baseline] (1.187 s) : 0, 1186717
Total [baseline] (9.328 s) : 0, 9327889
Agent [candidate] (1.173 s) : 0, 1173087
Total [candidate] (9.38 s) : 0, 9379771
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (735.851 ms) : 0, 735851
BytebuddyAgent [candidate] (731.777 ms) : 0, 731777
GlobalTracer [baseline] (243.008 ms) : 0, 243008
GlobalTracer [candidate] (242.141 ms) : 0, 242141
AppSec [baseline] (30.21 ms) : 0, 30210
AppSec [candidate] (30.09 ms) : 0, 30090
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (645.527 µs) : 0, 646
Remote Config [candidate] (657.094 µs) : 0, 657
Telemetry [baseline] (11.991 ms) : 0, 11991
Telemetry [candidate] (12.731 ms) : 0, 12731
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (859.806 ms) : 0, 859806
BytebuddyAgent [candidate] (847.23 ms) : 0, 847230
GlobalTracer [baseline] (232.032 ms) : 0, 232032
GlobalTracer [candidate] (230.715 ms) : 0, 230715
AppSec [baseline] (27.125 ms) : 0, 27125
AppSec [candidate] (26.53 ms) : 0, 26530
Debugger [baseline] (6.706 ms) : 0, 6706
Debugger [candidate] (6.713 ms) : 0, 6713
Remote Config [baseline] (589.246 µs) : 0, 589
Remote Config [candidate] (586.33 µs) : 0, 586
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (8.182 ms) : 0, 8182
IAST [baseline] (29.808 ms) : 0, 29808
IAST [candidate] (30.82 ms) : 0, 30820
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040664
Total [baseline] (10.668 s) : 0, 10667826
Agent [candidate] (1.044 s) : 0, 1043621
Total [candidate] (10.715 s) : 0, 10714595
section appsec
Agent [baseline] (1.221 s) : 0, 1220510
Total [baseline] (10.769 s) : 0, 10769077
Agent [candidate] (1.234 s) : 0, 1234435
Total [candidate] (10.843 s) : 0, 10842641
section iast
Agent [baseline] (1.175 s) : 0, 1174850
Total [baseline] (10.923 s) : 0, 10922965
Agent [candidate] (1.173 s) : 0, 1172591
Total [candidate] (10.837 s) : 0, 10836918
section profiling
Agent [baseline] (1.199 s) : 0, 1199129
Total [baseline] (10.869 s) : 0, 10868889
Agent [candidate] (1.193 s) : 0, 1193112
Total [candidate] (10.885 s) : 0, 10885425
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (729.633 ms) : 0, 729633
BytebuddyAgent [candidate] (732.098 ms) : 0, 732098
GlobalTracer [baseline] (240.879 ms) : 0, 240879
GlobalTracer [candidate] (241.978 ms) : 0, 241978
AppSec [baseline] (29.926 ms) : 0, 29926
AppSec [candidate] (30.006 ms) : 0, 30006
Debugger [baseline] (6.014 ms) : 0, 6014
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (658.138 µs) : 0, 658
Remote Config [candidate] (649.484 µs) : 0, 649
Telemetry [baseline] (11.146 ms) : 0, 11146
Telemetry [candidate] (9.763 ms) : 0, 9763
section appsec
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (754.142 ms) : 0, 754142
BytebuddyAgent [candidate] (763.656 ms) : 0, 763656
GlobalTracer [baseline] (235.598 ms) : 0, 235598
GlobalTracer [candidate] (237.547 ms) : 0, 237547
AppSec [baseline] (170.235 ms) : 0, 170235
AppSec [candidate] (170.395 ms) : 0, 170395
Debugger [baseline] (5.702 ms) : 0, 5702
Debugger [candidate] (7.215 ms) : 0, 7215
Remote Config [baseline] (611.759 µs) : 0, 612
Remote Config [candidate] (621.603 µs) : 0, 622
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (8.253 ms) : 0, 8253
IAST [baseline] (23.562 ms) : 0, 23562
IAST [candidate] (23.991 ms) : 0, 23991
section iast
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (848.629 ms) : 0, 848629
BytebuddyAgent [candidate] (846.793 ms) : 0, 846793
GlobalTracer [baseline] (231.682 ms) : 0, 231682
GlobalTracer [candidate] (231.266 ms) : 0, 231266
AppSec [baseline] (25.337 ms) : 0, 25337
AppSec [candidate] (27.826 ms) : 0, 27826
Debugger [baseline] (7.408 ms) : 0, 7408
Debugger [candidate] (6.662 ms) : 0, 6662
Remote Config [baseline] (588.078 µs) : 0, 588
Remote Config [candidate] (593.834 µs) : 0, 594
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (8.901 ms) : 0, 8901
IAST [baseline] (30.61 ms) : 0, 30610
IAST [candidate] (28.119 ms) : 0, 28119
section profiling
ProfilingAgent [baseline] (108.284 ms) : 0, 108284
ProfilingAgent [candidate] (107.475 ms) : 0, 107475
crashtracking [baseline] (1.411 ms) : 0, 1411
crashtracking [candidate] (1.399 ms) : 0, 1399
BytebuddyAgent [baseline] (764.7 ms) : 0, 764700
BytebuddyAgent [candidate] (760.365 ms) : 0, 760365
GlobalTracer [baseline] (222.622 ms) : 0, 222622
GlobalTracer [candidate] (221.512 ms) : 0, 221512
AppSec [baseline] (30.246 ms) : 0, 30246
AppSec [candidate] (29.921 ms) : 0, 29921
Debugger [baseline] (6.245 ms) : 0, 6245
Debugger [candidate] (6.277 ms) : 0, 6277
Remote Config [baseline] (681.543 µs) : 0, 682
Remote Config [candidate] (673.52 µs) : 0, 674
Telemetry [baseline] (15.238 ms) : 0, 15238
Telemetry [candidate] (16.02 ms) : 0, 16020
Profiling [baseline] (108.933 ms) : 0, 108933
Profiling [candidate] (108.127 ms) : 0, 108127
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section baseline
no_agent (4.226 ms) : 4176, 4276
. : milestone, 4226,
iast (9.393 ms) : 9234, 9551
. : milestone, 9393,
iast_FULL (13.566 ms) : 13293, 13840
. : milestone, 13566,
iast_GLOBAL (9.592 ms) : 9426, 9759
. : milestone, 9592,
profiling (8.122 ms) : 7986, 8257
. : milestone, 8122,
tracing (7.452 ms) : 7339, 7564
. : milestone, 7452,
section candidate
no_agent (4.473 ms) : 4422, 4524
. : milestone, 4473,
iast (9.357 ms) : 9205, 9510
. : milestone, 9357,
iast_FULL (14.136 ms) : 13854, 14418
. : milestone, 14136,
iast_GLOBAL (10.513 ms) : 10321, 10706
. : milestone, 10513,
profiling (8.652 ms) : 8520, 8785
. : milestone, 8652,
tracing (7.507 ms) : 7403, 7612
. : milestone, 7507,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section baseline
no_agent (37.247 ms) : 36952, 37541
. : milestone, 37247,
appsec (49.217 ms) : 48781, 49652
. : milestone, 49217,
code_origins (44.137 ms) : 43776, 44498
. : milestone, 44137,
iast (45.073 ms) : 44681, 45464
. : milestone, 45073,
profiling (48.424 ms) : 47931, 48916
. : milestone, 48424,
tracing (44.049 ms) : 43675, 44423
. : milestone, 44049,
section candidate
no_agent (37.046 ms) : 36745, 37347
. : milestone, 37046,
appsec (47.259 ms) : 46843, 47675
. : milestone, 47259,
code_origins (44.456 ms) : 44074, 44839
. : milestone, 44456,
iast (45.545 ms) : 45161, 45929
. : milestone, 45545,
profiling (44.718 ms) : 44311, 45125
. : milestone, 44718,
tracing (44.599 ms) : 44216, 44981
. : milestone, 44599,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section baseline
no_agent (15.071 s) : 15071000, 15071000
. : milestone, 15071000,
appsec (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
iast (19.039 s) : 19039000, 19039000
. : milestone, 19039000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
. : milestone, 18067000,
profiling (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
tracing (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
iast (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
profiling (15.894 s) : 15894000, 15894000
. : milestone, 15894000,
tracing (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~d738f842d8, baseline=1.52.0-SNAPSHOT~d7684b9449
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.678 ms) : 3462, 3894
. : milestone, 3678,
iast (2.211 ms) : 2149, 2274
. : milestone, 2211,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.092 ms) : 2039, 2145
. : milestone, 2092,
tracing (2.022 ms) : 1974, 2071
. : milestone, 2022,
section candidate
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (3.614 ms) : 3402, 3825
. : milestone, 3614,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.249 ms) : 2186, 2312
. : milestone, 2249,
profiling (2.489 ms) : 2322, 2657
. : milestone, 2489,
tracing (2.028 ms) : 1980, 2076
. : milestone, 2028,
|
Code coverage: total 57.21%, base diff 0.07%, patch 82.54% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: d738f84 | Docs | Was this helpful? Give us feedback! |
Let's rewrite |
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
null
, instead of checking for both name and version beingnull
.Motivation
Although very rarely, we have seen issues where propagated tags don't have the expected values (like
test.framework=null
andtest.framework_version!=null
). We suspect this is caused by race conditions on the tag propagation. Hopefully these changes help alleviate the problem.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]