-
Notifications
You must be signed in to change notification settings - Fork 312
Enable process level tags for java 21 applications #9458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable process level tags for java 21 applications #9458
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: f5b5f3a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 15 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056982
Total [baseline] (8.638 s) : 0, 8638440
Agent [candidate] (1.049 s) : 0, 1049123
Total [candidate] (8.651 s) : 0, 8651362
section iast
Agent [baseline] (1.183 s) : 0, 1182887
Total [baseline] (9.382 s) : 0, 9382350
Agent [candidate] (1.183 s) : 0, 1183310
Total [candidate] (9.331 s) : 0, 9331281
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (738.697 ms) : 0, 738697
BytebuddyAgent [candidate] (734.957 ms) : 0, 734957
GlobalTracer [baseline] (244.321 ms) : 0, 244321
GlobalTracer [candidate] (243.142 ms) : 0, 243142
AppSec [baseline] (30.427 ms) : 0, 30427
AppSec [candidate] (30.222 ms) : 0, 30222
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (680.372 µs) : 0, 680
Remote Config [candidate] (682.321 µs) : 0, 682
Telemetry [baseline] (14.061 ms) : 0, 14061
Telemetry [candidate] (11.517 ms) : 0, 11517
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (853.905 ms) : 0, 853905
BytebuddyAgent [candidate] (854.773 ms) : 0, 854773
GlobalTracer [baseline] (236.029 ms) : 0, 236029
GlobalTracer [candidate] (234.343 ms) : 0, 234343
AppSec [baseline] (26.357 ms) : 0, 26357
AppSec [candidate] (27.505 ms) : 0, 27505
Debugger [baseline] (6.583 ms) : 0, 6583
Debugger [candidate] (5.714 ms) : 0, 5714
Remote Config [baseline] (618.564 µs) : 0, 619
Remote Config [candidate] (702.416 µs) : 0, 702
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.329 ms) : 0, 8329
IAST [baseline] (28.602 ms) : 0, 28602
IAST [candidate] (29.289 ms) : 0, 29289
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044065
Total [baseline] (10.654 s) : 0, 10654324
Agent [candidate] (1.051 s) : 0, 1050889
Total [candidate] (10.688 s) : 0, 10687704
section appsec
Agent [baseline] (1.225 s) : 0, 1224893
Total [baseline] (10.761 s) : 0, 10761066
Agent [candidate] (1.222 s) : 0, 1221985
Total [candidate] (10.794 s) : 0, 10794135
section iast
Agent [baseline] (1.18 s) : 0, 1179932
Total [baseline] (10.912 s) : 0, 10912331
Agent [candidate] (1.192 s) : 0, 1192149
Total [candidate] (10.955 s) : 0, 10954672
section profiling
Agent [baseline] (1.201 s) : 0, 1200718
Total [baseline] (10.913 s) : 0, 10913358
Agent [candidate] (1.202 s) : 0, 1202339
Total [candidate] (10.936 s) : 0, 10935794
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (732.745 ms) : 0, 732745
BytebuddyAgent [candidate] (735.169 ms) : 0, 735169
GlobalTracer [baseline] (242.707 ms) : 0, 242707
GlobalTracer [candidate] (243.404 ms) : 0, 243404
AppSec [baseline] (30.024 ms) : 0, 30024
AppSec [candidate] (30.069 ms) : 0, 30069
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (670.19 µs) : 0, 670
Remote Config [candidate] (683.832 µs) : 0, 684
Telemetry [baseline] (9.279 ms) : 0, 9279
Telemetry [candidate] (12.936 ms) : 0, 12936
section appsec
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (757.182 ms) : 0, 757182
BytebuddyAgent [candidate] (754.517 ms) : 0, 754517
GlobalTracer [baseline] (235.691 ms) : 0, 235691
GlobalTracer [candidate] (235.237 ms) : 0, 235237
AppSec [baseline] (171.064 ms) : 0, 171064
AppSec [candidate] (169.025 ms) : 0, 169025
Debugger [baseline] (5.702 ms) : 0, 5702
Debugger [candidate] (7.259 ms) : 0, 7259
Remote Config [baseline] (629.318 µs) : 0, 629
Remote Config [candidate] (632.556 µs) : 0, 633
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (9.178 ms) : 0, 9178
IAST [baseline] (23.474 ms) : 0, 23474
IAST [candidate] (23.552 ms) : 0, 23552
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (851.532 ms) : 0, 851532
BytebuddyAgent [candidate] (861.306 ms) : 0, 861306
GlobalTracer [baseline] (233.186 ms) : 0, 233186
GlobalTracer [candidate] (234.69 ms) : 0, 234690
AppSec [baseline] (26.495 ms) : 0, 26495
AppSec [candidate] (28.762 ms) : 0, 28762
Debugger [baseline] (5.778 ms) : 0, 5778
Debugger [candidate] (6.703 ms) : 0, 6703
Remote Config [baseline] (600.723 µs) : 0, 601
Remote Config [candidate] (615.331 µs) : 0, 615
Telemetry [baseline] (9.309 ms) : 0, 9309
Telemetry [candidate] (8.42 ms) : 0, 8420
IAST [baseline] (30.424 ms) : 0, 30424
IAST [candidate] (28.951 ms) : 0, 28951
section profiling
ProfilingAgent [baseline] (108.43 ms) : 0, 108430
ProfilingAgent [candidate] (108.999 ms) : 0, 108999
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (764.603 ms) : 0, 764603
BytebuddyAgent [candidate] (764.367 ms) : 0, 764367
GlobalTracer [baseline] (223.029 ms) : 0, 223029
GlobalTracer [candidate] (223.264 ms) : 0, 223264
AppSec [baseline] (30.81 ms) : 0, 30810
AppSec [candidate] (30.211 ms) : 0, 30211
Debugger [baseline] (6.235 ms) : 0, 6235
Debugger [candidate] (6.349 ms) : 0, 6349
Remote Config [baseline] (730.547 µs) : 0, 731
Remote Config [candidate] (727.085 µs) : 0, 727
Telemetry [baseline] (14.979 ms) : 0, 14979
Telemetry [candidate] (16.316 ms) : 0, 16316
Profiling [baseline] (109.073 ms) : 0, 109073
Profiling [candidate] (109.661 ms) : 0, 109661
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (4.488 ms) : 4436, 4540
. : milestone, 4488,
iast (9.42 ms) : 9259, 9580
. : milestone, 9420,
iast_FULL (13.824 ms) : 13551, 14097
. : milestone, 13824,
iast_GLOBAL (10.641 ms) : 10449, 10834
. : milestone, 10641,
profiling (8.934 ms) : 8791, 9077
. : milestone, 8934,
tracing (7.479 ms) : 7375, 7582
. : milestone, 7479,
section candidate
no_agent (4.205 ms) : 4159, 4252
. : milestone, 4205,
iast (9.741 ms) : 9578, 9904
. : milestone, 9741,
iast_FULL (14.386 ms) : 14099, 14672
. : milestone, 14386,
iast_GLOBAL (10.445 ms) : 10261, 10629
. : milestone, 10445,
profiling (8.646 ms) : 8499, 8793
. : milestone, 8646,
tracing (7.713 ms) : 7599, 7828
. : milestone, 7713,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (36.611 ms) : 36323, 36899
. : milestone, 36611,
appsec (45.7 ms) : 45303, 46097
. : milestone, 45700,
code_origins (46.269 ms) : 45858, 46680
. : milestone, 46269,
iast (42.412 ms) : 42043, 42781
. : milestone, 42412,
profiling (48.031 ms) : 47582, 48480
. : milestone, 48031,
tracing (44.991 ms) : 44593, 45389
. : milestone, 44991,
section candidate
no_agent (36.904 ms) : 36614, 37194
. : milestone, 36904,
appsec (48.296 ms) : 47878, 48713
. : milestone, 48296,
code_origins (46.21 ms) : 45816, 46605
. : milestone, 46210,
iast (44.88 ms) : 44492, 45269
. : milestone, 44880,
profiling (48.085 ms) : 47640, 48531
. : milestone, 48085,
tracing (44.221 ms) : 43846, 44596
. : milestone, 44221,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
appsec (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (17.777 s) : 17777000, 17777000
. : milestone, 17777000,
profiling (16.011 s) : 16011000, 16011000
. : milestone, 16011000,
tracing (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
section candidate
no_agent (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
appsec (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
iast (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
iast_GLOBAL (17.578 s) : 17578000, 17578000
. : milestone, 17578000,
profiling (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
tracing (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f5b5f3a016, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.637 ms) : 3419, 3856
. : milestone, 3637,
iast (2.19 ms) : 2127, 2252
. : milestone, 2190,
iast_GLOBAL (2.246 ms) : 2182, 2310
. : milestone, 2246,
profiling (2.06 ms) : 2008, 2112
. : milestone, 2060,
tracing (2.013 ms) : 1964, 2063
. : milestone, 2013,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.402 ms) : 2352, 2452
. : milestone, 2402,
iast (2.185 ms) : 2123, 2248
. : milestone, 2185,
iast_GLOBAL (2.232 ms) : 2169, 2295
. : milestone, 2232,
profiling (2.036 ms) : 1985, 2087
. : milestone, 2036,
tracing (2.012 ms) : 1963, 2061
. : milestone, 2012,
|
dd12e29
to
982e929
Compare
982e929
to
f5b5f3a
Compare
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
Enable process level tags by default for customer using java 21
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]