Skip to content

tests(logging): don't test warn #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2020
Merged

tests(logging): don't test warn #1738

merged 2 commits into from
Oct 22, 2020

Conversation

Kyle-Verhoog
Copy link
Member

Description

warn is deprecated and generates a ton of noise in our CI:
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/3123/workflows/da4f5a5f-e4bd-4555-8977-28b607448b70/jobs/361625

And we're sufficiently covered by testing all the other possible log methods.

@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner October 20, 2020 03:15
@Kyle-Verhoog Kyle-Verhoog added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 20, 2020
majorgreys
majorgreys previously approved these changes Oct 21, 2020
View reviewed changes
@majorgreys majorgreys merged commit 730b6e9 into master Oct 22, 2020
@majorgreys majorgreys deleted the kyle-verhoog/warn branch October 22, 2020 15:33
Czechh added a commit that referenced this pull request Oct 23, 2020
@Czechh
Merge branch 'master' into sergio.prada/inject-trace-data-in-lambda-i…
120feb6 
…nvocations

* master:
  ci: introduce riot, use it to run tracer tests (#1737)
  fix(django): add check for instrument view mro (#1744)
  fix: snapshot decorator for pytest fixtures (#1743)
  tests(logging): don't test warn (#1738)
  feat(flask): store request headers (#1735)
  ci: fix deploy_master (#1739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majorgreys majorgreys majorgreys approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Verhoog @majorgreys