Skip to content

feat(flask): store request headers #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 21, 2020
Merged

feat(flask): store request headers #1735

merged 12 commits into from
Oct 21, 2020

Conversation

Isabella-Pham
Copy link
Contributor

@Isabella-Pham Isabella-Pham commented Oct 19, 2020 •
edited
Loading

Description

Current Flask integration does not store request headers
closes #1707

Checklist

  • call store_request_headers() in Flask middleware
  • create http_request_header_tracing test
  • add storing request headers to integration template checklist

@Isabella-Pham Isabella-Pham self-assigned this Oct 19, 2020
Kyle-Verhoog
Kyle-Verhoog reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's add a test case to make sure it works 🙂

Kyle-Verhoog
Kyle-Verhoog previously approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Kyle-Verhoog
Kyle-Verhoog reviewed Oct 20, 2020
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a changelog entry and we're good to go!

Kyle-Verhoog
Kyle-Verhoog previously approved these changes Oct 21, 2020
View reviewed changes
@Kyle-Verhoog Kyle-Verhoog added this to the 0.44.0 milestone Oct 21, 2020
@Kyle-Verhoog Kyle-Verhoog marked this pull request as ready for review October 21, 2020 18:13
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner October 21, 2020 18:13
@Isabella-Pham Isabella-Pham merged commit 50db685 into master Oct 21, 2020
@Isabella-Pham Isabella-Pham deleted the Isabella-Pham/Flask-store-request-headers branch October 21, 2020 18:45
Czechh added a commit that referenced this pull request Oct 23, 2020
@Czechh
Merge branch 'master' into sergio.prada/inject-trace-data-in-lambda-i…
120feb6 
…nvocations

* master:
  ci: introduce riot, use it to run tracer tests (#1737)
  fix(django): add check for instrument view mro (#1744)
  fix: snapshot decorator for pytest fixtures (#1743)
  tests(logging): don't test warn (#1738)
  feat(flask): store request headers (#1735)
  ci: fix deploy_master (#1739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

Assignees

@Isabella-Pham Isabella-Pham

Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.

Flask support doesn't call store_request_headers
2 participants
@Isabella-Pham @Kyle-Verhoog