Skip to content

Posix: fix build failure #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2021
Merged

Posix: fix build failure #235

merged 2 commits into from
Jan 8, 2021

Conversation

twpedersen
Copy link
Contributor

@twpedersen twpedersen commented Dec 17, 2020 •
edited
Loading

Fixes: a48f137 ("Posix Port: Comment and remove unused variables (#230)")

The above commit introduced the compile error:

/FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c: In function ‘prvSetupSignalsAndSchedulerPolicy’:
/FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:528:28: error: incompatible type for argument 3 of ‘pthread_sigmask’
                            *&xSchedulerOriginalSignalMask );
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/signal.h:359,
                 from FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:53:
/usr/include/x86_64-linux-gnu/bits/sigthread.h:33:31: note: expected ‘__sigset_t * restrict’ {aka ‘struct <anonymous> * restrict’} but argument is of type ‘sigset_t’ {aka ‘struct <anonymous>’}
        __sigset_t *__restrict __oldmask)__THROW;

@twpedersen
Posix: fix build failure
3856a82 
Fixes: a48f137 ("Posix Port: Comment and remove unused variables (FreeRTOS#230)")

The above commit introduced the compile error:

/FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c: In function ‘prvSetupSignalsAndSchedulerPolicy’:
/FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:528:28: error: incompatible type for argument 3 of ‘pthread_sigmask’
                            *&xSchedulerOriginalSignalMask );
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/signal.h:359,
                 from FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:53:
/usr/include/x86_64-linux-gnu/bits/sigthread.h:33:31: note: expected ‘__sigset_t * restrict’ {aka ‘struct <anonymous> * restrict’} but argument is of type ‘sigset_t’ {aka ‘struct <anonymous>’}
        __sigset_t *__restrict __oldmask)__THROW;
@twpedersen twpedersen requested a review from a team as a code owner December 17, 2020 22:55
@twpedersen
Copy link
Contributor Author

What is the failing check?

File Delta: portable/ThirdParty/GCC/Posix/port.c
11
--- 
12
 +++ 
13
 @@ -1,5 +1,5 @@
14
  /*
15
 - * FreeRTOS Kernel V10.4.3
16
 + * FreeRTOS Kernel V10.4.2
17
   * Copyright (C) 2020 Amazon.com, Inc. or its affiliates.  All Rights Reserved.
18
   *
19
   * Permission is hereby granted, free of charge, to any person obtaining a copy of
20

@dachalco
Copy link
Contributor

Hi @twpedersen

A subset of the repo's files require a FreeRTOS Kernel Header (version + copyright + license).
During a PR we make sure these files remain consistent and up to date.
I merged upstream/main so it would use the recently updated check and the check passes.

@twpedersen
Copy link
Contributor Author

Thank you.

@twpedersen
Copy link
Contributor Author

@alfred2g @cobusve can you please take a look?

@twpedersen
Copy link
Contributor Author

is there no interest in fixing a build failure in the LTS release, or am I the only one seeing this?

@alfred2g
Copy link
Contributor

alfred2g commented Jan 8, 2021

/bot run checks

@alfred2g
Copy link
Contributor

alfred2g commented Jan 8, 2021

@alfred2g @cobusve can you please take a look?

we have 3 similar PR's, we are fixing an issue with the checks, I will ask so they are overridden.
Thanks for the PR :)

@cobusve cobusve merged commit 23f6418 into FreeRTOS:main Jan 8, 2021
This was referenced Jan 8, 2021
Closed
Closed
@twpedersen
Copy link
Contributor Author

Thanks guys 🙏

@muneebahmed10 muneebahmed10 mentioned this pull request Mar 26, 2021
Closed
kstribrnAmzn added a commit to kstribrnAmzn/FreeRTOS-Kernel that referenced this pull request Apr 20, 2022
@kstribrnAmzn
Fix POSIX port build error
b49ca4d 
Fixing pointer prefix misshap similar to
FreeRTOS#235'
for our 2020-12 release.

Issue - https://forums.freertos.org/t/posix-port-compile-issues/11323
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
@alfred2g
Build: replace scons with makefile (FreeRTOS#235)
6b502b5 
* Build: transform scons into Makefile
* Build: add Makefile dependencies
* Build: remove some tabs from Makefile
* Build: Make builds out of source, move wait for event to kernel port
* Test: update the full test to print status messages
* Build: replace lpthread with pthread

Co-authored-by: Alfred Gedeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfred2g alfred2g alfred2g approved these changes

@cobusve cobusve cobusve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twpedersen @dachalco @alfred2g @cobusve