Skip to content

fix pthread_sigmask 3 arg type #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

marcinbor85
Copy link

@marcinbor85 marcinbor85 commented Mar 25, 2021

Error message

FreeRTOS-Kernel/portable/ThirdParty/GCC/Posix/port.c:528:28: error: incompatible type for argument 3 of ‘pthread_sigmask’
528 | *&xSchedulerOriginalSignalMask );
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| sigset_t
In file included from /usr/include/signal.h:362,
from FreeRTOS-Kernel/portable/ThirdParty/GCC/Posix/port.c:53:
/usr/include/bits/sigthread.h:33:31: note: expected ‘__sigset_t * restrict’ but argument is of type ‘sigset_t’
33 | __sigset_t *__restrict __oldmask)__THROW;
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~

Environment

Linux 5.10.4-arch2-1
gcc (GCC) 10.2.0
/usr/lib/libpthread-2.32.so: ELF 64-bit LSB shared object, x86-64

@marcinbor85 marcinbor85 requested a review from a team as a code owner March 25, 2021 22:12
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #295 (d3484f4) into main (9b679c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #295   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           37        37           
  Branches         3         3           
=========================================
  Hits            37        37           
Flag Coverage Δ
unittests 100.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b679c3...d3484f4. Read the comment docs.

@muneebahmed10
Copy link
Contributor

Hi @marcinbor85,

Thank you for creating this PR! Can you rebase your branch with the latest main?

@marcinbor85
Copy link
Author

done

@muneebahmed10
Copy link
Contributor

Hi @marcinbor85,

It looks like this issue was already fixed in #235. You should be able to build by pulling the latest commit from main.

Thank you

laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants