Skip to content

Feature/mchp updates #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

alexmchp
Copy link
Contributor

Updated portables for Microchip AVR Dx and Mega0

Description

  • Update AVR GCC port files (now the port.c and portmacro.h files are identical for AVR_Mega0 and AVR_Dx families)
  • Add support for low-power tickless mode in portable files for AVR_Dx and AVR_Mega0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexmchp alexmchp requested a review from a team as a code owner July 30, 2021 06:58
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #373 (2a8b0a3) into main (f8ada39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files           4        4           
  Lines        1272     1272           
  Branches      342      342           
=======================================
  Hits         1172     1172           
  Misses         53       53           
  Partials       47       47           
Flag Coverage Δ
unittests 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ada39...2a8b0a3. Read the comment docs.

@aggarg
Copy link
Member

aggarg commented Aug 5, 2021

Hi @alexmchp,

Thank you for your contribution. This FreeRTOS port falls into the category of "Partner Supported FreeRTOS Ports" as per the criteria recently published here. Accordingly, would you please move this port to the Partner Supported FreeRTOS Ports Repo. Similarly the FreeRTOS demo in this PR should be moved to Partner Supported FreeRTOS Demos Repo.

Let me know if you would like me to move these and I will be happy to do that.

Thanks.

@alexmchp
Copy link
Contributor Author

Hi @aggarg, Thanks for the update. I will make sure future changes are done in the correct locations. It would be awesome if this time you could move them to the appropriate repos?

@alexmchp
Copy link
Contributor Author

alexmchp commented Sep 7, 2021

Hi @aggarg , any update on this ?

@aggarg
Copy link
Member

aggarg commented Sep 7, 2021

Hi @alexmchp, Sorry it slipped my mind. Will look into it and update you.

aggarg added a commit to aggarg/FreeRTOS-Kernel-Partner-Supported-Ports that referenced this pull request Sep 9, 2021
- Update AVR GCC port files (now the port.c and portmacro.h files are
identical for AVR_Mega0 and AVR_Dx families).
- Add support for low-power tickless mode in portable files for AVR_Dx and
AVR_Mega0.

This change was originally contributed by alexmchp@ in the following PR:
FreeRTOS/FreeRTOS-Kernel#373
@aggarg
Copy link
Member

aggarg commented Sep 9, 2021

Hi @alexmchp, I moved the ports and opened this PR - FreeRTOS/FreeRTOS-Kernel-Partner-Supported-Ports#3

Please review and let me know if everything looks good.

aggarg added a commit to FreeRTOS/FreeRTOS-Kernel-Partner-Supported-Ports that referenced this pull request Sep 13, 2021
- Update AVR GCC port files (now the port.c and portmacro.h files are
identical for AVR_Mega0 and AVR_Dx families).
- Add support for low-power tickless mode in portable files for AVR_Dx and
AVR_Mega0.

This change was originally contributed by alexmchp@ in the following PR:
FreeRTOS/FreeRTOS-Kernel#373
@aggarg
Copy link
Member

aggarg commented Sep 13, 2021

I am closing this PR as I have merged the above. Please let me know if anything looks off.

@aggarg aggarg closed this Sep 13, 2021
@alexmchp
Copy link
Contributor Author

@aggarg thanks! awesome work!
what about this PR, can you move that too, or should we do it?

@aggarg
Copy link
Member

aggarg commented Sep 15, 2021

@alexmchp - With this PR, I have removed these ports from the original location and added a README telling their new location.

Would you please move the demo projects to https://github.com/FreeRTOS/FreeRTOS-Partner-Supported-Demos? You will need to update source path and include paths for the port files.

Thanks.

@mchpcristianpop
Copy link

@aggarg - I've created a new PR to https://github.com/FreeRTOS/FreeRTOS-Partner-Supported-Demos. The projects are now updated to new structure. Please let me know if anything else is needed

@aggarg
Copy link
Member

aggarg commented Nov 11, 2021

@mchpcristianpop Thank you for your contribution.

laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
TrongNguyenR pushed a commit to renesas/FreeRTOS-Kernel-Partner-Supported-Ports that referenced this pull request Oct 30, 2024
- Update AVR GCC port files (now the port.c and portmacro.h files are
identical for AVR_Mega0 and AVR_Dx families).
- Add support for low-power tickless mode in portable files for AVR_Dx and
AVR_Mega0.

This change was originally contributed by alexmchp@ in the following PR:
FreeRTOS/FreeRTOS-Kernel#373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants