Skip to content

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Apr 9, 2020

Description

GoldSrc servers were names variants of Gold Source. Using correct engine name GoldSrc

Fixes #2815

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

GoldSrc servers were names variants of Gold Source. Using correct engine name GoldSrc
@pull-assistant
Copy link

pull-assistant bot commented Apr 9, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: correct and standardise name of goldsrc engine

     Merge branch 'develop' into feature/goldsrc

Powered by Pull Assistant. Last update e0ca7df ... 54b7a63. Read the comment docs.

@dgibbs64 dgibbs64 added this to the v20.2.0 milestone Apr 9, 2020
@dgibbs64 dgibbs64 merged commit 773812a into develop Apr 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/goldsrc branch April 9, 2020 19:54
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant