Skip to content

Automatically scroll to the active page in table of contents #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

spastorelli
Copy link
Contributor

Before
e.g: https://docs.gitbook.com/account-management/sso-and-saml/sso-and-saml

Screen.Recording.2024-08-09.at.10.53.08.mov

After

Screen.Recording.2024-08-09.at.10.55.23.mov

Copy link

linear bot commented Aug 9, 2024

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 4f1253f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 08:58 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 09:02 Inactive
Copy link

argos-ci bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 45 changed, 4 added Dec 31, 2024, 11:14 PM

@spastorelli spastorelli marked this pull request as draft August 9, 2024 09:16
@spastorelli spastorelli changed the title Automatically scroll to the active page in table of contents wip: Automatically scroll to the active page in table of contents Aug 9, 2024
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 09:43 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 11:04 Inactive
@spastorelli spastorelli marked this pull request as ready for review August 9, 2024 11:05
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 11:06 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 11:07 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 9, 2024 11:08 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 13, 2024 09:59 Inactive
@spastorelli spastorelli requested a review from SamyPesse August 13, 2024 10:03
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 13, 2024 10:06 Inactive
@spastorelli spastorelli changed the title wip: Automatically scroll to the active page in table of contents Automatically scroll to the active page in table of contents Aug 13, 2024
@spastorelli spastorelli requested review from SamyPesse and removed request for SamyPesse August 13, 2024 20:20
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! minor comments on my side

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 15, 2024 09:23 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 15, 2024 09:24 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) August 15, 2024 09:25 Inactive
@spastorelli spastorelli merged commit 9f6c334 into main Aug 15, 2024
7 of 8 checks passed
@spastorelli spastorelli deleted the steeve/rnd-2147-automatically-scroll-to-the-current-page-in-table-of branch August 15, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants