RND-2147: automatically scroll TOC #2478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89b66f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
from
1d43ca5 to
cc9ac89
Compare
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
from
cc9ac89 to
7730dbc
Compare
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
from
7730dbc to
c1ee529
Compare
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
from
affd07e to
4efb2c2
Compare
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
2 times, most recently
from
deb1d89 to
f7fa8c6
Compare
BrettJephson
commented
Sep 24, 2024
spastorelli
approved these changes
Sep 24, 2024
gregberge
requested changes
Sep 24, 2024
packages/gitbook/src/components/TableOfContents/TOCScroller.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TOCScroller.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TOCScroller.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TOCScroller.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/TableOfContents/TOCScroller.tsx
Outdated
Show resolved
Hide resolved
BrettJephson
force-pushed
the
brett/RND-2147-scroll-toc
branch
from
bc31b1e to
d79a534
Compare
gregberge
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back the work @spastorelli did on automatically scrolling the TOC to current page (in #2425).
That work was rolled back due to a bug. Main fix is preventing multiple scroll triggers with a ref.
[Note/out-of-scope]: The difference in rendering of the TOC in localhost v prod is kind of concerning and should be investigated further. I'd expect a dev build to render more often but the toc items re-render a lot more in prod which is why scrolling issues were only picked up in prod.
I've been testing against the visual regression preview where I could replicate the issue, e.g. https://211cca89.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open