Skip to content

ppai/image-classification: use new model #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Jul 30, 2021

Description

Fixes #6502, #6503

Trained a new model to be used for these tests since the old one was deleted.

The new model is now named permanent_wildlife_classifier_DO_NOT_DELETE.

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner July 30, 2021 20:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2021
@leahecole
Copy link
Collaborator

Ugh - I'm so sorry @davidcavazos but after all of that model training, I don't see it in the project! I'm assuming it's in the python-docs-samples-tests project, but if not, let me know.

I don't think that any @GoogleCloudPlatform/python-samples-owners have been touching the Vertex AI models, but I wonder if something like the "reaper" that Luke Davis had used awhile ago could be silently deleting it? @vinnysenthil @dizcology @aribray, is there a job that runs and deletes models in the test project? Or were you only using such a tool in your Vertex AI team project?

@dandhlee
Copy link
Collaborator

dandhlee commented Aug 2, 2021

I remember @ivanmkc brought up a topic about cleaning up some stale/old/expensive looking test data sets on our project folder as well to lower the budget, perhaps it was deleted by then?

@davidcavazos
Copy link
Contributor Author

I think it got deleted, I had the new model called permanent_wildlife_classifier_DO_NOT_DELETE and tests were passing before. I thought the reaper ignored anything prefixed by perm, but maybe the rules are different.

@davidcavazos
Copy link
Contributor Author

@leahecole leahecole merged commit f0b3613 into GoogleCloudPlatform:master Aug 4, 2021
leahecole added a commit that referenced this pull request Aug 4, 2021
@davidcavazos
Copy link
Contributor Author

Updated PR: #6528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants