Skip to content

Pickers refactoring #9160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 94 commits into from
Apr 21, 2021
Merged

Pickers refactoring #9160

merged 94 commits into from
Apr 21, 2021

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Mar 16, 2021 •
edited by Lipata
Loading

Closes #6483
Closes #6482
Closes #6994
Closes #7169
Closes #7199
Closes #8665
Closes #6286
Closes #7196
Closes #6346
Closes #7173

Closes #8551
Closes #8567
Closes #8475
Closes #8065
Closes #6749
Closes #6925
Closes #5525
Closes #8613
Closes #8913
Closes #8919
Closes #9154
Closes #9189
Closes #9215
Closes #8548
Closes #9377

#8256

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

jackofdiamond5 and others added 30 commits January 25, 2021 11:13
@jackofdiamond5
feat(*): add PickersBaseDirective
b67f6af
@jackofdiamond5
Merge branch 'karma-coverage-master' of https://github.com/IgniteUI/i…
03d0e3e 
…gniteui-angular into bpenkov/pickers-base-parent
@jackofdiamond5
Merge branch 'master' into bpenkov/pickers-base-parent
0324abb
@kdinev @jackofdiamond5
Merge branch 'master' into bpenkov/pickers-base-parent
40c3aae
@jackofdiamond5
feat(date-time-editor): handling for wheel events
39513dc
@jackofdiamond5
feat(types): add new enum HeaderOrientation
8d7a38d
@jackofdiamond5
feat(date-time-editor): add preventSpeenOnWheel input
88320ef
@jackofdiamond5
feat(date-time-editor): can be set to suppress focus
4e14e07
@jackofdiamond5
feat(DatePickerUtils): add method for min/max validation
6efffd2
@kdinev
Merge branch 'master' into bpenkov/pickers-base-parent
d0422ee
@jackofdiamond5
refactor(CalendarContainer): move to date-utils
a6a5ecf
@jackofdiamond5
chore(date-picker): fix imports to calendar container
67630b6
@jackofdiamond5
feat(PickersBaseDirective): implements EditorProvider
e628eb5
@jackofdiamond5
Merge remote-tracking branch 'remotes/origin/bpenkov/pickers-base-par…
1cf27be 
…ent' into pickers-refactoring
@jackofdiamond5
chore(calendar-container): update click handler names
bfb4582
@jackofdiamond5
fix(date-time-editor): clear method updates mask properly
d6fb8d3
@jackofdiamond5
refactor(picker-icons): move picker icon components to date-common
12ac3ef
@jackofdiamond5
Merge branch 'master' into bpenkov/pickers-base-parent
9926d39
@jackofdiamond5
Merge remote-tracking branch 'remotes/origin/bpenkov/pickers-base-par…
1312e8f 
…ent' into pickers-refactoring
@jackofdiamond5
refactor(*): update comments & code clean up
49c4e88
@jackofdiamond5
fix(igx-input): add support for disabled attr without value
ea18284
@jackofdiamond5
fix(igxMask): prevent focus if input is readonly
8e2ef17
@jackofdiamond5
feat(date-time-editor): add option to set spin delta per part #7169 (#…
48506ff 
…8987)

spinDelta input and delta number arg to increment/decrement
@jackofdiamond5 @wnvko
refactor(date-range): pickers base, overlay service, template buttons…
a3538d7 
…, valueChange

Co-authored-by: wnvko <[email protected]>
@jackofdiamond5
refactor(DateTimeUtil): rename and move to date-common, clean up, add…
f99d888 
… tests (#9135)
@jackofdiamond5
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
cd9c387 
…into pickers-refactoring
@jackofdiamond5
refactor(date-picker): simplify templating, integrate date-time direc…
4e88243 
…tive

- clean and update public api
@jackofdiamond5
refactor(date-editor): make date part deltas optional
ace673d
@jackofdiamond5
refactor(date-editor): rename isSpinLoop to spinLoop
ddcc0dd
@jackofdiamond5
feat(date-editor): adjust input format based on locale if not set
0edc8d8
dafo and others added 17 commits April 21, 2021 11:19
@dafo
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
595485f 
…iteui-angular into pickers-refactoring
@dafo
test(date-picker): Adding a template to the spec
ee09f34
@jackofdiamond5
chore(date-picker): temporary xit tests
0c7e9f9
@damyanpetev
test(excel-filter): restore date custom formatter checks
691568e
test(date-picker): Add kbrd navigation tests
e38861e
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
fd61877 
…iteui-angular into pickers-refactoring
chore(date-picker): Comment out TODOs
033d5ad
@ViktorSlavov
test(date-picker): refactor date-picker API Unit tests,reorder sectio…
2e85dfb 
…ns in file
@PlamenaMiteva
refactor(time-picker): selectedDate to fall back to the closest possi…
6ccd884 
…ble value
@PlamenaMiteva
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
e2e75b2 
…iteui-angular into pickers-refactoring
@PlamenaMiteva
chore(pickers): fix lint errors
62c5d32
@damyanpetev
fix(picker-base): remove default box type
119df8c
@damyanpetev
fix(input): update input group focused state if disabled
5c15eaa 
While the input is focused, setting disabled will cause a blur,
which can happen in-between change detection checks and throw expression changed
@Lipata
docs(pickers): update changelog
fa29f6b
@Lipata
Merge branch 'master' into pickers-refactoring
64eb4b5
@ViktorSlavov
test(date-picker): move ngControlValueAccessor tests to integration s…
2359621 
…ection
@Lipata
docs(pickers): update changelog
dc3ad3e
@jackofdiamond5 jackofdiamond5 force-pushed the pickers-refactoring branch 2 times, most recently from ccc312d to ba46f1b Compare April 21, 2021 18:49
@ViktorSlavov ViktorSlavov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 21, 2021
@Lipata Lipata merged commit 403acdc into master Apr 21, 2021
@Lipata Lipata deleted the pickers-refactoring branch April 21, 2021 19:55
@ddincheva ddincheva mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev left review comments

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev damyanpetev approved these changes

@valadzhov valadzhov Awaiting requested review from valadzhov

Assignees

@valadzhov valadzhov

Labels
🕐 time-picker 📅 date-picker 📅 date-range-picker 📅 date-time-editor squash-merge Merge PR with "Squash and Merge" option version: 12.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
8 participants
@jackofdiamond5 @kdinev @Lipata @damyanpetev @valadzhov @ViktorSlavov @PlamenaMiteva @dafo