Skip to content

FONTSAMPLER display glyphs from bitmap font to PDF (retry) #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MattHeffron
Copy link
Contributor

Enable FONTSAMPLER to display glyphs from DISPLAYFONT (bitmap font) on non-DISPLAY stream (e.g., PDF)
Added .LCOM to repository.

Corrected PR.

…n non-DISPLAY stream (e.g., PDF)

Added .LCOM to repository.

Corrected PR.
@MattHeffron MattHeffron added the enhancement New feature or request label Feb 3, 2025
@MattHeffron MattHeffron self-assigned this Feb 3, 2025
@MattHeffron MattHeffron marked this pull request as draft February 3, 2025 20:00
@MattHeffron
Copy link
Contributor Author

Converted to Draft per 2025-02-03 discussion on Ascent/Descent per CHARSETINFO vs. whole FONTDESCRIPTOR to modify for this.

…FO vs. whole FONTDESCRIPTOR. (Use whole FONTDESCRIPTOR.)
@MattHeffron MattHeffron marked this pull request as ready for review February 4, 2025 04:15
@MattHeffron
Copy link
Contributor Author

I have no idea why git is saying that there are merge conflicts for those two files.
They are the only two files changed in either of the commits in this PR, and they seem to have been untouched on master since this branch was created.
How should this be fixed?

nbriggs
nbriggs previously approved these changes Feb 4, 2025
Copy link
Contributor

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in meeting Mon Feb 3, 2025

@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

It looks as though you or Ron may have merged a branch when (part of?) your FONTSAMPLER changes were present in the other branch? Have a look at the log entry for 86f5aad to 1f317d3 - co-authored by you and Ron.

The branch for this PR diverged from master at db9d879, your PR 1974, and then PR 2010 appears to have your FONTSAMPLER change where the .LCOM was added to the repo - since they're all binary files, it's unable to combine the changes in this branch with the changes that have been made to the same files since the branches diverged (which is a good thing!)

I haven't figured out how PR 2010 got to be the way it is/was.

@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

@MattHeffron - have a look at #2010 -- why did this have more than just the rename of the FONTSAMPLE files, and why did @masinter approve it given what was in it?

@MattHeffron
Copy link
Contributor Author

why did this have more than just the rename of the FONTSAMPLE files

That, I don't know. I thought that I was being pretty careful with only the correct files, but maybe I just missed something.
The important thing is how to fix this...or, should I just close this PR and copy the changes to a new branch from master and make a new PR?

@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

I can fix it using direct git commands. I'll do that.

@nbriggs nbriggs dismissed their stale review February 4, 2025 18:35

The merge-base changed after approval.

@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

Need re-review now.

@nbriggs nbriggs self-requested a review February 4, 2025 18:37
@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

@MattHeffron - I'm not 100% sure that this won't do damage. How about deleting this PR and resubmit it with only the two changed files lispusers/FONTSAMPLER and lispusers/FONTSAMPLER.LCOM

@nbriggs nbriggs marked this pull request as draft February 4, 2025 19:45
@MattHeffron
Copy link
Contributor Author

@MattHeffron - I'm not 100% sure that this won't do damage. How about deleting this PR and resubmit it with only the two changed files lispusers/FONTSAMPLER and lispusers/FONTSAMPLER.LCOM

I created new PR #2013. I'm closing this one.
(Hopefully, 3rd time's the charm!)

@MattHeffron MattHeffron closed this Feb 4, 2025
MattHeffron added a commit that referenced this pull request Feb 5, 2025
…& #2008 & #2013) (#2014)

Enable **FONTSAMPLER** to display glyphs from **.DISPLAYFONT** (bitmap
font) on non-`DISPLAY` stream (e.g., **PDF**)
Change to match 2025-02-03 discussion on Ascent/Descent
per-`CHARSETINFO` _vs._ whole `FONTDESCRIPTOR`.
(Use whole `FONTDESCRIPTOR`.)
@MattHeffron MattHeffron deleted the mth34--FONTSAMPLER-can-show-DISPLAYFONT-on-nonDISPLAY-stream-retry branch February 5, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants