-
-
Notifications
You must be signed in to change notification settings - Fork 27
FONTSAMPLER display glyphs from bitmap font to PDF (retry) #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FONTSAMPLER display glyphs from bitmap font to PDF (retry) #2008
Conversation
…n non-DISPLAY stream (e.g., PDF) Added .LCOM to repository. Corrected PR.
Converted to Draft per 2025-02-03 discussion on Ascent/Descent per |
…FO vs. whole FONTDESCRIPTOR. (Use whole FONTDESCRIPTOR.)
I have no idea why git is saying that there are merge conflicts for those two files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in meeting Mon Feb 3, 2025
It looks as though you or Ron may have merged a branch when (part of?) your FONTSAMPLER changes were present in the other branch? Have a look at the log entry for 86f5aad to 1f317d3 - co-authored by you and Ron. The branch for this PR diverged from master at db9d879, your PR 1974, and then PR 2010 appears to have your FONTSAMPLER change where the .LCOM was added to the repo - since they're all binary files, it's unable to combine the changes in this branch with the changes that have been made to the same files since the branches diverged (which is a good thing!) I haven't figured out how PR 2010 got to be the way it is/was. |
@MattHeffron - have a look at #2010 -- why did this have more than just the rename of the FONTSAMPLE files, and why did @masinter approve it given what was in it? |
That, I don't know. I thought that I was being pretty careful with only the correct files, but maybe I just missed something. |
I can fix it using direct git commands. I'll do that. |
…-nonDISPLAY-stream-retry
Need re-review now. |
@MattHeffron - I'm not 100% sure that this won't do damage. How about deleting this PR and resubmit it with only the two changed files lispusers/FONTSAMPLER and lispusers/FONTSAMPLER.LCOM |
I created new PR #2013. I'm closing this one. |
Enable FONTSAMPLER to display glyphs from DISPLAYFONT (bitmap font) on non-DISPLAY stream (e.g., PDF)
Added .LCOM to repository.
Corrected PR.