Skip to content

FONTSAMPLER can show DISPLAYFONT on non display stream (2nd retry) #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MattHeffron
Copy link
Contributor

Enable FONTSAMPLER to display glyphs from .DISPLAYFONT (bitmap font) on non-DISPLAY stream (e.g., PDF)
Change to match 2025-02-03 discussion on Ascent/Descent per-CHARSETINFO vs. whole FONTDESCRIPTOR.
(Use whole FONTDESCRIPTOR.)

Third try at a clean PR.
I checked out master and did a Pull.
I then created this new branch, copied the 2 files into lispusers (replacing the ones there), committed the changes, and created this PR.

rmkaplan and others added 28 commits January 13, 2025 09:31
Update title line
…n non-DISPLAY stream (e.g., PDF)

Added .LCOM to repository.

Corrected PR.
@MattHeffron MattHeffron requested a review from nbriggs February 4, 2025 21:59
@MattHeffron MattHeffron self-assigned this Feb 4, 2025
@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

This still has a lot of stuff in it that I don't expect to see.

I think your local copy of the master branch has had things merged into it that are making it messy. I'd suggest doing

cd medley
git checkout mth36--FONTSAMPLER-can-show-DISPLAYFONT-on-nonDISPLAY-stream-retry2 # step away from master
cp lispusers/FONTSAMPLER{,.LCOM} /tmp      # save them for safety, check these are the ones you expect
git branch -D master       # delete the local copy of master
get fetch # ensure everything is up-to-date
git checkout master       # get a fresh local copy of master
git checkout -b mth36--FONTSAMPLER-can-show-DISPLAYFONT-on-nonDISPLAY-stream-retry3 # 3rd retry lucky?
cp /tmp/FONTSAMPLER{,.LCOM} lispusers/.
git commit lispusers/FONTSAMPLER{,.LCOM}  # and edit the commit message
git push  # push it back to github
# then open the PR for the new branch in the web interface.

@nbriggs
Copy link
Contributor

nbriggs commented Feb 4, 2025

"get fetch" => "git fetch".

@MattHeffron
Copy link
Contributor Author

I think your local copy of the master branch has had things merged into it that are making it messy.

Yes! I didn't see all of these commits until the PR was created. Even then, it still shows only 2 files changed. (And the PR is supposed to be comparing vs. the master branch. 🤔

I just did a new clone from github, and I'll create the (next) new branch and copy the 2 changed files there. I'll create the PR from there.

@MattHeffron MattHeffron closed this Feb 5, 2025
MattHeffron added a commit that referenced this pull request Feb 5, 2025
…& #2008 & #2013) (#2014)

Enable **FONTSAMPLER** to display glyphs from **.DISPLAYFONT** (bitmap
font) on non-`DISPLAY` stream (e.g., **PDF**)
Change to match 2025-02-03 discussion on Ascent/Descent
per-`CHARSETINFO` _vs._ whole `FONTDESCRIPTOR`.
(Use whole `FONTDESCRIPTOR`.)
@MattHeffron MattHeffron deleted the mth36--FONTSAMPLER-can-show-DISPLAYFONT-on-nonDISPLAY-stream-retry2 branch February 5, 2025 01:56
@masinter
Copy link
Member

masinter commented Feb 5, 2025

how about adding a HCFILES translation from .DISPLAYFONT to PDF.... so that it would be easy to see what a font was?

Sybalsky had a DANCER font that I've wanted to see, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants