MOB-5132: Fix deep link issue after app is opened from notification #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roninopf Could you please start review for this ? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 62.17% 62.14% -0.03%
==========================================
Files 68 68
Lines 4013 4013
Branches 469 469
==========================================
- Hits 2495 2494 -1
- Misses 1268 1269 +1
Partials 250 250
☔ View full report in Codecov by Sentry. |
|
@roninopf We are waiting for the review of this. Please review and let us know if any issues. |
Clear.Task.RN.SDK.not.working.-.HD.1080p.movThe handler is still not called when the app is minimized or foregrounded. Only when the app is killed the handler works. Somehow the added flag of Intent.FLAG_ACTIVITY_CLEAR_TASK does not help in RN SDK |
|
Hi @Ayyanchira I am not sure why it would not work on your end but can you please try uninstalling the app and then install it again. Here are the videos of custom action handler and url handler working with CLEAR TASK. https://drive.google.com/file/d/1v_8nTGrgMNuDS83uFIEBXyQxdQXo0_MP/view?usp=sharing |
|
Looks good. Merging with master replica for final test run |
Ayyanchira
added a commit
that referenced
this pull request
Jul 12, 2023
…546) (#593) Co-authored-by: devcsomnicg <[email protected]>
evantk91
added a commit
that referenced
this pull request
Jul 17, 2023
* [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> * MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> * [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> Co-authored-by: [email protected] <[email protected]>
Ayyanchira
pushed a commit
that referenced
this pull request
Jul 31, 2023
commit e8b6532 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Fri Jul 28 10:18:02 2023 -0600 removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> commit 6f5a805 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Mon Jul 17 11:20:49 2023 -0600 [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> commit b780ec4 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:52:12 2023 -0700 MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> commit efa8d3a Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:35:59 2023 -0700 [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> commit b374b12 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jun 14 13:24:37 2023 -0700 [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>
Ayyanchira
pushed a commit
that referenced
this pull request
Aug 31, 2023
commit 1ed0c34 Author: Akshay Ayyanchira <[email protected]> Date: Thu Aug 31 13:58:56 2023 -0700 Ensure IterableTrampolineActivity always launched (#553) (#618) - Ensure IterableTrampolineActivity always launched to handle all notifications - Reverts back to launchMode="singleInstance" to ensure that the activity is always launched - Use excludeFromRecents="true" to ensure that the activity is not shown in the recent apps list Co-authored-by: Tim Nortman <[email protected]> commit f479175 Author: devcsomnicg <[email protected]> Date: Wed Aug 30 01:40:55 2023 +0530 MOB-5132 (#613) * MOB-5132: Fix deep link issue after app is opened from notification * Fix deep link for buttons It fixes the issue of deep link on buttons --------- Co-authored-by: Akshay Ayyanchira <[email protected]> commit e8b6532 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Fri Jul 28 10:18:02 2023 -0600 removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> commit 6f5a805 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Mon Jul 17 11:20:49 2023 -0600 [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> commit b780ec4 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:52:12 2023 -0700 MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> commit efa8d3a Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:35:59 2023 -0700 [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> commit b374b12 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jun 14 13:24:37 2023 -0700 [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>
evantk91
added a commit
that referenced
this pull request
Sep 7, 2023
* sets custom sound at notification channel * updates notification channel builder to set sound * minor edits * sets sound at notification channel * minor edits * sets up channel id and channel name for each unique sound * adds conditionals for default channel creation * investigating edge cases * debugging * adds default sounds for edge cases * adds default channel id and channel name for edge cases * minor edits * minor edits * cleans up conditionals * adds import for IterableNotificationTest * reorganizes and checks resources folder for matching sound file * minor edits * minor edits * minor edits * updates channel names to sound names * resolves null pointer exception for soundName * removes unneccessary package from build.gradle * README updates * [MOB-5532] - Adding remote notification sound Also removing some checks which seem removable. Still WIP * ChannelId was getting set to null when no sound * Remove all other channels which are not active Remove all the other channels which are not actively showing notification on the notification tray. Warning: Have to check if it only removes the notification created by iterable package? or the entire app's other channels as well. We might have to add iterable_ or some kind of identifier to delete only Iterable ones. * Checkstyle fix * adds resource check for existing local sound and updates soundName checks * adds soundId and soundUrl checks for channel id and channel name * passes soundId down to getSoundUri * Revert "passes soundId down to getSoundUri" This reverts commit 0d2e825. * adds null check to getSoundUri * checkstyle fix * puts sound uri check in createNotificationChannel * reorganizes to do the Uri logic in getSoundUri * checkstyle fixes * addresses comments * reverts back to not deleting inactive channels * Update iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java Co-authored-by: Akshay Ayyanchira <[email protected]> * addresses code climate fixes * [MOB-5664] - Revert channel name implementation Revert the code where the channel name was derived by reading value from Android Manifest. If not value is found, a default name "iterable channel" is provided. Now, with custom sound, if a soundURI exists from a provided custom sound, only then soundName is treated as a channel name. Otherwise, old way of handling the name still persists. * [MOB - 5694] - Add try catch around animation Adding try catch around show and hide webview animation * Log warn instead of error checkSDKInitialization logs error message. Log warning message instead * Add firetv/ott support to getmessages call * For firetv call update user with device details upon initialization * Set DEVICE_NOTIFICATIONS_ENABLED key only when registering for push * Fix firetv object structure * Review fixes * [MOB - 5873] - Public getters for Email UserID and Auth _email, _userID and _authToken to accessible by developers. :) * [MOB - 5874] - Schedule auth refresh when auth null Schedule a 10 second auto refresh for auth handler if auth token is found null when initializing. Also, when authHandler receives a authToken from handler in its handler, a similar null check will schedule 10 second refresh throwing a onTokenRegistrationFailure. This callback should allow them to refresh authToken. * create issue in jira when github issue opened * update secret names * add private constructor to prevent instance creation * update unit test * Added import for DeviceInfoUtils * Merge pull request #474 from Iterable/jay/MOB-4666-in-apps-config-memory [MOB-4666] in apps config memory * CI fix Attempt to fix this error * What went wrong: Execution failed for task ':app:processDebugAndroidTestManifest'. > Could not resolve all files for configuration ':app:debugAndroidTestRuntimeClasspath'. > Could not download kappuccino-1.2.1.aar (br.com.concretesolutions:kappuccino:1.2.1) > Could not get resource 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'. > Could not GET 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'. > Connection reset * [MOB-6055] - [OMNI CG] - Add callbacks to setting email/user id (#570) * Change for supporting callback feature on setEmail/setUserId * fixed failuire callback * add tests for setEmail and setUserId callbacks * changed to iterablehelper callbacks * update test with iterablehelper callbacks * Update IterableApi.java * Retaining the previous method signatures --------- Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> * MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> * [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> * removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> * MOB-5132 (#613) * MOB-5132: Fix deep link issue after app is opened from notification * Fix deep link for buttons It fixes the issue of deep link on buttons --------- Co-authored-by: Akshay Ayyanchira <[email protected]> * Ensure IterableTrampolineActivity always launched (#553) (#618) - Ensure IterableTrampolineActivity always launched to handle all notifications - Reverts back to launchMode="singleInstance" to ensure that the activity is always launched - Use excludeFromRecents="true" to ensure that the activity is not shown in the recent apps list Co-authored-by: Tim Nortman <[email protected]> --------- Co-authored-by: evangreer <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> Co-authored-by: “Akshay <“[email protected]”> Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: amanforindia <[email protected]> Co-authored-by: Ilya Brin <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: Ilya Brin <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Tim Nortman <[email protected]>
evantk91
pushed a commit
that referenced
this pull request
Sep 8, 2023
…546) (#593) Co-authored-by: devcsomnicg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description