[MOB 5730] Add callbacks to reading/removing in-app messages #557

devcsomnicg · 2023-04-27T14:55:22Z

🔹 JIRA Ticket(s) if any

MOB-5730

✏️ Description

Add callbacks to reading/removing in-app messages.

davidtruong · 2023-04-27T17:31:01Z

@devcsomnicg
Can you fix the codeclimate issue:
Remove this unused "callbackHandler" private field. NEW
private ResultCallbackHandler callbackHandler;

Ayyanchira

Over all, its looking great.. Added few comments

Ayyanchira · 2023-04-27T17:52:31Z

iterableapi/src/main/java/com/iterable/iterableapi/ResultCallbackHandler.java

iterable-android-sdk/iterableapi/src/main/java/com/iterable/iterableapi/util/Future.java

Lines 92 to 98 in 520f14c

public interface SuccessCallback<T> {

void onSuccess(T result);

}

public interface FailureCallback {

void onFailure(Throwable throwable);

}

Wondering if these ^ existing callbacks can be reused for callbacks instead of creating new Interface ? or will it be good to have them for sanity/separation...

Ayyanchira · 2023-04-27T17:52:57Z

iterableapi/src/test/java/com/iterable/iterableapi/IterableInboxTest.java

    }

+    @Test
+    public void testRemoveMessage() throws Exception {


Ayyanchira · 2023-04-27T18:00:19Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

    private IterableNotificationData _notificationData;
    private String _deviceId;
    private boolean _firstForegroundHandled;
+    private ResultCallbackHandler callbackHandler;


Trying to see if callback handler should be stored globally in this file. When is the value assigned to this variable? Also because many requests can trigger at same time, this might lead to some race conditions

Ayyanchira

Added some more comments

Ayyanchira · 2023-05-12T16:47:04Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

+     * @param callbackHandler The callback which returns `success` or `failure`.
     */
-    public void inAppConsume(@NonNull IterableInAppMessage message, @Nullable IterableInAppDeleteActionType source, @Nullable IterableInAppLocation clickLocation) {
+    public void inAppConsume(@NonNull IterableInAppMessage message, @Nullable IterableInAppDeleteActionType source, @Nullable IterableInAppLocation clickLocation, @Nullable ResultCallbackHandler callbackHandler) {


Will need a additional method with new parameter instead of changing this one, as this is a public method which could be used currently - to avoid breaking changes

Ayyanchira · 2023-05-12T16:57:21Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java

    }

-    public void inAppConsume(@NonNull IterableInAppMessage message, @Nullable IterableInAppDeleteActionType source, @Nullable IterableInAppLocation clickLocation, @Nullable String inboxSessionId) {
+    public void inAppConsume(@NonNull IterableInAppMessage message, @Nullable IterableInAppDeleteActionType source, @Nullable IterableInAppLocation clickLocation, @Nullable String inboxSessionId, @Nullable final ResultCallbackHandler callbackHandler) {


Use two separate callbacks.
One for success and failure.
And reuse - IterableHelper.success and failure callbacks in the method signature.

Ayyanchira · 2023-05-12T16:58:18Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

        }
-
-        apiClient.inAppConsume(message, source, clickLocation, inboxSessionId);
+        apiClient.inAppConsume(message, source, clickLocation, inboxSessionId, callbackHandler);


two callbackHandlers (success and failure) instead of one for consistency.

Ayyanchira · 2023-05-12T17:00:58Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java


        if (message.isMarkedForDeletion() && !message.isConsumed()) {
-            IterableApi.sharedInstance.getInAppManager().removeMessage(message);
+            IterableApi.sharedInstance.getInAppManager().removeMessage(message, null);


This can stay like before. The new method with new parameters will be for explicit use by developers.

Ayyanchira

Left some comments

Ayyanchira · 2023-05-15T20:54:18Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java

+     * @param callbackHandler The callback which returns `success` or `failure`.
     */
-    public synchronized void setRead(@NonNull IterableInAppMessage message, boolean read) {
+    public synchronized void setRead(@NonNull IterableInAppMessage message, boolean read, @Nullable ResultCallbackHandler callbackHandler) {


Marking as read / setRead can be a separate PR of its own. This PR can confine to removeMessage

Ayyanchira · 2023-05-15T20:54:48Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java

+        if(callbackHandler != null){
+            callbackHandler.sendResult(true);
+        }


This will be part of next PR for setRead

Ayyanchira · 2023-05-15T20:55:29Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java

+     * @param callbackHandler The callback which returns `success` or `failure`.
     */
-    public synchronized void removeMessage(@NonNull IterableInAppMessage message) {
+    public synchronized void removeMessage(@NonNull IterableInAppMessage message, @Nullable ResultCallbackHandler callbackHandler) {


ResultCallbackHandler -> IterableCallbackHandler for success and failure -> in a new method

Ayyanchira · 2023-05-15T20:56:50Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java

    }

-    public synchronized void removeMessage(@NonNull IterableInAppMessage message, @NonNull IterableInAppDeleteActionType source, @NonNull IterableInAppLocation clickLocation) {
+    public synchronized void removeMessage(@NonNull IterableInAppMessage message, @NonNull IterableInAppDeleteActionType source, @NonNull IterableInAppLocation clickLocation, @Nullable ResultCallbackHandler callbackHandler) {


ResultCallbackHandler > Iterable success and failure callback handler.
A new method needed

Ayyanchira · 2023-05-15T20:57:22Z

iterableapi/src/main/java/com/iterable/iterableapi/ResultCallbackHandler.java

To use Iterable pre existing callbacks

Ayyanchira · 2023-05-15T21:01:01Z

iterableapi/src/test/java/com/iterable/iterableapi/IterableInboxTest.java

+        assertEquals(2, inboxMessages.size());
+        assertEquals(1, inAppManager.getUnreadInboxMessagesCount());
+        inAppManager.removeMessage(inboxMessages.get(0), IterableInAppLocation.inbox, IterableInAppDeleteSource.deleteButton, new IterableHelper.SuccessHandler() {
+            @Override


Reverify this block to see if it works as expected as the callback has different handler in the definition above.

Ayyanchira · 2023-05-15T21:01:22Z

iterableapi/src/test/java/com/iterable/iterableapi/IterableInboxTest.java

+
    @Test
    public void testSetRead() throws Exception {
+        // Set up mock response


Test set read can be part of next PR

devcsomnicg · 2023-05-29T12:55:56Z

@Ayyanchira Changes done as per suggestions. Sorry but setRead changes are in the same PR as it was part of same ticket. Please review and let me know if anything still needs improvement, thanks

Ayyanchira

Added some comments

Ayyanchira · 2023-06-05T16:31:31Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java

+     * @param successHandler The callback which returns `success`.
     */
-    public synchronized void setRead(@NonNull IterableInAppMessage message, boolean read) {
+    public synchronized void setRead(@NonNull IterableInAppMessage message, boolean read, @Nullable IterableHelper.SuccessHandler successHandler) {


Why no failure callback for setRead?

@Ayyanchira I checked the code but there is no scenario of failure here, that's why I removed an unused param for failure. Please let me know if I am wrong.

Ayyanchira · 2023-06-05T16:33:55Z

iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java

    @Override
    public void onListItemTapped(@NonNull IterableInAppMessage message) {
-        IterableApi.getInstance().getInAppManager().setRead(message, true);
+        IterableApi.getInstance().getInAppManager().setRead(message, true, null);


Not for this PR but inbox fragment can also have placeholders for success and failure callback make use of them..

Ayyanchira · 2023-06-05T16:36:14Z

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

+    public void inAppConsume(@NonNull String messageId, @Nullable IterableHelper.SuccessHandler successHandler, @Nullable IterableHelper.FailureHandler failureHandler) {
+        IterableInAppMessage message = getInAppManager().getMessageById(messageId);
+        if (message == null) {
+            IterableLogger.e(TAG, "inAppConsume: message is null");


call failure callback here when we see message is not found.

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

* add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]>

…583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>

commit b374b12 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jun 14 13:24:37 2023 -0700 [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>

* [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> * MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> * [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> Co-authored-by: [email protected] <[email protected]>

commit e8b6532 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Fri Jul 28 10:18:02 2023 -0600 removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> commit 6f5a805 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Mon Jul 17 11:20:49 2023 -0600 [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> commit b780ec4 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:52:12 2023 -0700 MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> commit efa8d3a Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:35:59 2023 -0700 [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> commit b374b12 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jun 14 13:24:37 2023 -0700 [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>

commit 1ed0c34 Author: Akshay Ayyanchira <[email protected]> Date: Thu Aug 31 13:58:56 2023 -0700 Ensure IterableTrampolineActivity always launched (#553) (#618) - Ensure IterableTrampolineActivity always launched to handle all notifications - Reverts back to launchMode="singleInstance" to ensure that the activity is always launched - Use excludeFromRecents="true" to ensure that the activity is not shown in the recent apps list Co-authored-by: Tim Nortman <[email protected]> commit f479175 Author: devcsomnicg <[email protected]> Date: Wed Aug 30 01:40:55 2023 +0530 MOB-5132 (#613) * MOB-5132: Fix deep link issue after app is opened from notification * Fix deep link for buttons It fixes the issue of deep link on buttons --------- Co-authored-by: Akshay Ayyanchira <[email protected]> commit e8b6532 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Fri Jul 28 10:18:02 2023 -0600 removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> commit 6f5a805 Author: Evan Takeo Kanaiaupuni Greer <[email protected]> Date: Mon Jul 17 11:20:49 2023 -0600 [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> commit b780ec4 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:52:12 2023 -0700 MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> commit efa8d3a Author: Akshay Ayyanchira <[email protected]> Date: Wed Jul 12 06:35:59 2023 -0700 [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> commit b374b12 Author: Akshay Ayyanchira <[email protected]> Date: Wed Jun 14 13:24:37 2023 -0700 [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>

* sets custom sound at notification channel * updates notification channel builder to set sound * minor edits * sets sound at notification channel * minor edits * sets up channel id and channel name for each unique sound * adds conditionals for default channel creation * investigating edge cases * debugging * adds default sounds for edge cases * adds default channel id and channel name for edge cases * minor edits * minor edits * cleans up conditionals * adds import for IterableNotificationTest * reorganizes and checks resources folder for matching sound file * minor edits * minor edits * minor edits * updates channel names to sound names * resolves null pointer exception for soundName * removes unneccessary package from build.gradle * README updates * [MOB-5532] - Adding remote notification sound Also removing some checks which seem removable. Still WIP * ChannelId was getting set to null when no sound * Remove all other channels which are not active Remove all the other channels which are not actively showing notification on the notification tray. Warning: Have to check if it only removes the notification created by iterable package? or the entire app's other channels as well. We might have to add iterable_ or some kind of identifier to delete only Iterable ones. * Checkstyle fix * adds resource check for existing local sound and updates soundName checks * adds soundId and soundUrl checks for channel id and channel name * passes soundId down to getSoundUri * Revert "passes soundId down to getSoundUri" This reverts commit 0d2e825. * adds null check to getSoundUri * checkstyle fix * puts sound uri check in createNotificationChannel * reorganizes to do the Uri logic in getSoundUri * checkstyle fixes * addresses comments * reverts back to not deleting inactive channels * Update iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java Co-authored-by: Akshay Ayyanchira <[email protected]> * addresses code climate fixes * [MOB-5664] - Revert channel name implementation Revert the code where the channel name was derived by reading value from Android Manifest. If not value is found, a default name "iterable channel" is provided. Now, with custom sound, if a soundURI exists from a provided custom sound, only then soundName is treated as a channel name. Otherwise, old way of handling the name still persists. * [MOB - 5694] - Add try catch around animation Adding try catch around show and hide webview animation * Log warn instead of error checkSDKInitialization logs error message. Log warning message instead * Add firetv/ott support to getmessages call * For firetv call update user with device details upon initialization * Set DEVICE_NOTIFICATIONS_ENABLED key only when registering for push * Fix firetv object structure * Review fixes * [MOB - 5873] - Public getters for Email UserID and Auth _email, _userID and _authToken to accessible by developers. :) * [MOB - 5874] - Schedule auth refresh when auth null Schedule a 10 second auto refresh for auth handler if auth token is found null when initializing. Also, when authHandler receives a authToken from handler in its handler, a similar null check will schedule 10 second refresh throwing a onTokenRegistrationFailure. This callback should allow them to refresh authToken. * create issue in jira when github issue opened * update secret names * add private constructor to prevent instance creation * update unit test * Added import for DeviceInfoUtils * Merge pull request #474 from Iterable/jay/MOB-4666-in-apps-config-memory [MOB-4666] in apps config memory * CI fix Attempt to fix this error * What went wrong: Execution failed for task ':app:processDebugAndroidTestManifest'. > Could not resolve all files for configuration ':app:debugAndroidTestRuntimeClasspath'. > Could not download kappuccino-1.2.1.aar (br.com.concretesolutions:kappuccino:1.2.1) > Could not get resource 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'. > Could not GET 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'. > Connection reset * [MOB-6055] - [OMNI CG] - Add callbacks to setting email/user id (#570) * Change for supporting callback feature on setEmail/setUserId * fixed failuire callback * add tests for setEmail and setUserId callbacks * changed to iterablehelper callbacks * update test with iterablehelper callbacks * Update IterableApi.java * Retaining the previous method signatures --------- Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) (#583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”> * [MOB - 6493] - Message read and remove bug fix (#592) Co-authored-by: “Akshay <“[email protected]”> * MOB-5132: Fix deep link issue after app is opened from notification (#546) (#593) Co-authored-by: devcsomnicg <[email protected]> * [MOB-6309] prepares EUDC updates for release (#572) * stashed changes * adds data center to config and associated unit tests * adds excluding kotlin files to javadoc check * moves IterableDataRegion to IterableConstants.java * gets rid of extra lines * removes jacoco.exe * adds endpoint override to IterableApi * removes logging statement * sets up base url at IterableRequestTask * minor edits * refactors to pull endpoint directly from config value * removes unfinished unit test * removes jacoco.exec * removes white space --------- Co-authored-by: [email protected] <[email protected]> * removes extra dependency (#609) Co-authored-by: [email protected] <[email protected]> * MOB-5132 (#613) * MOB-5132: Fix deep link issue after app is opened from notification * Fix deep link for buttons It fixes the issue of deep link on buttons --------- Co-authored-by: Akshay Ayyanchira <[email protected]> * Ensure IterableTrampolineActivity always launched (#553) (#618) - Ensure IterableTrampolineActivity always launched to handle all notifications - Reverts back to launchMode="singleInstance" to ensure that the activity is always launched - Use excludeFromRecents="true" to ensure that the activity is not shown in the recent apps list Co-authored-by: Tim Nortman <[email protected]> --------- Co-authored-by: evangreer <[email protected]> Co-authored-by: Brad Umbaugh <[email protected]> Co-authored-by: “Akshay <“[email protected]”> Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: amanforindia <[email protected]> Co-authored-by: Ilya Brin <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: Ilya Brin <[email protected]> Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Tim Nortman <[email protected]>

…583) * [MOB 5730] Add callbacks to reading/removing in-app messages (#557) * add callback for setRead/removeMessage * modify test for setRead and added test for removeMessage * fixes * Update build.gradle * removed resultcallbackhandler * Update IterableInAppManager.java * fixes --------- Co-authored-by: Akshay Ayyanchira <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> * Fixing and adding test method --------- Co-authored-by: devcsomnicg <[email protected]> Co-authored-by: Hardik Mashru <[email protected]> Co-authored-by: “Akshay <“[email protected]”>

devcsomnicg added 2 commits April 27, 2023 19:11

add callback for setRead/removeMessage

d92966e

modify test for setRead and added test for removeMessage

ebcb56e

davidtruong requested a review from Ayyanchira April 27, 2023 17:29

Ayyanchira reviewed Apr 27, 2023

View reviewed changes

Ayyanchira reviewed May 12, 2023

View reviewed changes

Merge branch 'master' into MOB-5730

0163244

Ayyanchira reviewed May 15, 2023

View reviewed changes

devcsomnicg added 3 commits May 29, 2023 18:21

fixes

f10b11b

Update build.gradle

c076711

removed resultcallbackhandler

3e6b7fe

Update IterableInAppManager.java

56ba489

Ayyanchira reviewed Jun 5, 2023

View reviewed changes

Ayyanchira and others added 2 commits June 5, 2023 12:39

Merge branch 'master' into MOB-5730

4817f7e

fixes

f302636

Ayyanchira changed the base branch from master to omni-cg-master-pr/mob-5730-callbacks-to-inapp June 12, 2023 19:41

Ayyanchira merged commit 8c70d0a into Iterable:omni-cg-master-pr/mob-5730-callbacks-to-inapp Jun 12, 2023

	public interface SuccessCallback<T> {
	void onSuccess(T result);
	}

	public interface FailureCallback {
	void onFailure(Throwable throwable);
	}

[MOB 5730] Add callbacks to reading/removing in-app messages #557

[MOB 5730] Add callbacks to reading/removing in-app messages #557

Uh oh!

Conversation

devcsomnicg commented Apr 27, 2023 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

davidtruong commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devcsomnicg commented May 29, 2023

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devcsomnicg commented Apr 27, 2023 •

edited by atlassian bot

Loading

davidtruong commented Apr 27, 2023 •

edited

Loading