Skip to content

Updated the call of lsim in test_timeresp.jl to use keyword arguments… #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Conversation

hurak
Copy link
Contributor

@hurak hurak commented Mar 8, 2019

… for x0. The same modification done in timeresp.jl, wherein additionally the string for the label was corrected (transpose removed) and using Plots added.

… for x0. The same modification done in timeresp.jl, wherein additionally the string for the label was corrected (transpose removed) and `using Plots` added.
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 56.038% when pulling 45ae08c on hurak:master into f54a87e on JuliaControl:master.

@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage remained the same at 56.038% when pulling ff1ddc4 on hurak:master into 721654c on JuliaControl:master.

Copy link
Member

@baggepinnen baggepinnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The semicolon is not needed at the call site, although it is accepted

@hurak
Copy link
Contributor Author

hurak commented Mar 9, 2019

Thanks for the fix. The semicolon is not needed at the call site, although it is accepted

Indeed, the semicolon is not needed. In fact, as I read it now in Julia (v1.1) manual, they explicitly state "When the function is called, the semicolon is optional: one can either call plot(x, y, width=2) or plot(x, y; width=2), but the former style is more common." You should have left it your way then. Hopefully, at least the other part of my fix was useful.

Well, my first PR ever :-)

Thanks for a good work. As a teacher of optimal and robust control (https://moodle.fel.cvut.cz/course/view.php?id=3866), I am tempted to use your package in the course. Towards that goal, I hope to be able to start submitting to your package.

@baggepinnen
Copy link
Member

Great to hear! Check out #192 for upcoming robust control functionality

@mfalt
Copy link
Member

mfalt commented Mar 12, 2019

Thanks!

@mfalt mfalt merged commit b625d9e into JuliaControl:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants