-
Notifications
You must be signed in to change notification settings - Fork 89
Updated the call of lsim in test_timeresp.jl to use keyword arguments… #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… for x0. The same modification done in timeresp.jl, wherein additionally the string for the label was corrected (transpose removed) and `using Plots` added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. The semicolon is not needed at the call site, although it is accepted
Indeed, the semicolon is not needed. In fact, as I read it now in Julia (v1.1) manual, they explicitly state "When the function is called, the semicolon is optional: one can either call plot(x, y, width=2) or plot(x, y; width=2), but the former style is more common." You should have left it your way then. Hopefully, at least the other part of my fix was useful. Well, my first PR ever :-) Thanks for a good work. As a teacher of optimal and robust control (https://moodle.fel.cvut.cz/course/view.php?id=3866), I am tempted to use your package in the course. Towards that goal, I hope to be able to start submitting to your package. |
Great to hear! Check out #192 for upcoming robust control functionality |
Thanks! |
… for x0. The same modification done in timeresp.jl, wherein additionally the string for the label was corrected (transpose removed) and
using Plots
added.