[LLVM] Manually prefix ManagedStatic static vars #38488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
using Libdl
dlopen("/husr/lib/libLLVM-11.so")
```
Currently crashes with:
```
julia> dlopen("/usr/lib/libLLVM-11.so")
julia: /home/vchuravy/src/julia/deps/srccache/llvm-11.0.0/include/llvm/Support/CommandLine.h:851: void llvm::cl::parser<DataType>::addLiteralOption(llvm::StringRef, const DT&, llvm::StringRef) [with DT = llvm::FunctionPass* (*)(); DataType = llvm::FunctionPass* (*)()]: Assertion `findOption(Name) == Values.size() && "Option already exists!"' failed.
signal (6): Aborted
in expression starting at REPL[2]:1
gsignal at /usr/lib/libc.so.6 (unknown line)
abort at /usr/lib/libc.so.6 (unknown line)
__assert_fail_base.cold at /usr/lib/libc.so.6 (unknown line)
__assert_fail at /usr/lib/libc.so.6 (unknown line)
addLiteralOption<llvm::FunctionPass* (*)()> at /home/vchuravy/src/julia/deps/srccache/llvm-11.0.0/include/llvm/Support/CommandLine.h:851
NotifyAdd at /home/vchuravy/src/julia/deps/srccache/llvm-11.0.0/include/llvm/CodeGen/MachinePassRegistry.h:162
unknown function (ip: 0x7f94eabfb608)
call_init.part.0 at /lib64/ld-linux-x86-64.so.2 (unknown line)
_dl_init at /lib64/ld-linux-x86-64.so.2 (unknown line)
_dl_catch_exception at /usr/lib/libc.so.6 (unknown line)
dl_open_worker at /lib64/ld-linux-x86-64.so.2 (unknown line)
_dl_catch_exception at /usr/lib/libc.so.6 (unknown line)
_dl_open at /lib64/ld-linux-x86-64.so.2 (unknown line)
unknown function (ip: 0x7f953494f34b)
_dl_catch_exception at /usr/lib/libc.so.6 (unknown line)
_dl_catch_error at /usr/lib/libc.so.6 (unknown line)
unknown function (ip: 0x7f953494fb88)
dlopen at /usr/lib/libdl.so.2 (unknown line)
```
I have hypothesized that this boils down to static variables being
merged..., they are not exported so they should stay separate, but
somehow we still run into this wonderful issue.
|
Opened an upstream bug report to see if this is the right approach. https://bugs.llvm.org/show_bug.cgi?id=48221 |
|
This was superseded by #39390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently crashes with:
I have hypothesized that this boils down to static variables being
merged..., they are not exported so they should stay separate, but
somehow we still run into this wonderful issue.
cc: @staticfloat @maleadt