Set -fno-gnu-unique for building LLVM #39390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system that uses a Radeon GPU the codesnippet below (from #37200)
crashes with
The last time I dug into this it tourned out to be a problem with how gcc handles static variables
in particular it annotating them with
GNU_UNIQUE
and glibc promptly ignoring symbol versions ofsymbols marked such.
Upstream bug report: https://bugs.llvm.org/show_bug.cgi?id=48221
I never got a reply on libc-help when I asked if that behaviour is intended https://sourceware.org/pipermail/libc-help/2020-November/005559.html
On the LLVM discord I got the recommendation to build LLVM with
-fno-gnu-unique
cc: @wsmoses in case this impacts LLVM plugins
If this looks okay, I will fix this in Yggdrasil as well.