Revert "Emulated fma"
#42950
Closed
Revert "Emulated fma"
#42950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
system:windows
|
I'm going to merge this when CI is passing, because currently every We can reland a fixed version of the PR once the issue is identified. |
|
don't merge this just merge reverting the added tests. |
DilumAluthge
removed
the
merge me
|
Can you make a PR? |
|
Alternatively, instead of removing the tests in question, you could just skip them if running on 64-bit Windows. |
|
Disabling the tests only on win64 for now seems better. |
|
here you go. #42955. |
|
Thank you!! |
|
Seems standard to revert the PR. If only the tests are reverted things are still broken... |
|
the reasoning behind reverting only the tests is that I think the test uncovered existing broken behavior rather than the pr introducing new breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42783
This PR broke the
tester_win64CI job on Buildbot.