revert fma tests on windows #42955
Merged
revert fma tests on windows #42955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DilumAluthge
added
merge me
|
@DilumAluthge Any idea why linux64 failed here? I can't tell from the logs. |
|
Hmmm. I'm not sure. But if you look at master (4c6696e), the linux64 tests are passing on master. |
|
@oscardssmith Do you know if win64 + openlibm does pass these new tests? I don't think we ever tried. |
|
Not 100% sure. They should, since the openlibm implementation is pretty solid. That said, I've been unable to reproduce the failure on the windows hardware I have access to, so I'm very unsure what the problem could be. |
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #42942 somehow didn't fix it, this is the temporary sledgehammer that will get tests passing while I figure out how windows is managing to fail here.