Tentative implementation of a hashtable for type_in_worklist #53749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is correct to share it. In theory, the second one could be replaced by a lookup into this map as well, as the first step populated all of the tables and then the saving step is just a lookup into those results. |
|
Replaced by #57917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is pretty simple, though I have some questions for either @vtjnash or @vchuravy . type_in_worklist is called when both saving to stream and preparing the serialization data. Should I reinit the hashtable between or is it correct to share it like here.
This should fix #53331 but the example there is currently broken on master.